Make transformer configs array-aware

If path segments end with the special marker `[]` in transformer configs, this
indicates that the respective path segment is supposed to be an array. That
information may be used to suppress the meaningless creation of non-existent
paths that should be arrays, not objects.
This commit is contained in:
Tom Wieczorek
2018-12-09 01:02:44 +01:00
parent 63e4e5ccaa
commit c470982ce5
7 changed files with 131 additions and 6 deletions

View File

@@ -110,7 +110,7 @@ commonLabels:
group: apps
kind: StatefulSet
- path: spec/volumeClaimTemplates/metadata/labels
- path: spec/volumeClaimTemplates[]/metadata/labels
create: true
group: apps
kind: StatefulSet

View File

@@ -33,18 +33,20 @@ func mutateField(
return nil
}
_, found := m[pathToField[0]]
firstPathSegment, isArray := getFirstPathSegment(pathToField)
_, found := m[firstPathSegment]
if !found {
if !createIfNotPresent {
if !createIfNotPresent || isArray {
return nil
}
m[pathToField[0]] = map[string]interface{}{}
m[firstPathSegment] = map[string]interface{}{}
}
if len(pathToField) == 1 {
var err error
for _, fn := range fns {
m[pathToField[0]], err = fn(m[pathToField[0]])
m[firstPathSegment], err = fn(m[firstPathSegment])
if err != nil {
return err
}
@@ -52,7 +54,7 @@ func mutateField(
return nil
}
v := m[pathToField[0]]
v := m[firstPathSegment]
newPathToField := pathToField[1:]
switch typedV := v.(type) {
case nil:
@@ -79,3 +81,10 @@ func mutateField(
return fmt.Errorf("%#v is not expected to be a primitive type", typedV)
}
}
func getFirstPathSegment(pathToField []string) (string, bool) {
if strings.HasSuffix(pathToField[0], "[]") {
return pathToField[0][:len(pathToField[0])-2], true
}
return pathToField[0], false
}