From 9989b5fc84077cdd16e5bc03581827481853a272 Mon Sep 17 00:00:00 2001 From: Jeremy Date: Mon, 12 Apr 2021 13:12:53 -0600 Subject: [PATCH] Add check of UpdateExpectedFromActual before skipping test Signed-off-by: Jeremy --- kyaml/fn/framework/frameworktestutil/frameworktestutil.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kyaml/fn/framework/frameworktestutil/frameworktestutil.go b/kyaml/fn/framework/frameworktestutil/frameworktestutil.go index c2d17d9b6..13693c1b7 100644 --- a/kyaml/fn/framework/frameworktestutil/frameworktestutil.go +++ b/kyaml/fn/framework/frameworktestutil/frameworktestutil.go @@ -111,8 +111,8 @@ func (rc *CommandResultsChecker) compare(t *testing.T, path string) { args := []string{rc.ConfigInputFilename} expectedOutput, expectedError := getExpected(t, rc.ExpectedOutputFilename, rc.ExpectedErrorFilename) - if expectedError == "" && expectedOutput == "" { - // missing expected + if expectedError == "" && expectedOutput == "" && !rc.UpdateExpectedFromActual { + // missing expected and UpdateExpectedFromActual == false, return and skip this test return } require.NoError(t, err) @@ -251,8 +251,8 @@ func (rc *ProcessorResultsChecker) compare(t *testing.T, path string) { require.NoError(t, err) expectedOutput, expectedError := getExpected(t, rc.ExpectedOutputFilename, rc.ExpectedErrorFilename) - if expectedError == "" && expectedOutput == "" { - // missing expected + if expectedError == "" && expectedOutput == "" && !rc.UpdateExpectedFromActual { + // missing expected and UpdateExpectedFromActual == false, return and skip this test return }