kubernetes-sigs/kustomize
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/kustomize.git synced 2026-06-30 01:46:23 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Fix some random Go nits.

Browse Source
This commit is contained in:
jregan
2019-06-25 20:46:56 -07:00
parent 69d40bd740
commit cc0fffc67b
9 changed files with 22 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/plugins/loader.go
View File

@@ -146,7 +146,7 @@ var registry = make(map[string]Configurable)
func (l *Loader) loadGoPlugin(id resid.ResId) (Configurable, error) {
regId := relativePluginPath(id)
if c, ok := registry[regId]; ok {
return copy(c), nil
return copyPlugin(c), nil
}
absPath := l.absolutePluginPath(id)
p, err := plugin.Open(absPath + ".so")
@@ -164,11 +164,11 @@ func (l *Loader) loadGoPlugin(id resid.ResId) (Configurable, error) {
return nil, fmt.Errorf("plugin %s not configurable", regId)
}
registry[regId] = c
return copy(c), nil
return copyPlugin(c), nil
}
func copy(i interface{}) Configurable {
indirect := reflect.Indirect(reflect.ValueOf(i))
func copyPlugin(c Configurable) Configurable {
indirect := reflect.Indirect(reflect.ValueOf(c))
newIndirect := reflect.New(indirect.Type())
newIndirect.Elem().Set(reflect.ValueOf(indirect.Interface()))
newNamed := newIndirect.Interface()

3
pkg/target/transformerplugin_test.go
View File

@@ -7,9 +7,8 @@ import (
"strings"
"testing"
"sigs.k8s.io/kustomize/v3/pkg/kusttest"
"sigs.k8s.io/kustomize/v3/pkg/plugins"
kusttest_test "sigs.k8s.io/kustomize/v3/pkg/kusttest"
)
func writeDeployment(th *kusttest_test.KustTestHarness, path string) {

2
pkg/target/transformersarrays_test.go
View File

@@ -6,7 +6,7 @@ package target_test
import (
"testing"
kusttest_test "sigs.k8s.io/kustomize/v3/pkg/kusttest"
"sigs.k8s.io/kustomize/v3/pkg/kusttest"
)
func makeStatefulSetKustomization(th *kusttest_test.KustTestHarness) {