From cd2ebd30465753dbb59483756278f23a00d4f9af Mon Sep 17 00:00:00 2001 From: Donny Xia Date: Tue, 27 Oct 2020 15:10:29 -0700 Subject: [PATCH] code review --- api/types/patch.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/api/types/patch.go b/api/types/patch.go index e98764bd7..48b521d7e 100644 --- a/api/types/patch.go +++ b/api/types/patch.go @@ -18,11 +18,11 @@ type Patch struct { Target *Selector `json:"target,omitempty" yaml:"target,omitempty"` } -// Equals return true if p equals another. -func (p *Patch) Equals(another Patch) bool { - targetEqual := (p.Target == another.Target) || - (p.Target != nil && another.Target != nil && *p.Target == *another.Target) - return p.Path == another.Path && - p.Patch == another.Patch && +// Equals return true if p equals o. +func (p *Patch) Equals(o Patch) bool { + targetEqual := (p.Target == o.Target) || + (p.Target != nil && o.Target != nil && *p.Target == *o.Target) + return p.Path == o.Path && + p.Patch == o.Patch && targetEqual }