openapi parsing performance improvement with protobuffer (#4568)

* update necessary dependencies

* update openapi test structure

* remove old swagger files and generate new ones

* use protobuffer to parse openapi for performance improvement
This commit is contained in:
Natasha Sarkar
2022-04-18 11:10:43 -07:00
committed by GitHub
parent 9452a031ba
commit cf89eae804
51 changed files with 40422 additions and 145215 deletions

View File

@@ -9,56 +9,16 @@ import (
openapi_v2 "github.com/google/gnostic/openapiv2"
"google.golang.org/protobuf/proto"
"k8s.io/kube-openapi/pkg/validation/spec"
"sigs.k8s.io/kustomize/kyaml/openapi/kubernetesapi"
"sigs.k8s.io/kustomize/kyaml/openapi/kubernetesapi/v1218pb"
v1212 "sigs.k8s.io/kustomize/kyaml/openapi/kubernetesapi/v1212"
)
// Benchmark for swagger parsing (UnmarshalJSON)
func BenchmarkSwaggerUnmarshalJSON(t *testing.B) {
version := kubernetesOpenAPIDefaultVersion
// parse the swagger, this should never fail
assetName := filepath.Join(
"kubernetesapi",
version,
"swagger.json")
b := kubernetesapi.OpenAPIMustAsset[version](assetName)
for i := 0; i < t.N; i++ {
var swagger spec.Swagger
if err := swagger.UnmarshalJSON(b); err != nil {
t.Fatalf("swagger.UnmarshalJSON failed: %v", err)
}
}
}
func BenchmarkOpenAPIV2ParseDocument(t *testing.B) {
version := kubernetesOpenAPIDefaultVersion
assetName := filepath.Join(
"kubernetesapi",
version,
"swagger.json")
b := kubernetesapi.OpenAPIMustAsset[version](assetName)
for i := 0; i < t.N; i++ {
// We parse JSON and get an openapiv2.Document here.
if _, err := openapi_v2.ParseDocument(b); err != nil {
t.Fatalf("openapi_v2.ParseDocument failed: %v", err)
}
}
}
func BenchmarkProtoUnmarshal(t *testing.B) {
assetName := filepath.Join(
"kubernetesapi",
"v1218pb",
"v1212",
"swagger.pb")
b := v1218pb.MustAsset(assetName)
b := v1212.MustAsset(assetName)
for i := 0; i < t.N; i++ {
// We parse protobuf and get an openapiv2.Document here.
@@ -67,18 +27,3 @@ func BenchmarkProtoUnmarshal(t *testing.B) {
}
}
}
// Benchmark for loading assets packed into the binary
func BenchmarkAssetRead(t *testing.B) {
for i := 0; i < t.N; i++ {
version := kubernetesOpenAPIDefaultVersion
// parse the swagger, this should never fail
assetName := filepath.Join(
"kubernetesapi",
version,
"swagger.json")
kubernetesapi.OpenAPIMustAsset[version](assetName)
}
}