Adapt more LocalPackageReader tests

This commit is contained in:
Francesc Campoy
2021-07-15 18:21:42 -07:00
parent e8a4bf6edc
commit d37fa66ebc

View File

@@ -71,6 +71,7 @@ func TestLocalPackageReader_Read_pkg(t *testing.T) {
require.NoError(t, fs.WriteFile("b_test.yaml", readFileB)) require.NoError(t, fs.WriteFile("b_test.yaml", readFileB))
require.NoError(t, fs.WriteFile("c_test.yaml", readFileC)) require.NoError(t, fs.WriteFile("c_test.yaml", readFileC))
require.NoError(t, fs.WriteFile("d_test.yaml", readFileD)) require.NoError(t, fs.WriteFile("d_test.yaml", readFileD))
testLocalPackageReaderReadPkg(t, "/", fs) testLocalPackageReaderReadPkg(t, "/", fs)
}) })
} }
@@ -126,25 +127,38 @@ metadata:
} }
func TestLocalPackageReader_Read_pkgAndSkipFile(t *testing.T) { func TestLocalPackageReader_Read_pkgAndSkipFile(t *testing.T) {
t.Run("on_disk", func(t *testing.T) {
s := SetupDirectories(t, filepath.Join("a", "b"), filepath.Join("a", "c")) s := SetupDirectories(t, filepath.Join("a", "b"), filepath.Join("a", "c"))
defer s.Clean() defer s.Clean()
s.WriteFile(t, filepath.Join("a_test.yaml"), readFileA) s.WriteFile(t, "a_test.yaml", readFileA)
s.WriteFile(t, filepath.Join("b_test.yaml"), readFileB) s.WriteFile(t, "b_test.yaml", readFileB)
s.WriteFile(t, filepath.Join("c_test.yaml"), readFileC) s.WriteFile(t, "c_test.yaml", readFileC)
s.WriteFile(t, filepath.Join("d_test.yaml"), readFileD) s.WriteFile(t, "d_test.yaml", readFileD)
paths := []struct { testLocalPackageReaderReadPkgAndSkipFile(t, "./", nil)
path string testLocalPackageReaderReadPkgAndSkipFile(t, s.Root, nil)
}{ })
{path: "./"},
{path: s.Root}, t.Run("on_mem", func(t *testing.T) {
fs := filesys.MakeFsInMemory()
require.NoError(t, fs.MkdirAll(filepath.Join("a", "b")))
require.NoError(t, fs.MkdirAll(filepath.Join("a", "c")))
require.NoError(t, fs.WriteFile("a_test.yaml", readFileA))
require.NoError(t, fs.WriteFile("b_test.yaml", readFileB))
require.NoError(t, fs.WriteFile("c_test.yaml", readFileC))
require.NoError(t, fs.WriteFile("d_test.yaml", readFileD))
testLocalPackageReaderReadPkgAndSkipFile(t, "/", fs)
})
} }
for _, p := range paths {
func testLocalPackageReaderReadPkgAndSkipFile(t *testing.T, path string, mockFS filesys.FileSystem) {
rfr := LocalPackageReader{ rfr := LocalPackageReader{
PackagePath: p.path, PackagePath: path,
FileSkipFunc: func(relPath string) bool { FileSkipFunc: func(relPath string) bool {
return relPath == "d_test.yaml" return relPath == "d_test.yaml"
}, },
FileSystem: filesys.FileSystemOrOnDisk{FileSystem: mockFS},
} }
nodes, err := rfr.Read() nodes, err := rfr.Read()
if !assert.NoError(t, err) { if !assert.NoError(t, err) {
@@ -187,46 +201,50 @@ metadata:
} }
for i := range nodes { for i := range nodes {
val, err := nodes[i].String() val, err := nodes[i].String()
if !assert.NoError(t, err) { require.NoError(t, err)
return require.Equal(t, expected[i], val)
}
if !assert.Equal(t, expected[i], val) {
return
}
}
} }
} }
func TestLocalPackageReader_Read_JSON(t *testing.T) { func TestLocalPackageReader_Read_JSON(t *testing.T) {
s := SetupDirectories(t, filepath.Join("a", "b"), filepath.Join("a", "c")) aTestJSON := []byte(`{
defer s.Clean()
s.WriteFile(t, filepath.Join("a_test.json"), []byte(`{
"a": "b" "a": "b"
}`)) }`)
s.WriteFile(t, filepath.Join("b_test.json"), []byte(`{ bTestJSON := []byte(`{
"e": "f", "e": "f",
"g": { "g": {
"h": ["i", "j"] "h": ["i", "j"]
} }
}`)) }`)
paths := []struct { t.Run("on_disk", func(t *testing.T) {
path string s := SetupDirectories(t, filepath.Join("a", "b"), filepath.Join("a", "c"))
}{ defer s.Clean()
{path: "./"},
{path: s.Root}, s.WriteFile(t, "a_test.json", aTestJSON)
s.WriteFile(t, "b_test.json", bTestJSON)
testLocalPackageReaderReadJSON(t, "./", nil)
testLocalPackageReaderReadJSON(t, s.Root, nil)
})
t.Run("on_mem", func(t *testing.T) {
fs := filesys.MakeFsInMemory()
require.NoError(t, fs.MkdirAll(filepath.Join("a", "b")))
require.NoError(t, fs.MkdirAll(filepath.Join("a", "c")))
require.NoError(t, fs.WriteFile("a_test.json", aTestJSON))
require.NoError(t, fs.WriteFile("b_test.json", bTestJSON))
testLocalPackageReaderReadJSON(t, "/", fs)
})
} }
for _, p := range paths {
rfr := LocalPackageReader{PackagePath: p.path, MatchFilesGlob: []string{"*.json"}} func testLocalPackageReaderReadJSON(t *testing.T, path string, mockFS filesys.FileSystem) {
rfr := LocalPackageReader{PackagePath: path, MatchFilesGlob: []string{"*.json"}}
rfr.FileSystem.Set(mockFS)
nodes, err := rfr.Read() nodes, err := rfr.Read()
if !assert.NoError(t, err) { require.NoError(t, err)
return require.Len(t, nodes, 2)
}
if !assert.Len(t, nodes, 2) {
t.FailNow()
}
expected := []string{ expected := []string{
`{"a": "b", metadata: {annotations: {config.kubernetes.io/index: '0', config.kubernetes.io/path: 'a_test.json'}}} `{"a": "b", metadata: {annotations: {config.kubernetes.io/index: '0', config.kubernetes.io/path: 'a_test.json'}}}
`, `,
@@ -235,38 +253,41 @@ func TestLocalPackageReader_Read_JSON(t *testing.T) {
} }
for i := range nodes { for i := range nodes {
val, err := nodes[i].String() val, err := nodes[i].String()
if !assert.NoError(t, err) { require.NoError(t, err)
return require.Equal(t, expected[i], val)
}
if !assert.Equal(t, expected[i], val) {
return
}
}
} }
} }
func TestLocalPackageReader_Read_file(t *testing.T) { func TestLocalPackageReader_Read_file(t *testing.T) {
t.Run("on_disk", func(t *testing.T) {
s := SetupDirectories(t, filepath.Join("a", "b"), filepath.Join("a", "c")) s := SetupDirectories(t, filepath.Join("a", "b"), filepath.Join("a", "c"))
defer s.Clean() defer s.Clean()
s.WriteFile(t, filepath.Join("a_test.yaml"), readFileA) s.WriteFile(t, filepath.Join("a_test.yaml"), readFileA)
s.WriteFile(t, filepath.Join("b_test.yaml"), readFileB) s.WriteFile(t, filepath.Join("b_test.yaml"), readFileB)
paths := []struct { testLocalPackageReaderReadFile(t, "./", nil)
path string testLocalPackageReaderReadFile(t, s.Root, nil)
}{ })
{path: "./"},
{path: s.Root}, t.Run("on_mem", func(t *testing.T) {
} fs := filesys.MakeFsInMemory()
for _, p := range paths { require.NoError(t, fs.MkdirAll(filepath.Join("a", "b")))
rfr := LocalPackageReader{PackagePath: filepath.Join(p.path, "a_test.yaml")} require.NoError(t, fs.MkdirAll(filepath.Join("a", "c")))
nodes, err := rfr.Read() require.NoError(t, fs.WriteFile("a_test.yaml", readFileA))
if !assert.NoError(t, err) { require.NoError(t, fs.WriteFile("b_test.yaml", readFileB))
return
testLocalPackageReaderReadFile(t, "/", fs)
})
} }
if !assert.Len(t, nodes, 2) { func testLocalPackageReaderReadFile(t *testing.T, path string, mockFS filesys.FileSystem) {
return rfr := LocalPackageReader{
PackagePath: filepath.Join(path, "a_test.yaml"),
FileSystem: filesys.FileSystemOrOnDisk{FileSystem: mockFS},
} }
nodes, err := rfr.Read()
require.NoError(t, err)
require.Len(t, nodes, 2)
expected := []string{ expected := []string{
`a: b #first `a: b #first
metadata: metadata:
@@ -283,13 +304,8 @@ metadata:
} }
for i := range nodes { for i := range nodes {
val, err := nodes[i].String() val, err := nodes[i].String()
if !assert.NoError(t, err) { require.NoError(t, err)
return require.Equal(t, expected[i], val)
}
if !assert.Equal(t, expected[i], val) {
return
}
}
} }
} }