Adapt more LocalPackageReader tests

This commit is contained in:
Francesc Campoy
2021-07-15 18:21:42 -07:00
parent e8a4bf6edc
commit d37fa66ebc

View File

@@ -71,6 +71,7 @@ func TestLocalPackageReader_Read_pkg(t *testing.T) {
require.NoError(t, fs.WriteFile("b_test.yaml", readFileB)) require.NoError(t, fs.WriteFile("b_test.yaml", readFileB))
require.NoError(t, fs.WriteFile("c_test.yaml", readFileC)) require.NoError(t, fs.WriteFile("c_test.yaml", readFileC))
require.NoError(t, fs.WriteFile("d_test.yaml", readFileD)) require.NoError(t, fs.WriteFile("d_test.yaml", readFileD))
testLocalPackageReaderReadPkg(t, "/", fs) testLocalPackageReaderReadPkg(t, "/", fs)
}) })
} }
@@ -126,48 +127,61 @@ metadata:
} }
func TestLocalPackageReader_Read_pkgAndSkipFile(t *testing.T) { func TestLocalPackageReader_Read_pkgAndSkipFile(t *testing.T) {
s := SetupDirectories(t, filepath.Join("a", "b"), filepath.Join("a", "c")) t.Run("on_disk", func(t *testing.T) {
defer s.Clean() s := SetupDirectories(t, filepath.Join("a", "b"), filepath.Join("a", "c"))
s.WriteFile(t, filepath.Join("a_test.yaml"), readFileA) defer s.Clean()
s.WriteFile(t, filepath.Join("b_test.yaml"), readFileB) s.WriteFile(t, "a_test.yaml", readFileA)
s.WriteFile(t, filepath.Join("c_test.yaml"), readFileC) s.WriteFile(t, "b_test.yaml", readFileB)
s.WriteFile(t, filepath.Join("d_test.yaml"), readFileD) s.WriteFile(t, "c_test.yaml", readFileC)
s.WriteFile(t, "d_test.yaml", readFileD)
paths := []struct { testLocalPackageReaderReadPkgAndSkipFile(t, "./", nil)
path string testLocalPackageReaderReadPkgAndSkipFile(t, s.Root, nil)
}{ })
{path: "./"},
{path: s.Root}, t.Run("on_mem", func(t *testing.T) {
fs := filesys.MakeFsInMemory()
require.NoError(t, fs.MkdirAll(filepath.Join("a", "b")))
require.NoError(t, fs.MkdirAll(filepath.Join("a", "c")))
require.NoError(t, fs.WriteFile("a_test.yaml", readFileA))
require.NoError(t, fs.WriteFile("b_test.yaml", readFileB))
require.NoError(t, fs.WriteFile("c_test.yaml", readFileC))
require.NoError(t, fs.WriteFile("d_test.yaml", readFileD))
testLocalPackageReaderReadPkgAndSkipFile(t, "/", fs)
})
}
func testLocalPackageReaderReadPkgAndSkipFile(t *testing.T, path string, mockFS filesys.FileSystem) {
rfr := LocalPackageReader{
PackagePath: path,
FileSkipFunc: func(relPath string) bool {
return relPath == "d_test.yaml"
},
FileSystem: filesys.FileSystemOrOnDisk{FileSystem: mockFS},
}
nodes, err := rfr.Read()
if !assert.NoError(t, err) {
return
} }
for _, p := range paths {
rfr := LocalPackageReader{
PackagePath: p.path,
FileSkipFunc: func(relPath string) bool {
return relPath == "d_test.yaml"
},
}
nodes, err := rfr.Read()
if !assert.NoError(t, err) {
return
}
if !assert.Len(t, nodes, 4) { if !assert.Len(t, nodes, 4) {
return return
} }
expected := []string{ expected := []string{
`a: b #first `a: b #first
metadata: metadata:
annotations: annotations:
config.kubernetes.io/index: '0' config.kubernetes.io/index: '0'
config.kubernetes.io/path: 'a_test.yaml' config.kubernetes.io/path: 'a_test.yaml'
`, `,
`c: d # second `c: d # second
metadata: metadata:
annotations: annotations:
config.kubernetes.io/index: '1' config.kubernetes.io/index: '1'
config.kubernetes.io/path: 'a_test.yaml' config.kubernetes.io/path: 'a_test.yaml'
`, `,
`# second thing `# second thing
e: f e: f
g: g:
h: h:
@@ -178,118 +192,120 @@ metadata:
config.kubernetes.io/index: '0' config.kubernetes.io/index: '0'
config.kubernetes.io/path: 'b_test.yaml' config.kubernetes.io/path: 'b_test.yaml'
`, `,
`a: b #third `a: b #third
metadata: metadata:
annotations: annotations:
config.kubernetes.io/index: '0' config.kubernetes.io/index: '0'
config.kubernetes.io/path: 'c_test.yaml' config.kubernetes.io/path: 'c_test.yaml'
`, `,
} }
for i := range nodes { for i := range nodes {
val, err := nodes[i].String() val, err := nodes[i].String()
if !assert.NoError(t, err) { require.NoError(t, err)
return require.Equal(t, expected[i], val)
}
if !assert.Equal(t, expected[i], val) {
return
}
}
} }
} }
func TestLocalPackageReader_Read_JSON(t *testing.T) { func TestLocalPackageReader_Read_JSON(t *testing.T) {
s := SetupDirectories(t, filepath.Join("a", "b"), filepath.Join("a", "c")) aTestJSON := []byte(`{
defer s.Clean() "a": "b"
}`)
bTestJSON := []byte(`{
"e": "f",
"g": {
"h": ["i", "j"]
}
}`)
s.WriteFile(t, filepath.Join("a_test.json"), []byte(`{ t.Run("on_disk", func(t *testing.T) {
"a": "b" s := SetupDirectories(t, filepath.Join("a", "b"), filepath.Join("a", "c"))
}`)) defer s.Clean()
s.WriteFile(t, filepath.Join("b_test.json"), []byte(`{
"e": "f",
"g": {
"h": ["i", "j"]
}
}`))
paths := []struct { s.WriteFile(t, "a_test.json", aTestJSON)
path string s.WriteFile(t, "b_test.json", bTestJSON)
}{
{path: "./"}, testLocalPackageReaderReadJSON(t, "./", nil)
{path: s.Root}, testLocalPackageReaderReadJSON(t, s.Root, nil)
})
t.Run("on_mem", func(t *testing.T) {
fs := filesys.MakeFsInMemory()
require.NoError(t, fs.MkdirAll(filepath.Join("a", "b")))
require.NoError(t, fs.MkdirAll(filepath.Join("a", "c")))
require.NoError(t, fs.WriteFile("a_test.json", aTestJSON))
require.NoError(t, fs.WriteFile("b_test.json", bTestJSON))
testLocalPackageReaderReadJSON(t, "/", fs)
})
}
func testLocalPackageReaderReadJSON(t *testing.T, path string, mockFS filesys.FileSystem) {
rfr := LocalPackageReader{PackagePath: path, MatchFilesGlob: []string{"*.json"}}
rfr.FileSystem.Set(mockFS)
nodes, err := rfr.Read()
require.NoError(t, err)
require.Len(t, nodes, 2)
expected := []string{
`{"a": "b", metadata: {annotations: {config.kubernetes.io/index: '0', config.kubernetes.io/path: 'a_test.json'}}}
`,
`{"e": "f", "g": {"h": ["i", "j"]}, metadata: {annotations: {config.kubernetes.io/index: '0', config.kubernetes.io/path: 'b_test.json'}}}
`,
} }
for _, p := range paths { for i := range nodes {
rfr := LocalPackageReader{PackagePath: p.path, MatchFilesGlob: []string{"*.json"}} val, err := nodes[i].String()
nodes, err := rfr.Read() require.NoError(t, err)
if !assert.NoError(t, err) { require.Equal(t, expected[i], val)
return
}
if !assert.Len(t, nodes, 2) {
t.FailNow()
}
expected := []string{
`{"a": "b", metadata: {annotations: {config.kubernetes.io/index: '0', config.kubernetes.io/path: 'a_test.json'}}}
`,
`{"e": "f", "g": {"h": ["i", "j"]}, metadata: {annotations: {config.kubernetes.io/index: '0', config.kubernetes.io/path: 'b_test.json'}}}
`,
}
for i := range nodes {
val, err := nodes[i].String()
if !assert.NoError(t, err) {
return
}
if !assert.Equal(t, expected[i], val) {
return
}
}
} }
} }
func TestLocalPackageReader_Read_file(t *testing.T) { func TestLocalPackageReader_Read_file(t *testing.T) {
s := SetupDirectories(t, filepath.Join("a", "b"), filepath.Join("a", "c")) t.Run("on_disk", func(t *testing.T) {
defer s.Clean() s := SetupDirectories(t, filepath.Join("a", "b"), filepath.Join("a", "c"))
s.WriteFile(t, filepath.Join("a_test.yaml"), readFileA) defer s.Clean()
s.WriteFile(t, filepath.Join("b_test.yaml"), readFileB) s.WriteFile(t, filepath.Join("a_test.yaml"), readFileA)
s.WriteFile(t, filepath.Join("b_test.yaml"), readFileB)
paths := []struct { testLocalPackageReaderReadFile(t, "./", nil)
path string testLocalPackageReaderReadFile(t, s.Root, nil)
}{ })
{path: "./"},
{path: s.Root}, t.Run("on_mem", func(t *testing.T) {
fs := filesys.MakeFsInMemory()
require.NoError(t, fs.MkdirAll(filepath.Join("a", "b")))
require.NoError(t, fs.MkdirAll(filepath.Join("a", "c")))
require.NoError(t, fs.WriteFile("a_test.yaml", readFileA))
require.NoError(t, fs.WriteFile("b_test.yaml", readFileB))
testLocalPackageReaderReadFile(t, "/", fs)
})
}
func testLocalPackageReaderReadFile(t *testing.T, path string, mockFS filesys.FileSystem) {
rfr := LocalPackageReader{
PackagePath: filepath.Join(path, "a_test.yaml"),
FileSystem: filesys.FileSystemOrOnDisk{FileSystem: mockFS},
} }
for _, p := range paths { nodes, err := rfr.Read()
rfr := LocalPackageReader{PackagePath: filepath.Join(p.path, "a_test.yaml")} require.NoError(t, err)
nodes, err := rfr.Read() require.Len(t, nodes, 2)
if !assert.NoError(t, err) { expected := []string{
return `a: b #first
}
if !assert.Len(t, nodes, 2) {
return
}
expected := []string{
`a: b #first
metadata: metadata:
annotations: annotations:
config.kubernetes.io/index: '0' config.kubernetes.io/index: '0'
config.kubernetes.io/path: 'a_test.yaml' config.kubernetes.io/path: 'a_test.yaml'
`, `,
`c: d # second `c: d # second
metadata: metadata:
annotations: annotations:
config.kubernetes.io/index: '1' config.kubernetes.io/index: '1'
config.kubernetes.io/path: 'a_test.yaml' config.kubernetes.io/path: 'a_test.yaml'
`, `,
} }
for i := range nodes { for i := range nodes {
val, err := nodes[i].String() val, err := nodes[i].String()
if !assert.NoError(t, err) { require.NoError(t, err)
return require.Equal(t, expected[i], val)
}
if !assert.Equal(t, expected[i], val) {
return
}
}
} }
} }