Cleanup the replica plugin implementation.

pkg/replica/replica.go

@@ -1,13 +0,0 @@
-package replica
-
-// Replica specifies a modification to a replica config.
-// The number of replicas of a resource whose name matches will be set to count.
-// This struct is used by the ReplicaCountTransform, and is meant to supplement
-// the existing patch functionality with a simpler syntax for replica configuration.
-type Replica struct {
-	// The name of the resource to change the replica count
-	Name string `json:"name,omitempty" yaml:"name,omitempty"`
-
-	// The number of replicas required.
-	Count uint `json:"count,omitempty" yaml:"count,omitempty"`
-}

pkg/target/kusttarget_configplugin.go

@@ -7,7 +7,6 @@ import (
 	"github.com/pkg/errors"
 	"sigs.k8s.io/kustomize/pkg/image"
 	"sigs.k8s.io/kustomize/pkg/plugins"
-	"sigs.k8s.io/kustomize/pkg/replica"
 	"sigs.k8s.io/kustomize/pkg/transformers"
 	"sigs.k8s.io/kustomize/pkg/transformers/config"
 	"sigs.k8s.io/kustomize/pkg/types"
@@ -80,6 +79,7 @@ func (kt *KustTarget) configureBuiltinTransformers(
 		}
 		result = append(result, r...)
 	}
+
 	return result, nil
 }
 
@@ -239,12 +239,10 @@ func (kt *KustTarget) configureBuiltinReplicaCountTransformer(
 	tConfig *config.TransformerConfig) (
 	result []transformers.Transformer, err error) {
 	var c struct {
-		Replica    replica.Replica
-		FieldSpecs []config.FieldSpec
+		Replica types.Replica
 	}
 	for _, args := range kt.kustomization.Replicas {
 		c.Replica = args
-		c.FieldSpecs = tConfig.Replicas
 		p := builtin.NewReplicaCountTransformerPlugin()
 		err = kt.configureBuiltinPlugin(p, c, "replica")
 		if err != nil {

pkg/transformers/config/transformerconfig.go

@@ -35,7 +35,6 @@ type TransformerConfig struct {
 	NameReference     nbrSlice `json:"nameReference,omitempty" yaml:"nameReference,omitempty"`
 	VarReference      fsSlice  `json:"varReference,omitempty" yaml:"varReference,omitempty"`
 	Images            fsSlice  `json:"images,omitempty" yaml:"images,omitempty"`
-	Replicas          fsSlice  `json:"replicas,omitempty" yaml:"replicas,omitempty"`
 }
 
 // MakeEmptyConfig returns an empty TransformerConfig object
@@ -62,7 +61,6 @@ func (t *TransformerConfig) sortFields() {
 	sort.Sort(t.NameReference)
 	sort.Sort(t.VarReference)
 	sort.Sort(t.Images)
-	sort.Sort(t.Replicas)
 }
 
 // AddPrefixFieldSpec adds a FieldSpec to NamePrefix

pkg/types/kustomization.go

@@ -22,7 +22,6 @@ import (
 
 	"sigs.k8s.io/kustomize/pkg/gvk"
 	"sigs.k8s.io/kustomize/pkg/image"
-	"sigs.k8s.io/kustomize/pkg/replica"
 )
 
 const (
@@ -82,7 +81,7 @@ type Kustomization struct {
 
 	// Replicas is a list of {resourcename, count} that allows for simpler replica
 	// specification. This can also be done with a patch.
-	Replicas []replica.Replica `json:"replicas,omitempty" yaml:"replicas,omitempty"`
+	Replicas []Replica `json:"replicas,omitempty" yaml:"replicas,omitempty"`
 
 	// Vars allow things modified by kustomize to be injected into a
 	// container specification. A var is a name (e.g. FOO) associated
@@ -360,3 +359,15 @@ type PatchTarget struct {
 // stategic merge patch with the format
 // https://github.com/kubernetes/community/blob/master/contributors/devel/strategic-merge-patch.md
 type PatchStrategicMerge string
+
+// Replica specifies a modification to a replica config.
+// The number of replicas of a resource whose name matches will be set to count.
+// This struct is used by the ReplicaCountTransform, and is meant to supplement
+// the existing patch functionality with a simpler syntax for replica configuration.
+type Replica struct {
+	// The name of the resource to change the replica count
+	Name string `json:"name,omitempty" yaml:"name,omitempty"`
+
+	// The number of replicas required.
+	Count uint `json:"count,omitempty" yaml:"count,omitempty"`
+}