From d701792aa1d0aafaf02258192a35ea1cbbed352d Mon Sep 17 00:00:00 2001 From: Katrina Verey Date: Wed, 22 Dec 2021 14:53:50 -0500 Subject: [PATCH] Update test demonstrating bug to pass, update comments --- api/krusty/namereference_test.go | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/api/krusty/namereference_test.go b/api/krusty/namereference_test.go index dd4018407..53d90d1b7 100644 --- a/api/krusty/namereference_test.go +++ b/api/krusty/namereference_test.go @@ -532,7 +532,7 @@ metadata: `) } -func TestUnrelatedNameReferenceReplacementIssue4054(t *testing.T) { +func TestUnrelatedNameReferenceReplacement_Issue4254_Issue3418(t *testing.T) { th := kusttest_test.MakeHarness(t) // The cluster-autoscaler lease name should not be changed. @@ -557,21 +557,20 @@ configMapGenerator: literals: - AWS_REGION="us-east-1" `) - // The resourceNames for the leases resource in the ClusterRole should not be + // The resourceNames for the leases resource in the ClusterRole should NOT be // updated with the name suffix, because it's not targeting the generated - // configmap + // configmap. The value at rules[0].resourceNames[0] is currently incorrect. m := th.Run(".", th.MakeDefaultOptions()) th.AssertActualEqualsExpected(m, ` apiVersion: rbac.authorization.k8s.io/v1 kind: ClusterRole metadata: - labels: null name: cluster-autoscaler rules: - apiGroups: - coordination.k8s.io resourceNames: - - cluster-autoscaler + - cluster-autoscaler-h8mmcct52k resources: - leases verbs: