add commentaries, change command order on presubmit-check

This commit is contained in:
Kurnianto Trilaksono
2023-08-30 19:09:36 +07:00
parent 532abf77e7
commit d78fe665a7
2 changed files with 4 additions and 7 deletions

View File

@@ -108,13 +108,13 @@ verify-kustomize-repo: \
.PHONY: prow-presubmit-check .PHONY: prow-presubmit-check
prow-presubmit-check: \ prow-presubmit-check: \
install-tools \ install-tools \
workspace-sync \
generate-kustomize-builtin-plugins \
test-unit-kustomize-plugins \ test-unit-kustomize-plugins \
test-go-mod \ test-go-mod \
build-non-plugin-all \ build-non-plugin-all \
test-examples-kustomize-against-HEAD \ test-examples-kustomize-against-HEAD \
test-examples-kustomize-against-latest-release \ test-examples-kustomize-against-latest-release
workspace-sync \
generate-kustomize-builtin-plugins
.PHONY: license .PHONY: license
license: $(MYGOBIN)/addlicense license: $(MYGOBIN)/addlicense
@@ -183,10 +183,6 @@ test-examples-kustomize-against-HEAD: $(MYGOBIN)/kustomize $(MYGOBIN)/mdrip
test-examples-kustomize-against-latest-release: $(MYGOBIN)/mdrip test-examples-kustomize-against-latest-release: $(MYGOBIN)/mdrip
./hack/testExamplesAgainstKustomize.sh v5@$(LATEST_RELEASE) ./hack/testExamplesAgainstKustomize.sh v5@$(LATEST_RELEASE)
.PHONY: generate-kustomize-builtin-plugins
generate-kustomize-builtin-plugins:
$(MAKE) -f Makefile-plugin.mk
# Pushes dependencies in the go.work file back to go.mod files of each workspace module. # Pushes dependencies in the go.work file back to go.mod files of each workspace module.
.PHONY: workspace-sync .PHONY: workspace-sync
workspace sync: workspace sync:

View File

@@ -101,6 +101,7 @@ generate-kustomize-builtin-plugins: $(builtplugins)
cd ../../../; \ cd ../../../; \
make no-diff \ make no-diff \
# Check for diff, if diff is found, throw error code 1 (subject to change based on discussion)
.PHONY: no-diff .PHONY: no-diff
no-diff: $(builtplugins) no-diff: $(builtplugins)
for file in $(abspath $(builtinplugins)); do \ for file in $(abspath $(builtinplugins)); do \