From 9df8bbdc445d6025c9c31aba86727c54deb933d8 Mon Sep 17 00:00:00 2001 From: isarns Date: Sun, 5 Oct 2025 19:33:51 +0300 Subject: [PATCH 1/4] fix(cmd-edit-add-label): dubplicate key error --- kustomize/commands/edit/add/addmetadata.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kustomize/commands/edit/add/addmetadata.go b/kustomize/commands/edit/add/addmetadata.go index 25b1a5aac..71f1d96e1 100644 --- a/kustomize/commands/edit/add/addmetadata.go +++ b/kustomize/commands/edit/add/addmetadata.go @@ -183,7 +183,7 @@ func (o *addMetadataOptions) writeToLabels(m *types.Kustomization, kind kindOfAd } continue } - if err := o.writeToMap(lbl.Pairs, kind); err != nil { + if err := o.writeToMapEntry(lbl.Pairs, k, v, kind); err != nil { return err } m.Labels = append(m.Labels, lbl) From d427f61f84b474f9d49086a7037a58dcd2a453c1 Mon Sep 17 00:00:00 2001 From: isarns Date: Sun, 12 Oct 2025 12:08:34 +0300 Subject: [PATCH 2/4] test(cmd-edit-add-label): add multiple labels without selector test --- kustomize/commands/edit/add/addmetadata_test.go | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/kustomize/commands/edit/add/addmetadata_test.go b/kustomize/commands/edit/add/addmetadata_test.go index 9a52e133e..1671bff75 100644 --- a/kustomize/commands/edit/add/addmetadata_test.go +++ b/kustomize/commands/edit/add/addmetadata_test.go @@ -375,6 +375,19 @@ func TestAddLabelWithoutSelector(t *testing.T) { }, }, }, + { + name: "add multiple labels without selector", + baseLabels: []types.Label{}, + options: addMetadataOptions{ + labelsWithoutSelector: true, + metadata: map[string]string{"test1": "a", "test2": "b"}, + }, + expected: []types.Label{ + { + Pairs: map[string]string{"test1": "a", "test2": "b"}, + }, + }, + }, { name: "overwrite label with same settings", baseLabels: []types.Label{ From f71e4d7309c24a8b5ecdfdf8118a6be66508feed Mon Sep 17 00:00:00 2001 From: isarns Date: Sun, 12 Oct 2025 12:34:00 +0300 Subject: [PATCH 3/4] style(cmd-edit-add-label): lint multiple labels without selector test --- kustomize/commands/edit/add/addmetadata_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kustomize/commands/edit/add/addmetadata_test.go b/kustomize/commands/edit/add/addmetadata_test.go index 1671bff75..89b797bdb 100644 --- a/kustomize/commands/edit/add/addmetadata_test.go +++ b/kustomize/commands/edit/add/addmetadata_test.go @@ -376,7 +376,7 @@ func TestAddLabelWithoutSelector(t *testing.T) { }, }, { - name: "add multiple labels without selector", + name: "add multiple labels without selector", baseLabels: []types.Label{}, options: addMetadataOptions{ labelsWithoutSelector: true, From 4d37afef6f1cc9f64344eec43702d0c88b8c6bb4 Mon Sep 17 00:00:00 2001 From: isarns Date: Sun, 12 Oct 2025 18:04:33 +0300 Subject: [PATCH 4/4] style(cmd-edit-add-label): lint multiple labels without selector test --- kustomize/commands/edit/add/addmetadata_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kustomize/commands/edit/add/addmetadata_test.go b/kustomize/commands/edit/add/addmetadata_test.go index 89b797bdb..1671bff75 100644 --- a/kustomize/commands/edit/add/addmetadata_test.go +++ b/kustomize/commands/edit/add/addmetadata_test.go @@ -376,7 +376,7 @@ func TestAddLabelWithoutSelector(t *testing.T) { }, }, { - name: "add multiple labels without selector", + name: "add multiple labels without selector", baseLabels: []types.Label{}, options: addMetadataOptions{ labelsWithoutSelector: true,