From e5d730e1fea6ce52d279e4fc3ddee5477df85cc7 Mon Sep 17 00:00:00 2001 From: Jingfang Liu Date: Tue, 9 Apr 2019 15:39:56 -0700 Subject: [PATCH] address comments --- pkg/plugins/transformers.go | 5 +---- pkg/target/generatorplugin_test.go | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/pkg/plugins/transformers.go b/pkg/plugins/transformers.go index 920446dd9..661ccc2b7 100644 --- a/pkg/plugins/transformers.go +++ b/pkg/plugins/transformers.go @@ -88,10 +88,7 @@ func isExecAvailable(name string) bool { if os.IsNotExist(err) { return false } - if f.Mode()&0111 != 0000 { - return true - } - return false + return f.Mode()&0111 != 0000 } func loadAndConfigurePlugin( diff --git a/pkg/target/generatorplugin_test.go b/pkg/target/generatorplugin_test.go index d64d4ff02..2da781936 100644 --- a/pkg/target/generatorplugin_test.go +++ b/pkg/target/generatorplugin_test.go @@ -130,7 +130,7 @@ type: Opaque func TestConfigMapGenerator(t *testing.T) { tc := NewTestEnvController(t).Set() - //defer tc.Reset() + defer tc.Reset() tc.BuildExecPlugin( "someteam.example.com", "v1", "ConfigMapGenerator")