fix: return error instead of log.Fatalf() (#5625)

* fix: return error instead of log.Fatalf()

* chore: add meaningful message to error output

* chore: add meaningful message to fatal function
This commit is contained in:
Yusuke Abe
2024-04-18 19:56:51 +09:00
committed by GitHub
parent 82ee768212
commit ed09399cd1
11 changed files with 412 additions and 190 deletions

View File

@@ -12,21 +12,45 @@ import (
func TestIdSet_Empty(t *testing.T) {
s := MakeIdSet([]*Resource{})
td, err := createTestDeployment()
if err != nil {
t.Fatalf("Failed to create test deployment: %v", err)
}
tc, err := createTestConfigMap()
if err != nil {
t.Fatalf("Failed to create test config: %v", err)
}
assert.Equal(t, 0, s.Size())
assert.False(t, s.Contains(testDeployment.CurId()))
assert.False(t, s.Contains(testConfigMap.CurId()))
assert.False(t, s.Contains(td.CurId()))
assert.False(t, s.Contains(tc.CurId()))
}
func TestIdSet_One(t *testing.T) {
s := MakeIdSet([]*Resource{testDeployment})
td, err := createTestDeployment()
if err != nil {
t.Fatalf("failed to create test deployment: %v", err)
}
tc, err := createTestConfigMap()
if err != nil {
t.Fatalf("failed to create test config: %v", err)
}
s := MakeIdSet([]*Resource{td})
assert.Equal(t, 1, s.Size())
assert.True(t, s.Contains(testDeployment.CurId()))
assert.False(t, s.Contains(testConfigMap.CurId()))
assert.True(t, s.Contains(td.CurId()))
assert.False(t, s.Contains(tc.CurId()))
}
func TestIdSet_Two(t *testing.T) {
s := MakeIdSet([]*Resource{testDeployment, testConfigMap})
td, err := createTestDeployment()
if err != nil {
t.Fatalf("failed to create test Deployment: %v", err)
}
tc, err := createTestConfigMap()
if err != nil {
t.Fatalf("failed to create test Config: %v", err)
}
s := MakeIdSet([]*Resource{td, tc})
assert.Equal(t, 2, s.Size())
assert.True(t, s.Contains(testDeployment.CurId()))
assert.True(t, s.Contains(testConfigMap.CurId()))
assert.True(t, s.Contains(td.CurId()))
assert.True(t, s.Contains(tc.CurId()))
}