kubernetes-sigs/kustomize
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/kustomize.git synced 2026-05-17 18:25:26 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Add deprecation warning message to commonLabels (#5464)

Browse Source 
* Add commonLabels deprecation warning message

* Add test

* Add warningToRunEditFix message
This commit is contained in:
Nick
2023-11-30 08:41:43 -08:00
committed by GitHub
parent 0b4974eb1c
commit f23d45fcb4
2 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
api/types/kustomization.go
View File

@@ -188,6 +188,7 @@ const (
deprecatedPatchesJson6902Message = "# Warning: 'patchesJson6902' is deprecated. Please use 'patches' instead." + " " + deprecatedWarningToRunEditFix deprecatedPatchesJson6902Message = "# Warning: 'patchesJson6902' is deprecated. Please use 'patches' instead." + " " + deprecatedWarningToRunEditFix
deprecatedPatchesStrategicMergeMessage = "# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead." + " " + deprecatedWarningToRunEditFix deprecatedPatchesStrategicMergeMessage = "# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead." + " " + deprecatedWarningToRunEditFix
deprecatedVarsMessage = "# Warning: 'vars' is deprecated. Please use 'replacements' instead." + " " + deprecatedWarningToRunEditFixExperimential deprecatedVarsMessage = "# Warning: 'vars' is deprecated. Please use 'replacements' instead." + " " + deprecatedWarningToRunEditFixExperimential
deprecatedCommonLabelsWarningMessage = "# Warning: 'commonLabels' is deprecated. Please use 'labels' instead." + " " + deprecatedWarningToRunEditFix
) )
// CheckDeprecatedFields check deprecated field is used or not. // CheckDeprecatedFields check deprecated field is used or not.
@@ -196,6 +197,9 @@ func (k *Kustomization) CheckDeprecatedFields() *[]string {
if k.Bases != nil { if k.Bases != nil {
warningMessages = append(warningMessages, deprecatedBaseWarningMessage) warningMessages = append(warningMessages, deprecatedBaseWarningMessage)
} }
if k.CommonLabels != nil {
warningMessages = append(warningMessages, deprecatedCommonLabelsWarningMessage)
}
if k.ImageTags != nil { if k.ImageTags != nil {
warningMessages = append(warningMessages, deprecatedImageTagsWarningMessage) warningMessages = append(warningMessages, deprecatedImageTagsWarningMessage)
} }

9
api/types/kustomization_test.go
View File

@@ -29,6 +29,13 @@ func TestKustomization_CheckDeprecatedFields(t *testing.T) {
}, },
want: &[]string{deprecatedBaseWarningMessage}, want: &[]string{deprecatedBaseWarningMessage},
}, },
{
name: "using_CommonLabels",
k: Kustomization{
CommonLabels: map[string]string{},
},
want: &[]string{deprecatedCommonLabelsWarningMessage},
},
{ {
name: "using_ImageTags", name: "using_ImageTags",
k: Kustomization{ k: Kustomization{
@@ -61,6 +68,7 @@ func TestKustomization_CheckDeprecatedFields(t *testing.T) {
name: "usingAll", name: "usingAll",
k: Kustomization{ k: Kustomization{
Bases: []string{"base"}, Bases: []string{"base"},
CommonLabels: map[string]string{},
ImageTags: []Image{}, ImageTags: []Image{},
PatchesJson6902: []Patch{}, PatchesJson6902: []Patch{},
PatchesStrategicMerge: []PatchStrategicMerge{}, PatchesStrategicMerge: []PatchStrategicMerge{},
@@ -68,6 +76,7 @@ func TestKustomization_CheckDeprecatedFields(t *testing.T) {
}, },
want: &[]string{ want: &[]string{
deprecatedBaseWarningMessage, deprecatedBaseWarningMessage,
deprecatedCommonLabelsWarningMessage,
deprecatedImageTagsWarningMessage, deprecatedImageTagsWarningMessage,
deprecatedPatchesJson6902Message, deprecatedPatchesJson6902Message,
deprecatedPatchesStrategicMergeMessage, deprecatedPatchesStrategicMergeMessage,