From f23f26aa05bd8cb5a4a0272abcd51ff8ab9b3700 Mon Sep 17 00:00:00 2001 From: Jeff Regan Date: Sat, 16 Jan 2021 20:24:39 -0800 Subject: [PATCH] Update factory_test.go --- api/resource/factory_test.go | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/api/resource/factory_test.go b/api/resource/factory_test.go index af82c5d8f..cb48a4be9 100644 --- a/api/resource/factory_test.go +++ b/api/resource/factory_test.go @@ -343,15 +343,13 @@ kind: List name: "listWithAnchorReference", input: []types.PatchStrategicMerge{patchList2}, expectedOut: []*Resource{testDeploymentA, testDeploymentB}, - // See https://github.com/kubernetes-sigs/kustomize/issues/3271 - // This test should not have an error, but does when kyaml is used. + // TODO(#3271) This shouldn't have an error, but does when kyaml is used. // The error using kyaml is: // json: unsupported type: map[interface {}]interface {} - // probably arising from too many conversions between + // maybe arising from too many conversions between // yaml, json, Resource, RNode, Unstructured etc. - // These conversions can be removed after closing - // https://github.com/kubernetes-sigs/kustomize/issues/2506 - // TODO(#3304): DECISION - still a bug. + // These conversions go away after closing #3506 + // TODO(#3304): DECISION - open bug with anchor references. expectedErr: konfig.FlagEnableKyamlDefaultValue, }, {