kubernetes-sigs/kustomize
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/kustomize.git synced 2026-06-14 10:30:59 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Add varcheck to presubmit.

Browse Source
This commit is contained in:
Jeffrey Regan
2018-08-23 10:17:37 -07:00
parent 22c99aa535
commit f931e15653
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
.travis.yml
View File

@@ -8,6 +8,7 @@ go:
before_install: before_install:
- source ./bin/consider-early-travis-exit.sh - source ./bin/consider-early-travis-exit.sh
- sudo apt-get install tree - sudo apt-get install tree
- go get -u github.com/opennota/check/cmd/varcheck
- go get -u github.com/golang/lint/golint - go get -u github.com/golang/lint/golint
- go get -u golang.org/x/tools/cmd/goimports - go get -u golang.org/x/tools/cmd/goimports
- go get -u github.com/onsi/ginkgo/ginkgo - go get -u github.com/onsi/ginkgo/ginkgo

7
bin/pre-commit.sh
View File

@@ -41,14 +41,14 @@ function testGoLint {
diff -u <(echo -n) <(go_dirs | xargs -0 golint --min_confidence 0.85 ) diff -u <(echo -n) <(go_dirs | xargs -0 golint --min_confidence 0.85 )
} }
# Not using the 'goimports' check because it reports hyphens in imported
# package names as errors, and we vendor in packages that have
# hyphens in their names.
function testGoMetalinter { function testGoMetalinter {
diff -u <(echo -n) <(go_dirs | xargs -0 gometalinter.v2 --disable-all --deadline 5m \ diff -u <(echo -n) <(go_dirs | xargs -0 gometalinter.v2 --disable-all --deadline 5m \
--enable=misspell \ --enable=misspell \
--enable=structcheck \ --enable=structcheck \
--enable=deadcode \ --enable=deadcode \
# Disabling 'goimports' because it reports hyphens in imported package \
# names as errors, and we have to vendor them in regardless. \
# --enable=goimports \
--enable=varcheck \ --enable=varcheck \
--enable=goconst \ --enable=goconst \
--enable=unparam \ --enable=unparam \
@@ -60,7 +60,6 @@ function testGoMetalinter {
--dupl-threshold=400 --enable=dupl) --dupl-threshold=400 --enable=dupl)
} }
function testGoVet { function testGoVet {
go vet -all ./... go vet -all ./...
} }