Gongpu Zhu
b407675fc0
Enable logging in runfn
2020-08-11 18:02:22 -07:00
Gongpu Zhu
e5a78710aa
Add callback to kio pipeline execution
2020-08-10 17:14:56 -07:00
jregan
2b328eeb36
Remove unused IsFieldEmpty, add more godoc.
2020-08-10 12:37:13 -07:00
jregan
0e13eadd7a
IsFieldEmpty renamed to MapNode.IsNilOrEmpty
2020-08-10 10:24:02 -07:00
jregan
c469e80cad
Add RNode.IsNilOrEmpty and test.
2020-08-09 12:37:12 -07:00
jregan
5559601ecb
Add tests for IsTaggedNull, IsYNodeEmptySeq and IsYNodeEmptyMap.
2020-08-09 12:29:35 -07:00
jregan
01b34c8ea0
Add tests for IsNil
2020-08-09 11:55:28 -07:00
jregan
31c59bd7f2
Drop all calls to IsEmpty.
2020-08-09 10:47:06 -07:00
jregan
c94f164e66
Use new
2020-08-07 15:57:00 -07:00
jregan
cf5b26db8a
Kyaml api cleanup
2020-08-07 12:44:31 -07:00
Jeff Regan
f211841035
Merge pull request #2811 from monopole/moveToNewConstants
...
Move to new constants.
2020-08-07 12:32:41 -07:00
Jeff Regan
686e97f2fe
Merge pull request #2810 from Shell32-Natsu/fieldspec-empty
...
fix panic when fieldspec refers an empty value
2020-08-07 11:50:14 -07:00
Donny Xia
669ae59982
code review
2020-08-07 11:12:40 -07:00
Donny Xia
a2693d0249
fix panic when fieldspec refers an empty value
2020-08-07 10:47:25 -07:00
Donny Xia
d59d0401f4
Keep empty map in kustomize output
2020-08-06 13:21:38 -07:00
Jeff Regan
e605391895
Merge pull request #2800 from Shell32-Natsu/ignore-tempdir-env
...
Ignore TMPDIR when run container
2020-08-05 16:41:22 -07:00
Donny Xia
8cd7c13fad
fix linter issue
2020-08-05 12:04:46 -07:00
Donny Xia
8cdc97a0dd
code review
2020-08-05 11:56:19 -07:00
Jeff Regan
5e89565930
Merge pull request #2792 from mortent/FixSetterWalk
...
Fix issue where the schema was not propagated correctly when walking yaml doc
2020-08-05 08:38:51 -07:00
Donny Xia
2f7241f4c3
code review
2020-08-04 17:11:18 -07:00
Kubernetes Prow Robot
436c688bd0
Merge pull request #2797 from phanimarupaka/SuffixSubstInFix
...
Infix/Suffix subst creation for fix
2020-08-04 14:11:40 -07:00
Donny Xia
c99bc47c8d
fix test on macos
2020-08-04 11:01:06 -07:00
Donny Xia
60422c8090
Ignore TMPDIR when run container
2020-08-04 10:48:59 -07:00
Phani Teja Marupaka
974e3847dd
Infix/Suffix subst creation for fix
2020-08-03 14:46:29 -07:00
Phani Teja Marupaka
4e74947731
Update setter comments during 3-way merge
2020-08-03 11:55:34 -07:00
Morten Torkildsen
5c433ead5e
Use k8s schema to determine formatting if no type on setter
2020-07-31 13:44:47 -07:00
Morten Torkildsen
feeaa994b7
Fix issue where the schema was not propagated correctly when walking yaml doc
2020-07-31 10:56:00 -07:00
Kubernetes Prow Robot
17f935452f
Merge pull request #2778 from phanimarupaka/FixSetters
...
Fix command: Migrate v1 Setters to latest
2020-07-30 13:09:07 -07:00
Phani Teja Marupaka
6faff2d031
Fix V1 Setters and migrate to latest
2020-07-30 12:51:57 -07:00
Kubernetes Prow Robot
18a86bd7d6
Merge pull request #2784 from mortent/HandleIncorrectTypes
...
Handle some incorrect type values like 'int' and 'bool' in setters
2020-07-30 12:19:06 -07:00
Morten Torkildsen
6f63cf7238
SetterCreator accepts schema as a string rather than file path and validates schema
2020-07-28 22:53:21 -07:00
Morten Torkildsen
de0c8dedc4
Handle some incorrect type values like 'int' and 'bool' in setters
2020-07-28 13:49:07 -07:00
Donny Xia
65fd7c3e6e
Add seq tag in kyaml
2020-07-24 11:17:31 -07:00
phani
d9fe98a289
Revert "List and set setters in folders recursively"
2020-07-22 13:51:42 -07:00
Jeff Regan
8b9829f222
Merge pull request #2738 from phanimarupaka/ListSettersRecursively
...
List and set setters in folders recursively
2020-07-22 13:14:13 -07:00
Kubernetes Prow Robot
6fccb7fd48
Merge pull request #2743 from phanimarupaka/FixV1Setters
...
Fix V1 setters
2020-07-22 10:52:06 -07:00
Phani Teja Marupaka
eb7beba8ad
Fix V1 setters
2020-07-22 10:17:10 -07:00
Jeff Regan
1e3bc51645
Merge pull request #2748 from monopole/tweakSequenceTreatment
...
Tweak sequence treatment in fieldspecs
2020-07-22 10:01:21 -07:00
Jeff Regan
a70c6b3496
Tweak sequence treatment in fieldspecs
2020-07-22 09:23:47 -07:00
Phani Teja Marupaka
108195185f
List and set setters in folders recursively
2020-07-20 00:50:04 -07:00
Phani Teja Marupaka
e894756003
Error for null files while reading
2020-07-15 16:05:52 -07:00
Jeff Regan
ec9ae3d7b0
Merge pull request #2713 from Shell32-Natsu/empty-list-in-patch
...
Keep empty array in output
2020-07-14 13:50:37 -07:00
Donny Xia
3a828941fa
Improve tests
2020-07-14 11:38:29 -07:00
Donny Xia
23bd4390d3
code review
2020-07-13 16:40:34 -07:00
Donny Xia
c6b6dec91f
Add tests for IsEmpty and IsMissingorNull
2020-07-13 14:15:55 -07:00
Kubernetes Prow Robot
9cf4367db7
Merge pull request #2709 from aodinokov/fixmount
...
Fixed incorrect docker mount arguments generation
2020-07-13 12:35:22 -07:00
Alexey Odinokov
ba3e09849a
Made mountString params more similar to docker params
...
see [1]
kept support for the previous field names similarly to
docker behavior.
[1]
https://docs.docker.com/storage/bind-mounts/#use-a-read-only-bind-mount
2020-07-13 17:21:37 +00:00
Donny Xia
236ae29e9a
Don't consider empty array as "empty"
2020-07-13 10:03:24 -07:00
Morten Torkildsen
c419c1efc3
Allow setters/substitutions with . in the name
2020-07-11 10:41:27 -07:00
Alexey Odinokov
63f9f79fc0
Fixed incorrect docker mount arguments generation
...
The previous implementation combined --mount and -v notation
of argument [1] adding :ro to make the read-only mount point.
E.g. the command [2] called docker with the following
params: [3]. As a result instead of the read-only
folder /tmp/source, the read-write folder /tmp/source/:ro/'
is created.
This PR:
1. substitutes ':ro' with correct ',readonly'.
2. changes 'src=' and 'dst=' with 'source=' and 'target=' as
it is stated in the documentation [1]
3. introduces the ability to EXPLICITLY create a mountpoint
with read-write access. To do so it's necessary to add
',rw=true' to the --mount argument
4. corrects UTs adds some additional coverage for added
functionality
[1]
https://docs.docker.com/storage/bind-mounts/#use-a-read-only-bind-mount
[2]
kustomize fn run ./d --mount type=bind,src=$(pwd)/test/,dst=/tmp/source/
[3]
--mount type=bind,src=/home/ubuntu/kpt-functions-catalog/functions/ts/test/,dst=/tmp/source/:ro
2020-07-11 17:03:44 +00:00
