jregan
103c1b3a4f
Put goplugins behind flag.
2019-03-17 13:39:48 -07:00
Jeffrey Regan
ccc4461827
Fix nil ptr bug
2019-02-07 10:11:45 -08:00
jregan
35daae1715
Delete some dead code and fix nits.
2019-01-29 14:13:46 -08:00
Jeffrey Regan
8c2bff2c91
Disallow cloned kustomization from using a local base outside the clone dir.
2019-01-29 10:31:52 -08:00
Jeffrey Regan
31691f0330
Replace all repo uri strings with git.RepoSpec.
2019-01-28 15:31:42 -08:00
jregan
ad400cd13d
Introduce RepoSpec.
...
This PR closes a TODO in the fileLoader type to
replace the string representing a git repo url
with a struct called holding validated fields.
New struct is called RepoSpec.
It holds what we need in coming PRs for remote
repo base containment checks, and will also allow
the overlay cycle prevention code to take into
account different host schemes or branches.
The struct is in a new file called repospec.go.
The new file is mostly just a code move of url
parsing code that was in cloner.go. Git "blame"
history preserved through the move.
No change in execution (see final commit by itself).
2019-01-27 07:47:52 -08:00
jregan
1d9a20b391
Move git code to its own pkg.
2019-01-26 17:06:48 -08:00
Jeffrey Regan
fd3cd47562
Fix copyright, add TODOs
2019-01-25 16:05:40 -08:00
jregan
dcb5682594
Add more coverage for loader and strengthen type safety.
2019-01-25 14:43:28 -08:00
Jeff Regan
4d77c9f940
Merge pull request #721 from Liujingfang1/filename
...
support different filenames for kustomization file
2019-01-25 14:34:06 -08:00
Jeffrey Regan
c21dfefbdf
Cover CleanedAbs
2019-01-25 12:21:03 -08:00
Jingfang Liu
f7a59178a8
support different filenames for kustomization file
2019-01-24 15:08:28 -08:00
Jeffrey Regan
2e6bdd4041
Add more loader tests.
2019-01-22 14:08:28 -08:00
Kubernetes Prow Robot
0be9815d27
Merge pull request #690 from fassmus/CloneBaseFromPrivateGit
...
Remove git:: prefix for all git URLs not only GitLab
2019-01-16 13:40:20 -08:00
Jeffrey Regan
14af70d148
Restrict loading to root or below.
2019-01-16 11:13:37 -08:00
Florian Assmus
176ad74a1c
Add unit test for additional git url patterns
2019-01-15 22:53:36 +01:00
Jeffrey Regan
ea1dd08a8c
Small cleanups, no change in exec.
2019-01-14 15:35:03 -08:00
Florian Assmus
94be867a54
Remove git:: prefix for all urls not only GitLab
2019-01-11 13:41:29 +01:00
Jingfang Liu
20e37eaf65
improve url parsing function in gitcloner
2018-12-14 15:26:39 -08:00
Kubernetes Prow Robot
441f45e1cc
Merge pull request #626 from monopole/fix616
...
Fix incorrect use of filepath.Separator
2018-12-13 16:45:27 -08:00
Jeffrey Regan
48e8a3aec3
Fix incorrect use of filepath.Separator
2018-12-13 16:38:39 -08:00
Jeffrey Regan
352ec69556
Allow directory substrings in cycle check.
2018-12-13 15:57:49 -08:00
Jingfang Liu
259cecd4b8
add handling function for remote url hostname
2018-12-11 14:33:10 -08:00
Jeffrey Regan
108b3e497b
Require relocatable kustomizations and fix some nits.
2018-12-07 10:46:35 -08:00
jregan
a40c2502de
Delete hashicorp cloner.
2018-11-22 16:58:59 -08:00
jregan
7c1277f24c
Turn off hashicorp cloner.
2018-11-22 16:48:24 -08:00
jregan
02d2d38c21
Deal with branch spec in simpleGitCloner.
2018-11-22 16:42:28 -08:00
jregan
6cddc25f0e
Remove stray comment.
2018-11-22 10:39:18 -08:00
jregan
d9ba209543
Introduce simple git cloner.
2018-11-22 10:24:35 -08:00
jregan
4f9d00c021
Enforce relocatabile kustomizations.
2018-11-22 09:07:05 -08:00
jregan
910eb322e0
Rename gitloader to gitcloner.
2018-11-22 08:41:59 -08:00
jregan
4daa655516
Add test coverage to gitloader.
2018-11-22 08:27:25 -08:00
jregan
793577d044
Consult history in fileloader.
...
Fixes #366
To reproduce #366 , add
```
bases:
- .
```
to `examples/helloWorld/kustomization.yaml`, attempt to build it, and enjoy the stack overflow.
This PR fixes this by adding history to file loaders,
allowing one to avoid cycles in overlay->base
relationships. To make entry points clearer, this PR
exposes only two public ways to make a fresh
(no-history) loader
* rooted at `/`
* rooted at the process's current working directory.
When making a new loader from an existing loader,
retaining history along an overlay trace, the only
allowed use is to go deeper into a file hierarchy, or
go up and over to a never before visited sibling. This
fix can probably be defeated by devious symbolic links.
2018-10-29 11:10:21 -07:00
jregan
885c1952a4
Improve test coverage.
2018-10-28 13:52:25 -07:00
Jeffrey Regan
c9887e8c15
WIP residPackage
2018-10-05 12:58:48 -07:00
jregan
6d935b6a4a
Fix some Go nits.
2018-09-28 18:08:36 -07:00
Luke Swithenbank
d78e77fb92
fix remote build's for subdirectories
2018-09-13 09:56:04 +10:00
Jingfang Liu
64fdb8d760
change github.com/kubernetes-sigs to sigs.k8s.io ( #343 )
...
* change github.com/kubernetes-sigs to sigs.k8s.io
* change go_import_path in .travis.yml
2018-09-12 12:41:38 -07:00
gitirabassi
a76cb0b008
force using the git protocol to downlaod every kind of repo non just from github
2018-08-30 11:02:03 +02:00
Ethan Mosbaugh
e113944027
fix loader loader when run from gopath
2018-08-23 14:54:58 -07:00
Jingfang Liu
6da691f874
cleanup after handling remote bases
2018-08-22 13:22:45 -07:00
Jingfang Liu
72b1a4bc5c
combine fileLoader.New and NewLoader into one function: NewLoader
2018-08-15 11:04:31 -07:00
Jingfang Liu
f018370628
Add kustomize build {repoUrl}
2018-08-14 16:10:51 -07:00
Jingfang Liu
1b7171ac9e
Add glob support in edit add resource
2018-08-01 11:43:28 -07:00
Jeffrey Regan
9e5374e725
Combine loaderImpl and fileLoader.
2018-07-25 17:23:04 -07:00
Jeffrey Regan
a78aa22399
Drop useless or duplicative code.
2018-07-24 13:25:26 -07:00
Jeffrey Regan
564b0d6827
Fix cluster of silly Go nits.
2018-07-18 17:45:17 -07:00
Jingfang Liu
6392e6629f
Add glob support
2018-06-27 10:54:12 -07:00
Oleg Atamanenko
c994130005
Fix go lint error and add golint checks to a pre-commit hook
2018-06-09 23:05:26 -04:00
Jeffrey Regan
2e0e43cd76
Improve package doc.
2018-06-06 14:15:50 -07:00
