Katrina Verey
64d2366e87
Naming changes from rebase
2023-01-09 13:15:26 -05:00
Katrina Verey
06999462e7
Make Github less special
2023-01-09 13:13:28 -05:00
Katrina Verey
2591303430
Add test case from github docs
2023-01-09 13:13:28 -05:00
Katrina Verey
150134758f
Show change vs master on accepted but invalid ssh-like urls
2023-01-09 13:13:28 -05:00
Katrina Verey
43d96ba91b
Address feedback on correctness of SCP/username validations
2023-01-09 13:13:28 -05:00
Katrina Verey
4821259f01
Stop handling mysterious gh: prefix in remote URLs
2023-01-09 13:13:27 -05:00
Katrina Verey
7e6cc7aafb
Review feedback
2023-01-09 13:13:27 -05:00
Katrina Verey
dc05fa153f
Additional repospec refactoring
2023-01-09 13:13:27 -05:00
Anna Song
fbb94584dc
Refactor parseHostSpec
...
Fix ssh parsing in issue 4847
2023-01-09 13:13:25 -05:00
Kishore Jagannath
772fafa892
Rename Orgrepo and Path ( #4922 )
...
* initial changes to rename OrgRepo to RepoPath
* changes to rename Path to KustRootPath
* addressed review comments
* addressed review comments
* docs: Add documentation for namespace transformer
Add a short description of the namespace transformer and example
usage to examples/transformerconfigs/README.md.
References: #629
Signed-off-by: Lars Kellogg-Stedman <lars@oddbit.com >
* Localize patchesJson6902, patchesStrategicMerge, replacements (#4904 )
* Localize patchesJson6902, patchesStrategicMerge, replacements
* Address code review feedback
* Improve readability
* Remove deprecation warning check
* Load legacy kustomization fields for `localize` (#4918 )
* Load legacy kustomization
* Expose loadKustFile in kusttarget
* remove FixKustomizationPreUnmarshalling
* remove deprecated cfg and fn commands (#4930 )
* remove deprecated cfg and fn commands
* fix lint error
* run gofmt
* Localize PatchTransformer, PatchJson6902Transformer (#4920 )
* Localize patches, patchesJson6902 custom transformers
* Improve readability
* Localize fields: openapi, configurations, crds (#4907 )
* Localize openapi, configurations, crds
* Add integration test
* Move krusty test
* Address code review feedback
* Implement locRootPath (#4909 )
* Implement locRootPath, and include userinfo, port in locFilePath
* Strip userinfo, port
* Improve readability
* Localize legacy fields
* Localize resources (#4912 )
* Localize resources
* Improve readability
* Add integration tests
* Group test helper functions
* Remove Functionality that Pulls Env Variables from Empty Keys
* Update api/kv/kv.go
Co-authored-by: Katrina Verey <kn.verey@gmail.com >
* refactor Unmarshal Kustomization struct code
* improve error messages
* Run go mod tidy on all modules before update
* Update sigs.k8s.io/yaml to 1.3.0
* fixed test failure because of latest commits
Signed-off-by: Lars Kellogg-Stedman <lars@oddbit.com >
Co-authored-by: Lars Kellogg-Stedman <lars@oddbit.com >
Co-authored-by: Anna Song <annasong@google.com >
Co-authored-by: yugo kobayashi <kobdotsh@gmail.com >
Co-authored-by: Natasha Sarkar <natashasarkar@google.com >
Co-authored-by: Cailyn Edwards <cailyn.edwards@shopify.com >
Co-authored-by: Cailyn <cailyn.s.e@gmail.com >
Co-authored-by: Katrina Verey <kn.verey@gmail.com >
Co-authored-by: Katrina Verey <katrina.verey@shopify.com >
2023-01-09 08:45:29 -08:00
Kubernetes Prow Robot
9bc75c16d9
Merge pull request #4960 from KnVerey/update-sigs-yaml
...
Update sigs.k8s.io/yaml to v1.3.0
2023-01-06 13:37:27 -08:00
Katrina Verey
5be179305a
Update sigs.k8s.io/yaml to 1.3.0
2023-01-06 16:23:17 -05:00
Kubernetes Prow Robot
c6ca3ff799
Merge pull request #4929 from koba1t/refactor/cleanup_Unmarshal_kustomization
...
Error on duplicate fields in Kustomization
2023-01-06 10:37:59 -08:00
koba1t
6489e35b7c
improve error messages
2023-01-07 03:30:16 +09:00
Kubernetes Prow Robot
1308d905fa
Merge pull request #4957 from cailynse/update-configMapGenerator-4731
...
Remove Functionality that Pulls Env Variables from Empty Keys
2023-01-05 13:19:58 -08:00
Cailyn
6c79645fb0
Update api/kv/kv.go
...
Co-authored-by: Katrina Verey <kn.verey@gmail.com >
2023-01-05 14:39:02 -05:00
Cailyn Edwards
b7746d09e4
Remove Functionality that Pulls Env Variables from Empty Keys
2023-01-05 12:54:48 -05:00
Anna Song
06da3b96a2
Localize resources ( #4912 )
...
* Localize resources
* Improve readability
* Add integration tests
* Group test helper functions
2023-01-05 08:47:59 -08:00
Anna Song
3022dd2931
Localize legacy fields
2022-12-22 17:21:16 -05:00
Anna Song
aec35009ed
Implement locRootPath ( #4909 )
...
* Implement locRootPath, and include userinfo, port in locFilePath
* Strip userinfo, port
* Improve readability
2022-12-22 12:15:26 -08:00
Anna Song
de6162625f
Localize fields: openapi, configurations, crds ( #4907 )
...
* Localize openapi, configurations, crds
* Add integration test
* Move krusty test
* Address code review feedback
2022-12-22 12:07:26 -08:00
Anna Song
a1bfab382a
Localize PatchTransformer, PatchJson6902Transformer ( #4920 )
...
* Localize patches, patchesJson6902 custom transformers
* Improve readability
2022-12-16 09:52:17 -08:00
yugo kobayashi
5fed0f76c8
refactor Unmarshal Kustomization struct code
2022-12-13 21:04:50 +00:00
yugo kobayashi
faddb49c89
remove FixKustomizationPreUnmarshalling
2022-12-13 18:50:25 +00:00
Anna Song
4cccb838ce
Load legacy kustomization fields for localize ( #4918 )
...
* Load legacy kustomization
* Expose loadKustFile in kusttarget
2022-12-13 08:19:34 -08:00
Anna Song
292d18983d
Localize patchesJson6902, patchesStrategicMerge, replacements ( #4904 )
...
* Localize patchesJson6902, patchesStrategicMerge, replacements
* Address code review feedback
* Improve readability
* Remove deprecation warning check
2022-12-12 10:41:33 -08:00
Christopher Fry
8a6602db94
Allow name suffix transformer configuration to be overridden
2022-12-08 20:10:05 +00:00
Natasha Sarkar
2db573b6a0
drop support for legacy patches ( #4911 )
...
* drop support for legacy patches
* fix CI
2022-12-07 18:06:24 -08:00
Kubernetes Prow Robot
8a869f6045
Merge pull request #4882 from ChristopherFry/cfry/user-config-priority
...
Add test ensuring user configuration overrides default configuration
2022-12-06 22:46:38 -08:00
Katrina Verey
903fbb6ed2
Wildcard support for creation in ReplacementTransformer ( #4886 )
...
* Ahead-of-time wildcard path expansion solution
* Wrapped PathGetter solution
This approach doesn't work when multiple existing sequence elements
should match, i.e. because the sequence contains maps and we're
searching on a key they all contain (target all containers with a certain
image would be one use case for this). PathGetter just takes the first
match in that case, which is not what we want.
* Add creation support to PathMatcher
* Regression test for existing bug when creation is enabled and sequence query should match multiple elements
* PathMatcher Create tests and support for sequence appending
* revert hyphen append support
PathGetter treats it as meaning 'last' not 'append' and does not have test coverage for its handling of this when create is set. Semantics are dubious given that multiple Replacement fieldPaths may be specified, which would cause successive appends.
* This also provides a solution to issue 1493
* Review feedback
2022-12-06 12:40:37 -08:00
Katrina Verey
2ed910abb0
Replacements should throw errors on invalid targets ( #4789 )
...
* Replacements should throw errors on invalid targets
* Refactor to satisfy complexity linter
* Move new tests to filter suite
2022-12-05 18:54:36 -08:00
Christopher Fry
570865baae
Address peer review
2022-12-05 23:06:50 +00:00
Anna Song
71eb865cea
Localize configMapGenerator, secretGenerator fields ( #4894 )
...
* Localize configMapGenerator, secretGenerator fields
* Improve readability
* Expose kv parseFileSource
* Add localizeGenerator to Localizer
* Improve and test ParseFileSource error messages
2022-12-02 15:31:53 -08:00
Yannis Zarkadas
a502717460
Make ordering configurable ( #4019 )
...
* api: Add new types for customizeable resource ordering
Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com >
* plugins: Implement SortOrderTransformer plugin
Implement the SortOrderTransformer plugin. This plugin allows the user
to customize the order that kustomize will output resources in.
The API for the plugin is the following:
sortOptions:
order: legacy | fifo
legacySortOptions:
orderFirst:
- {GVK}
orderLast:
- {GVK}
Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com >
* plugins: Add boilerplate and generate code for new SortOrderTransformer
Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com >
* build: Add option to denote if the reorder flag was set by the user
We want to take different actions if the reorder flag was set by the
user or filled by the default value. Thus, we propagate this information
from build to the krusty options.
Signed-off-by: Yannis Zarkadas <yanniszark@gmail.com >
* api/krusty: Ensure sort ordering works with CLI flag and kustomization
Sort order can be defined in two places:
- (new) kustomization file
- (old) CLI flag
We want the kustomization file to take precedence over the CLI flag.
Eventually, we may want to move away from having a CLI flag altogether:
https://github.com/kubernetes-sigs/kustomize/issues/3947
Case 1: Sort order set in kustomization file AND in CLI flag.
Print a warning and let the kustomization file take precedence.
Case 2: Sort order set in CLI flag only or not at all.
Follow the CLI flag (defaults to legacy) and reorder at the end.
Case 3: Sort order set in kustomization file only.
Simply build the kustomization.
Signed-off-by: Yannis Zarkadas <yanniszark@gmail.com >
* krusty: Add e2e test for SortOrderTransformer
Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com >
* plugins: Purge LegacyOrderTransformer
Signed-off-by: Yannis Zarkadas <yanniszark@gmail.com >
* Update go.work.sum
Signed-off-by: Yannis Zarkadas <yanniszark@gmail.com >
* review: Make review changes
Signed-off-by: Yannis Zarkadas <yanniszark@gmail.com >
Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com >
Signed-off-by: Yannis Zarkadas <yanniszark@gmail.com >
2022-12-02 13:59:53 -08:00
Kishore Jagannath
1e2e7bbc0b
Refactor 7 return values in parseGitUrl to RepoSpec(issue 4866, Task1) ( #4900 )
...
* initial commit to refactor 7 return values in parseGitUrl to RepoSpec
* fix review comments
2022-12-02 10:01:53 -08:00
Anna Song
e34d5b5608
Localize components ( #4867 )
2022-12-02 09:33:53 -08:00
Kubernetes Prow Robot
0f4f978956
Merge pull request #4895 from KnVerey/remove-local-last
...
Remove local-only resources at the last minute
2022-12-01 13:20:00 -08:00
Kubernetes Prow Robot
3c8db55f53
Merge pull request #4901 from annasong20/clean-localizer
...
Clean `localizer`
2022-12-01 11:21:54 -08:00
Anna Song
b8611cf0a9
Refactor localizer code
...
* encapsulate kusttarget params
* change dst to string
* ConfirmDir
2022-12-01 09:53:46 -08:00
Kubernetes Prow Robot
baf777c56e
Merge pull request #4893 from KnVerey/pluginator-linter-bug
...
Fix pluginator incompatibility with nolint lines
2022-11-30 08:32:55 -08:00
Katrina Verey
a612cd2b7e
Fix pluginator incompatibility with nolint lines
2022-11-30 11:22:10 -05:00
Katrina Verey
fb0f567b63
Remove local-only resources at the last minute
...
This allows name references to them to be correctly resolved
2022-11-29 19:05:16 -05:00
Kubernetes Prow Robot
f53d018302
Merge pull request #4885 from annasong20/contain-ldr-path
...
Contain `RepoSpec` path in repo
2022-11-29 14:35:08 -08:00
Kubernetes Prow Robot
d9d9785791
Merge pull request #4890 from brianpursley/kustomize-4628
...
merge2: preserve explicitly set null values
2022-11-29 12:35:08 -08:00
Anna Song
832b552076
Load built-in plugins for kustomize localize ( #4869 )
...
* Load and filter built-in plugins
* Improve readability
* Process plugins as resources instead of bytes
* Throw error for validators
* Differentiate generators, transformers processing
* Enable validators
* add wrapper error
* improve documentation
2022-11-28 13:23:42 -08:00
Anna Song
0eff094faf
Calculate localized path for remote file ( #4878 )
...
* Calculate localized path for remote file
* Add documentation
2022-11-28 09:36:06 -08:00
Brian Pursley
1b7db20504
merge2: preserve explicitly set null values
...
Fixed bug where an explicitly set null value in yaml was
cleared, even when the patch did not operate on that field.
2022-11-26 16:33:14 -05:00
Anna Song
07063a2652
Prevent repoSpec path from exiting repo
2022-11-23 14:29:22 -08:00
Christopher Fry
0c4f863bc5
Add test ensuring user configuration overrides default configuration
2022-11-21 23:39:45 +00:00
Katrina Verey
91a2c2b1a4
Update to Go 1.19
2022-11-17 12:57:17 -05:00