This PR closes a TODO in the fileLoader type to
replace the string representing a git repo url
with a struct called holding validated fields.
New struct is called RepoSpec.
It holds what we need in coming PRs for remote
repo base containment checks, and will also allow
the overlay cycle prevention code to take into
account different host schemes or branches.
The struct is in a new file called repospec.go.
The new file is mostly just a code move of url
parsing code that was in cloner.go. Git "blame"
history preserved through the move.
No change in execution (see final commit by itself).
Enable varcheck and fix found issues
Add ineffassign to list of checks and fix found issues
Added nakedret and fixed found issues
Add interfacer check and fix found issue
Add lll and fix found issues
Add deadcode linter, remove unused code
