mirror of
https://github.com/kubernetes-sigs/kustomize.git
synced 2026-06-11 17:12:51 +00:00
* test: use `T.TempDir` to create temporary test directory
This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `ioutil.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix `TestInit_noargs` on Windows
--- FAIL: TestInit_noargs (0.01s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestInit_noargs3136084632\001: The process cannot access the file because it is being used by another process.
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix `TestTreeCommandDefaultCurDir_files` on Windows
--- FAIL: TestTreeCommandDefaultCurDir_files (0.01s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestTreeCommandDefaultCurDir_files716679291\001: The process cannot access the file because it is being used by another process.
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix `TestCreateSetterCommand` on Windows
--- FAIL: TestCreateSetterCommand (13.27s)
--- FAIL: TestCreateSetterCommand/add_replicas (1.45s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestCreateSetterCommandadd_replicas176222064\001\k8s-cli-487197005.yaml: The process cannot access the file because it is being used by another process.
...
and all subtests
...
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix `TestCreateSubstitutionCommand` on Windows
--- FAIL: TestCreateSubstitutionCommand (4.16s)
--- FAIL: TestCreateSubstitutionCommand/substitution_replicas (1.30s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestCreateSubstitutionCommandsubstitution_replicas1352417113\001\k8s-cli-3183612276.yaml: The process cannot access the file because it is being used by another process.
...
and all subtests
...
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix `TestDeleteSetterCommand` on Windows
--- FAIL: TestDeleteSetterCommand (4.36s)
--- FAIL: TestDeleteSetterCommand/delete_replicas (1.31s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestDeleteSetterCommanddelete_replicas3949811929\001\k8s-cli-957077271.yaml: The process cannot access the file because it is being used by another process.
...
and all subtests
...
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix `TestDeleteSubstitutionCommand` on Windows
--- FAIL: TestDeleteSubstitutionCommand (2.35s)
--- FAIL: TestDeleteSubstitutionCommand/delete_only_subst_if_setter_has_same_name_-_long_ref (1.15s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestDeleteSubstitutionCommanddelete_only_subst_if_setter_has_same_name_-_long_ref2039728641\001\k8s-cli-1602861478.yaml: The process cannot access the file because it is being used by another process.
...
and all subtests
...
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix `TestSetCommand` on Windows
--- FAIL: TestSetCommand (13.76s)
--- FAIL: TestSetCommand/set_replicas (1.13s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestSetCommandset_replicas3781384539\001\k8s-cli-1030344459.yaml: The process cannot access the file because it is being used by another process.
...
and all subtests
...
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
242 lines
5.0 KiB
Go
242 lines
5.0 KiB
Go
// Copyright 2019 The Kubernetes Authors.
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
//go:build !windows
|
|
// +build !windows
|
|
|
|
package filesys
|
|
|
|
import (
|
|
"os"
|
|
"path"
|
|
"path/filepath"
|
|
"reflect"
|
|
"sort"
|
|
"testing"
|
|
)
|
|
|
|
func makeTestDir(t *testing.T) (FileSystem, string) {
|
|
t.Helper()
|
|
fSys := MakeFsOnDisk()
|
|
td := t.TempDir()
|
|
testDir, err := filepath.EvalSymlinks(td)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error %s", err)
|
|
}
|
|
if !fSys.Exists(testDir) {
|
|
t.Fatalf("expected existence")
|
|
}
|
|
if !fSys.IsDir(testDir) {
|
|
t.Fatalf("expected directory")
|
|
}
|
|
return fSys, testDir
|
|
}
|
|
|
|
func TestCleanedAbs_1(t *testing.T) {
|
|
fSys, _ := makeTestDir(t)
|
|
|
|
d, f, err := fSys.CleanedAbs("")
|
|
if err != nil {
|
|
t.Fatalf("unexpected err=%v", err)
|
|
}
|
|
wd, err := os.Getwd()
|
|
if err != nil {
|
|
t.Fatalf("unexpected err=%v", err)
|
|
}
|
|
if d.String() != wd {
|
|
t.Fatalf("unexpected d=%s", d)
|
|
}
|
|
if f != "" {
|
|
t.Fatalf("unexpected f=%s", f)
|
|
}
|
|
}
|
|
|
|
func TestCleanedAbs_2(t *testing.T) {
|
|
fSys, _ := makeTestDir(t)
|
|
|
|
d, f, err := fSys.CleanedAbs("/")
|
|
if err != nil {
|
|
t.Fatalf("unexpected err=%v", err)
|
|
}
|
|
if d != "/" {
|
|
t.Fatalf("unexpected d=%s", d)
|
|
}
|
|
if f != "" {
|
|
t.Fatalf("unexpected f=%s", f)
|
|
}
|
|
}
|
|
|
|
func TestCleanedAbs_3(t *testing.T) {
|
|
fSys, testDir := makeTestDir(t)
|
|
|
|
err := fSys.WriteFile(
|
|
filepath.Join(testDir, "foo"), []byte(`foo`))
|
|
if err != nil {
|
|
t.Fatalf("unexpected err=%v", err)
|
|
}
|
|
|
|
d, f, err := fSys.CleanedAbs(filepath.Join(testDir, "foo"))
|
|
if err != nil {
|
|
t.Fatalf("unexpected err=%v", err)
|
|
}
|
|
if d.String() != testDir {
|
|
t.Fatalf("unexpected d=%s", d)
|
|
}
|
|
if f != "foo" {
|
|
t.Fatalf("unexpected f=%s", f)
|
|
}
|
|
}
|
|
|
|
func TestCleanedAbs_4(t *testing.T) {
|
|
fSys, testDir := makeTestDir(t)
|
|
|
|
err := fSys.MkdirAll(filepath.Join(testDir, "d1", "d2"))
|
|
if err != nil {
|
|
t.Fatalf("unexpected err=%v", err)
|
|
}
|
|
err = fSys.WriteFile(
|
|
filepath.Join(testDir, "d1", "d2", "bar"),
|
|
[]byte(`bar`))
|
|
if err != nil {
|
|
t.Fatalf("unexpected err=%v", err)
|
|
}
|
|
|
|
d, f, err := fSys.CleanedAbs(
|
|
filepath.Join(testDir, "d1", "d2"))
|
|
if err != nil {
|
|
t.Fatalf("unexpected err=%v", err)
|
|
}
|
|
if d.String() != filepath.Join(testDir, "d1", "d2") {
|
|
t.Fatalf("unexpected d=%s", d)
|
|
}
|
|
if f != "" {
|
|
t.Fatalf("unexpected f=%s", f)
|
|
}
|
|
|
|
d, f, err = fSys.CleanedAbs(
|
|
filepath.Join(testDir, "d1", "d2", "bar"))
|
|
if err != nil {
|
|
t.Fatalf("unexpected err=%v", err)
|
|
}
|
|
if d.String() != filepath.Join(testDir, "d1", "d2") {
|
|
t.Fatalf("unexpected d=%s", d)
|
|
}
|
|
if f != "bar" {
|
|
t.Fatalf("unexpected f=%s", f)
|
|
}
|
|
}
|
|
|
|
func TestReadFilesRealFS(t *testing.T) {
|
|
fSys, testDir := makeTestDir(t)
|
|
|
|
dir := path.Join(testDir, "dir")
|
|
nestedDir := path.Join(dir, "nestedDir")
|
|
hiddenDir := path.Join(testDir, ".hiddenDir")
|
|
dirs := []string{
|
|
testDir,
|
|
dir,
|
|
nestedDir,
|
|
hiddenDir,
|
|
}
|
|
// all directories will have all these files
|
|
files := []string{
|
|
"bar",
|
|
"foo",
|
|
"file-1.xtn",
|
|
".file-2.xtn",
|
|
".some-file-3.xtn",
|
|
".some-file-4.xtn",
|
|
}
|
|
|
|
err := fSys.MkdirAll(nestedDir)
|
|
if err != nil {
|
|
t.Fatalf("Unexpected Error %v\n", err)
|
|
}
|
|
err = fSys.MkdirAll(hiddenDir)
|
|
if err != nil {
|
|
t.Fatalf("Unexpected Error %v\n", err)
|
|
}
|
|
|
|
// adding all files in every directory that we had defined
|
|
for _, d := range dirs {
|
|
if !fSys.IsDir(d) {
|
|
t.Fatalf("Expected %s to be a dir\n", d)
|
|
}
|
|
for _, f := range files {
|
|
err = fSys.WriteFile(path.Join(d, f), []byte(f))
|
|
if err != nil {
|
|
t.Fatalf("unexpected error %s", err)
|
|
}
|
|
if !fSys.Exists(path.Join(d, f)) {
|
|
t.Fatalf("expected %s", f)
|
|
}
|
|
}
|
|
}
|
|
|
|
tests := map[string]struct {
|
|
globPattern string
|
|
expectedFiles []string
|
|
expectedDirs map[string][]string // glob returns directories as well, so we need to add those to expected files
|
|
}{
|
|
"AllVisibleFiles": {
|
|
globPattern: "*",
|
|
expectedFiles: []string{
|
|
"bar",
|
|
"foo",
|
|
"file-1.xtn",
|
|
},
|
|
expectedDirs: map[string][]string{
|
|
testDir: {dir},
|
|
dir: {nestedDir},
|
|
},
|
|
},
|
|
"AllHiddenFiles": {
|
|
globPattern: ".*",
|
|
expectedFiles: []string{
|
|
".file-2.xtn",
|
|
".some-file-3.xtn",
|
|
".some-file-4.xtn",
|
|
},
|
|
expectedDirs: map[string][]string{
|
|
testDir: {hiddenDir},
|
|
},
|
|
},
|
|
"foo_File": {
|
|
globPattern: "foo",
|
|
expectedFiles: []string{
|
|
"foo",
|
|
},
|
|
},
|
|
"dotsome-file_PrefixedFiles": {
|
|
globPattern: ".some-file*",
|
|
expectedFiles: []string{
|
|
".some-file-3.xtn",
|
|
".some-file-4.xtn",
|
|
},
|
|
},
|
|
}
|
|
|
|
for n, c := range tests {
|
|
t.Run(n, func(t *testing.T) {
|
|
for _, d := range dirs {
|
|
var expectedPaths []string
|
|
for _, f := range c.expectedFiles {
|
|
expectedPaths = append(expectedPaths, path.Join(d, f))
|
|
}
|
|
if c.expectedDirs != nil {
|
|
expectedPaths = append(expectedPaths, c.expectedDirs[d]...)
|
|
}
|
|
actualPaths, globErr := fSys.Glob(path.Join(d, c.globPattern))
|
|
if globErr != nil {
|
|
t.Fatalf("Unexpected Error : %v\n", globErr)
|
|
}
|
|
sort.Strings(actualPaths)
|
|
sort.Strings(expectedPaths)
|
|
if !reflect.DeepEqual(actualPaths, expectedPaths) {
|
|
t.Fatalf("incorrect files found by glob: expected=%v, actual=%v", expectedPaths, actualPaths)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|