kustomize/kyaml/openapi/internal/builtinopenapi/bundle_test.go

// Copyright 2026 The Kubernetes Authors.
// SPDX-License-Identifier: Apache-2.0

package builtinopenapi

import (
	"testing"

	"github.com/stretchr/testify/require"
	"k8s.io/kube-openapi/pkg/validation/spec"
)

func TestBundleValidate(t *testing.T) {
	valid := func() Bundle {
		definition := spec.Schema{}
		definition.Extensions = spec.Extensions{
			gvkExtension: []interface{}{
				map[string]interface{}{"group": "apps", "version": "v1", "kind": "Deployment"},
			},
		}
		return Bundle{
			FormatVersion:   FormatVersion,
			Coverage:        Coverage{Floor: "v1.21.2", Ceiling: "v1.21.2"},
			SelectionPolicy: SelectionPolicy,
			Sources: []Source{{
				KubernetesVersion: "v1.21.2",
				SHA256:            "5d171b55e9601912807a870d73ffe70bb306f5889a00e76986042a0f2d7b6bc2",
			}},
			Definitions: spec.Definitions{"definition": definition},
			Resources: []Resource{{
				APIVersion: "apps/v1",
				Kind:       "Deployment",
				Definition: "definition",
				Scope:      ScopeNamespaced,
			}},
		}
	}

	tests := map[string]func(*Bundle){
		"format":   func(bundle *Bundle) { bundle.FormatVersion++ },
		"coverage": func(bundle *Bundle) { bundle.Coverage.Floor = "" },
		"policy":   func(bundle *Bundle) { bundle.SelectionPolicy = "unknown" },
		"source":   func(bundle *Bundle) { bundle.Sources[0].SHA256 = "short" },
		"source hex": func(bundle *Bundle) {
			bundle.Sources[0].SHA256 = "zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz"
		},
		"definition": func(bundle *Bundle) { bundle.Resources[0].Definition = "missing" },
		"no definitions": func(bundle *Bundle) {
			bundle.Definitions = nil
		},
		"no resources": func(bundle *Bundle) {
			bundle.Resources = nil
		},
		"scope": func(bundle *Bundle) { bundle.Resources[0].Scope = "invalid" },
		"duplicate": func(bundle *Bundle) {
			bundle.Resources = append(bundle.Resources, bundle.Resources[0])
		},
		"duplicate with different definition": func(bundle *Bundle) {
			secondDefinition := bundle.Definitions["definition"]
			bundle.Definitions["second-definition"] = secondDefinition
			duplicate := bundle.Resources[0]
			duplicate.Definition = "second-definition"
			bundle.Resources = append(bundle.Resources, duplicate)
		},
		"GVK advertised by different definitions": func(bundle *Bundle) {
			secondDefinition := bundle.Definitions["definition"]
			bundle.Definitions["second-definition"] = secondDefinition
		},
		"order": func(bundle *Bundle) {
			bundle.Resources = append([]Resource{{APIVersion: "v1", Kind: "Pod"}}, bundle.Resources...)
		},
		"malformed definition extension type": func(bundle *Bundle) {
			definition := bundle.Definitions["definition"]
			definition.Extensions[gvkExtension] = map[string]interface{}{}
			bundle.Definitions["definition"] = definition
		},
		"malformed definition extension entry": func(bundle *Bundle) {
			definition := bundle.Definitions["definition"]
			definition.Extensions[gvkExtension] = []interface{}{map[string]interface{}{"version": "v1"}}
			bundle.Definitions["definition"] = definition
		},
		"malformed definition extension group": func(bundle *Bundle) {
			definition := bundle.Definitions["definition"]
			definition.Extensions[gvkExtension] = []interface{}{
				map[string]interface{}{"group": 1, "version": "v1", "kind": "Deployment"},
			}
			bundle.Definitions["definition"] = definition
		},
		"resource GVK absent from definition extension": func(bundle *Bundle) {
			definition := bundle.Definitions["definition"]
			definition.Extensions[gvkExtension] = []interface{}{}
			bundle.Definitions["definition"] = definition
		},
		"definition GVK absent from resources": func(bundle *Bundle) {
			definition := bundle.Definitions["definition"]
			definition.Extensions[gvkExtension] = []interface{}{
				map[string]interface{}{"group": "apps", "version": "v1", "kind": "Deployment"},
				map[string]interface{}{"group": "apps", "version": "v1", "kind": "StatefulSet"},
			}
			bundle.Definitions["definition"] = definition
		},
	}

	require.NoError(t, func() error { bundle := valid(); return bundle.Validate() }())
	for name, mutate := range tests {
		t.Run(name, func(t *testing.T) {
			bundle := valid()
			mutate(&bundle)
			require.Error(t, bundle.Validate())
		})
	}
}

func TestLessResourceUsesOnlyGVK(t *testing.T) {
	left := Resource{APIVersion: "apps/v1", Kind: "Deployment", Definition: "z"}
	right := Resource{APIVersion: "apps/v1", Kind: "Deployment", Definition: "a"}
	require.False(t, lessResource(left, right))
	require.False(t, lessResource(right, left))

	require.True(t, lessResource(
		Resource{APIVersion: "apps/v1", Kind: "Deployment"},
		Resource{APIVersion: "apps/v1", Kind: "StatefulSet"},
	))
	require.True(t, lessResource(
		Resource{APIVersion: "apps/v1", Kind: "Deployment"},
		Resource{APIVersion: "batch/v1", Kind: "CronJob"},
	))
}