mirror of
https://github.com/kubernetes-sigs/kustomize.git
synced 2026-05-22 23:07:00 +00:00
* test: use `T.TempDir` to create temporary test directory
This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `ioutil.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix `TestInit_noargs` on Windows
--- FAIL: TestInit_noargs (0.01s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestInit_noargs3136084632\001: The process cannot access the file because it is being used by another process.
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix `TestTreeCommandDefaultCurDir_files` on Windows
--- FAIL: TestTreeCommandDefaultCurDir_files (0.01s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestTreeCommandDefaultCurDir_files716679291\001: The process cannot access the file because it is being used by another process.
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix `TestCreateSetterCommand` on Windows
--- FAIL: TestCreateSetterCommand (13.27s)
--- FAIL: TestCreateSetterCommand/add_replicas (1.45s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestCreateSetterCommandadd_replicas176222064\001\k8s-cli-487197005.yaml: The process cannot access the file because it is being used by another process.
...
and all subtests
...
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix `TestCreateSubstitutionCommand` on Windows
--- FAIL: TestCreateSubstitutionCommand (4.16s)
--- FAIL: TestCreateSubstitutionCommand/substitution_replicas (1.30s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestCreateSubstitutionCommandsubstitution_replicas1352417113\001\k8s-cli-3183612276.yaml: The process cannot access the file because it is being used by another process.
...
and all subtests
...
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix `TestDeleteSetterCommand` on Windows
--- FAIL: TestDeleteSetterCommand (4.36s)
--- FAIL: TestDeleteSetterCommand/delete_replicas (1.31s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestDeleteSetterCommanddelete_replicas3949811929\001\k8s-cli-957077271.yaml: The process cannot access the file because it is being used by another process.
...
and all subtests
...
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix `TestDeleteSubstitutionCommand` on Windows
--- FAIL: TestDeleteSubstitutionCommand (2.35s)
--- FAIL: TestDeleteSubstitutionCommand/delete_only_subst_if_setter_has_same_name_-_long_ref (1.15s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestDeleteSubstitutionCommanddelete_only_subst_if_setter_has_same_name_-_long_ref2039728641\001\k8s-cli-1602861478.yaml: The process cannot access the file because it is being used by another process.
...
and all subtests
...
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix `TestSetCommand` on Windows
--- FAIL: TestSetCommand (13.76s)
--- FAIL: TestSetCommand/set_replicas (1.13s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestSetCommandset_replicas3781384539\001\k8s-cli-1030344459.yaml: The process cannot access the file because it is being used by another process.
...
and all subtests
...
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
181 lines
4.1 KiB
Go
181 lines
4.1 KiB
Go
// Copyright 2019 The Kubernetes Authors.
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
package runner
|
|
|
|
import (
|
|
"bytes"
|
|
"io"
|
|
"io/ioutil"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"sigs.k8s.io/kustomize/kyaml/errors"
|
|
)
|
|
|
|
func TestExecuteCmdOnPkgs(t *testing.T) {
|
|
var tests = []struct {
|
|
name string
|
|
recurse bool
|
|
pkgPath string
|
|
needOpenAPI bool
|
|
errMsg string
|
|
expectedOut string
|
|
}{
|
|
{
|
|
name: "need_Krmfile_error",
|
|
recurse: true,
|
|
needOpenAPI: true,
|
|
pkgPath: "subpkg1/subdir1",
|
|
errMsg: `unable to find "Krmfile" in package`,
|
|
},
|
|
{
|
|
name: "Krmfile_not_needed_no_err",
|
|
recurse: true,
|
|
needOpenAPI: false,
|
|
pkgPath: "subpkg1/subdir1",
|
|
expectedOut: `${baseDir}/subpkg1/subdir1/
|
|
`,
|
|
},
|
|
{
|
|
name: "executeCmd_returns_error",
|
|
recurse: true,
|
|
needOpenAPI: false,
|
|
pkgPath: "subpkg4",
|
|
expectedOut: `${baseDir}/subpkg4/
|
|
`,
|
|
errMsg: `this command returns an error if package has error.txt file`,
|
|
},
|
|
{
|
|
name: "executeCmd_prints_pkgpaths",
|
|
recurse: true,
|
|
needOpenAPI: false,
|
|
pkgPath: "subpkg2",
|
|
expectedOut: `${baseDir}/subpkg2/
|
|
|
|
${baseDir}/subpkg2/subpkg3/
|
|
`,
|
|
},
|
|
}
|
|
|
|
dir := t.TempDir()
|
|
err := createTestDirStructure(dir)
|
|
if !assert.NoError(t, err) {
|
|
t.FailNow()
|
|
}
|
|
|
|
for i := range tests {
|
|
test := tests[i]
|
|
t.Run(test.name, func(t *testing.T) {
|
|
actual := &bytes.Buffer{}
|
|
r := &TestRunner{}
|
|
e := ExecuteCmdOnPkgs{
|
|
NeedOpenAPI: test.needOpenAPI,
|
|
Writer: actual,
|
|
RootPkgPath: filepath.Join(dir, test.pkgPath),
|
|
RecurseSubPackages: test.recurse,
|
|
CmdRunner: r,
|
|
}
|
|
err := e.Execute()
|
|
if test.errMsg == "" {
|
|
if !assert.NoError(t, err) {
|
|
t.FailNow()
|
|
}
|
|
} else {
|
|
if !assert.Error(t, err) {
|
|
t.FailNow()
|
|
}
|
|
if !assert.Contains(t, err.Error(), test.errMsg) {
|
|
t.FailNow()
|
|
}
|
|
}
|
|
|
|
// normalize path format for windows
|
|
actualNormalized := strings.ReplaceAll(
|
|
strings.ReplaceAll(actual.String(), "\\", "/"),
|
|
"//", "/")
|
|
|
|
expected := strings.ReplaceAll(test.expectedOut, "${baseDir}", dir+"/")
|
|
expectedNormalized := strings.ReplaceAll(
|
|
strings.ReplaceAll(expected, "\\", "/"),
|
|
"//", "/")
|
|
if !assert.Equal(t, expectedNormalized, actualNormalized) {
|
|
t.FailNow()
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func createTestDirStructure(dir string) error {
|
|
/*
|
|
Adds the folders to the input dir with following structure
|
|
dir
|
|
├── subpkg1
|
|
│ ├── Krmfile
|
|
│ └── subdir1
|
|
├── subpkg4
|
|
│ ├── Krmfile
|
|
│ └── error.txt
|
|
└── subpkg2
|
|
├── subpkg3
|
|
│ ├── Krmfile
|
|
│ └── subdir2
|
|
└── Krmfile
|
|
*/
|
|
err := os.MkdirAll(filepath.Join(dir, "subpkg1/subdir1"), 0777|os.ModeDir)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
err = os.MkdirAll(filepath.Join(dir, "subpkg2/subpkg3/subdir2"), 0777|os.ModeDir)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
err = os.MkdirAll(filepath.Join(dir, "subpkg4"), 0777|os.ModeDir)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
err = ioutil.WriteFile(filepath.Join(dir, "subpkg1", "Krmfile"), []byte(""), 0644)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
err = ioutil.WriteFile(filepath.Join(dir, "subpkg2", "Krmfile"), []byte(""), 0644)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
err = ioutil.WriteFile(filepath.Join(dir, "subpkg2/subpkg3", "Krmfile"), []byte(""), 0644)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
err = ioutil.WriteFile(filepath.Join(dir, "subpkg4", "error.txt"), []byte(""), 0644)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
err = ioutil.WriteFile(filepath.Join(dir, "subpkg4", "Krmfile"), []byte(""), 0644)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
err = ioutil.WriteFile(filepath.Join(dir, "Krmfile"), []byte(""), 0644)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
type TestRunner struct{}
|
|
|
|
func (r *TestRunner) ExecuteCmd(w io.Writer, pkgPath string) error {
|
|
children, err := ioutil.ReadDir(pkgPath)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
for _, child := range children {
|
|
if child.Name() == "error.txt" {
|
|
return errors.Errorf("this command returns an error if package has error.txt file")
|
|
}
|
|
}
|
|
return nil
|
|
}
|