mirror of
https://github.com/kubernetes-sigs/kustomize.git
synced 2026-05-18 03:45:12 +00:00
1426137883
The apimachinery code path, in its final marshalling for output, calls Marshall https://github.com/go-yaml/yaml/blob/v2/yaml.go#L199 This code path (via apimachinery Unstructured types) has no JSON schema tags https://yaml.org/spec/1.2/spec.html#id2803311 so it adds quotes to values that smell like booleans and ints (e.g. `false` becomes `"false"`). The kyaml code path, OTOH, uses such tags, so generally does not quote ints and booleans. This PR isolates this difference in behavior to one set of tests (using data fields in configmaps in api/krusty/configmaps_test.go) so that they don't confuse other tests that cover completely different behaviors.
112 lines
2.1 KiB
Go
112 lines
2.1 KiB
Go
// Copyright 2019 The Kubernetes Authors.
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
package krusty_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
kusttest_test "sigs.k8s.io/kustomize/api/testutils/kusttest"
|
|
)
|
|
|
|
// Coverage for issue #2609
|
|
func TestNamePrefixSuffixPatch(t *testing.T) {
|
|
th := kusttest_test.MakeHarness(t)
|
|
|
|
th.WriteF("handlers/kustomization.yaml", `
|
|
nameSuffix: -suffix
|
|
|
|
resources:
|
|
- deployment.yaml
|
|
`)
|
|
|
|
th.WriteF("handlers/deployment.yaml", `
|
|
apiVersion: apps/v1
|
|
kind: Deployment
|
|
metadata:
|
|
name: short
|
|
spec:
|
|
template:
|
|
spec:
|
|
containers:
|
|
- name: handler
|
|
`)
|
|
|
|
th.WriteF("mysql/kustomization.yaml", `
|
|
configMapGenerator:
|
|
- name: mysql
|
|
literals:
|
|
- MYSQL_USER=default
|
|
- MYSQL_DATABASE=default
|
|
- HOST=everest
|
|
`)
|
|
|
|
th.WriteK(".", `
|
|
resources:
|
|
- mysql
|
|
- handlers
|
|
|
|
configMapGenerator:
|
|
- name: mysql
|
|
behavior: merge
|
|
literals:
|
|
- MYSQL_DATABASE=db
|
|
- MYSQL_USER=my-user
|
|
- MYSQL_PASSWORD='correct horse battery staple'
|
|
|
|
patches:
|
|
- target:
|
|
kind: Deployment
|
|
name: s.*
|
|
patch: |-
|
|
kind: Deployment
|
|
metadata:
|
|
name: ignored
|
|
spec:
|
|
template:
|
|
spec:
|
|
containers:
|
|
- name: handler
|
|
envFrom:
|
|
- configMapRef:
|
|
name: mysql
|
|
env:
|
|
- valueFrom:
|
|
configMapKeyRef:
|
|
name: mysql
|
|
key: MYSQL_DATABASE
|
|
`)
|
|
|
|
m := th.Run(".", th.MakeDefaultOptions())
|
|
// Per #2609, the desired behavior is for configMapRef.name and configMapKeyRef.name to be "mysql-9792mdchtg" not "mysql"
|
|
th.AssertActualEqualsExpected(m, `
|
|
apiVersion: v1
|
|
data:
|
|
HOST: everest
|
|
MYSQL_DATABASE: db
|
|
MYSQL_PASSWORD: correct horse battery staple
|
|
MYSQL_USER: my-user
|
|
kind: ConfigMap
|
|
metadata:
|
|
name: mysql-t7tt4cdbmf
|
|
---
|
|
apiVersion: apps/v1
|
|
kind: Deployment
|
|
metadata:
|
|
name: short-suffix
|
|
spec:
|
|
template:
|
|
spec:
|
|
containers:
|
|
- env:
|
|
- valueFrom:
|
|
configMapKeyRef:
|
|
key: MYSQL_DATABASE
|
|
name: mysql-t7tt4cdbmf
|
|
envFrom:
|
|
- configMapRef:
|
|
name: mysql-t7tt4cdbmf
|
|
name: handler
|
|
`)
|
|
}
|