mirror of
https://github.com/kubernetes-sigs/kustomize.git
synced 2026-05-17 18:25:26 +00:00
f66e5bb923
This PR - defines a patch conflict detector interface, - extracts implementations of the interface from the merginator code, making the merginator code independent of --enable_kyaml. - injects those implementations into kustomize as a function of --enable_kyaml. So, instead of using different merginators to combine resmaps, this pr allows the use of a single patch merge code path that uses different conflict detectors. So instead of debating how to merge, we're now only considering whether to warn on conflict detection in one transformer. This PR is in service of #3304, eliminating seven instances where --enable_kyaml was consulted. These were cases where conflict detection wasn't an issue (but merging patches was).
121 lines
3.2 KiB
Go
121 lines
3.2 KiB
Go
// Copyright 2019 The Kubernetes Authors.
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
package execplugin_test
|
|
|
|
import (
|
|
"path/filepath"
|
|
"runtime"
|
|
"strings"
|
|
"testing"
|
|
|
|
"sigs.k8s.io/kustomize/api/filesys"
|
|
. "sigs.k8s.io/kustomize/api/internal/plugins/execplugin"
|
|
pLdr "sigs.k8s.io/kustomize/api/internal/plugins/loader"
|
|
"sigs.k8s.io/kustomize/api/internal/plugins/utils"
|
|
"sigs.k8s.io/kustomize/api/konfig"
|
|
fLdr "sigs.k8s.io/kustomize/api/loader"
|
|
"sigs.k8s.io/kustomize/api/provider"
|
|
"sigs.k8s.io/kustomize/api/resmap"
|
|
)
|
|
|
|
func TestExecPluginConfig(t *testing.T) {
|
|
fSys := filesys.MakeFsInMemory()
|
|
fSys.WriteFile("sed-input.txt", []byte(`
|
|
s/$FOO/foo/g
|
|
s/$BAR/bar baz/g
|
|
\ \ \
|
|
`))
|
|
ldr, err := fLdr.NewLoader(
|
|
fLdr.RestrictionRootOnly, filesys.Separator, fSys)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
pvd := provider.NewDefaultDepProvider()
|
|
rf := resmap.NewFactory(
|
|
pvd.GetResourceFactory(), pvd.GetConflictDetectorFactory())
|
|
pluginConfig := rf.RF().FromMap(
|
|
map[string]interface{}{
|
|
"apiVersion": "someteam.example.com/v1",
|
|
"kind": "SedTransformer",
|
|
"metadata": map[string]interface{}{
|
|
"name": "some-random-name",
|
|
},
|
|
"argsOneLiner": "one two 'foo bar'",
|
|
"argsFromFile": "sed-input.txt",
|
|
})
|
|
|
|
p := NewExecPlugin(
|
|
pLdr.AbsolutePluginPath(
|
|
konfig.DisabledPluginConfig(),
|
|
pluginConfig.OrgId()))
|
|
// Not checking to see if the plugin is executable,
|
|
// because this test does not run it.
|
|
// This tests only covers sending configuration
|
|
// to the plugin wrapper object and confirming
|
|
// that it's properly prepared for execution.
|
|
|
|
yaml, err := pluginConfig.AsYAML()
|
|
if err != nil {
|
|
t.Fatalf("unexpected err: %v", err)
|
|
}
|
|
p.Config(resmap.NewPluginHelpers(ldr, pvd.GetFieldValidator(), rf), yaml)
|
|
|
|
expected := "someteam.example.com/v1/sedtransformer/SedTransformer"
|
|
if !strings.HasSuffix(p.Path(), expected) {
|
|
t.Fatalf("expected suffix '%s', got '%s'", expected, p.Path())
|
|
}
|
|
|
|
expected = `apiVersion: someteam.example.com/v1
|
|
argsFromFile: sed-input.txt
|
|
argsOneLiner: one two 'foo bar'
|
|
kind: SedTransformer
|
|
metadata:
|
|
name: some-random-name
|
|
`
|
|
if expected != string(p.Cfg()) {
|
|
t.Fatalf("expected cfg '%s', got '%s'", expected, string(p.Cfg()))
|
|
|
|
}
|
|
if len(p.Args()) != 6 {
|
|
t.Fatalf("unexpected arg len %d, %#v", len(p.Args()), p.Args())
|
|
}
|
|
if p.Args()[0] != "one" ||
|
|
p.Args()[1] != "two" ||
|
|
p.Args()[2] != "foo bar" ||
|
|
p.Args()[3] != "s/$FOO/foo/g" ||
|
|
p.Args()[4] != "s/$BAR/bar baz/g" ||
|
|
p.Args()[5] != "\\ \\ \\ " {
|
|
t.Fatalf("unexpected arg array: %#v", p.Args())
|
|
}
|
|
}
|
|
|
|
func TestExecPlugin_ErrIfNotExecutable(t *testing.T) {
|
|
if runtime.GOOS == "windows" {
|
|
t.Skipf("always returns nil on Windows")
|
|
}
|
|
|
|
srcRoot, err := utils.DeterminePluginSrcRoot(filesys.MakeFsOnDisk())
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
// Test unexecutable plugin
|
|
unexecutablePlugin := filepath.Join(
|
|
srcRoot, "builtin", "", "secretgenerator", "SecretGenerator.so")
|
|
p := NewExecPlugin(unexecutablePlugin)
|
|
err = p.ErrIfNotExecutable()
|
|
if err == nil {
|
|
t.Fatalf("unexpected err: %v", err)
|
|
}
|
|
|
|
// Test executable plugin
|
|
executablePlugin := filepath.Join(
|
|
srcRoot, "someteam.example.com", "v1", "bashedconfigmap", "BashedConfigMap")
|
|
p = NewExecPlugin(executablePlugin)
|
|
err = p.ErrIfNotExecutable()
|
|
if err != nil {
|
|
t.Fatalf("unexpected err: %v", err)
|
|
}
|
|
}
|