Files
kustomize/kustomize/commands/internal/util/configmapSecretFlagsAndArgs.go
Mauren Berti 30893b0184 feat: edit set configmap (#5391)
* feat: add new command 'edit set configmap'

* Add a new command 'edit set configmap' to allow editing the values of an
  already-existing configmap in a kustomization file.
* Add tests to validate the new feature.

* fix: add tests, minor refactoring to use constants

* Include tests to validade the new function ValidateSet, included to do
  necessary validations when running the 'kustomize edit set configmap' command.
* Minor refactorings to use the existing constants in the 'edit set configmap'
  command.
* Add dashes before each item in the comment explaining how ExpandFileSource()
  works so IDEs don't try to reformat the list and remove the indentation in it.
* Because this change mutates the list of literal sources, ensure that both add
  and set save the resulting list in a predictable order to make it easier to
  check when new items are added/removed and aid in testing.
* Since literal sources are the only bit that's important in this test, verify
  that the literal sources in the actual result is equal to what we expected it
  to be.

* fix: change format to print resource name

Use '%q' formatter instead of '%s' to print resource name

Co-authored-by: Varsha <varshaprasad96@gmail.com>

* fix: add changes from code review

* Unexport constant that is used only in the scope of a single function.
* Add extra validation to ensure format is correct with one single '=' per key-value
  pair.
* Add extra set of tests to validate format.
* Update test case to match new printed format in the error message.

* fix: rollback sort for edit add/set configmap

* chore: rename test package and unexport functions

Rename the test package from set_test back to set and unexport functions that do
not need to be exported anymore for testing purposes.

* feat: handle empty and default namespace as equal

Handle the empty and the default namespaces as equal. Add tests to validate this
scenario.

---------

Co-authored-by: Varsha <varshaprasad96@gmail.com>
2023-11-17 19:14:53 +01:00

218 lines
6.7 KiB
Go

// Copyright 2019 The Kubernetes Authors.
// SPDX-License-Identifier: Apache-2.0
package util
import (
"fmt"
"strings"
"sigs.k8s.io/kustomize/api/types"
"sigs.k8s.io/kustomize/kyaml/filesys"
)
const (
FromFileFlag = "from-file"
FromLiteralFlag = "from-literal"
FromEnvFileFlag = "from-env-file"
DisableNameSuffixHashFlag = "disableNameSuffixHash"
BehaviorFlag = "behavior"
NamespaceFlag = "namespace"
NewNamespaceFlag = "new-namespace"
FlagFormat = "--%s=%s"
)
// ConfigMapSecretFlagsAndArgs encapsulates the options for add secret/configmap commands.
type ConfigMapSecretFlagsAndArgs struct {
// Name of ConfigMap/Secret (required)
Name string
// FileSources to derive the ConfigMap/Secret from (optional)
FileSources []string
// LiteralSources to derive the ConfigMap/Secret from (optional)
LiteralSources []string
// EnvFileSource to derive the ConfigMap/Secret from (optional)
// TODO: Rationalize this name with Generic.EnvSource
EnvFileSource string
// Resource generation behavior (optional)
Behavior string
// Type of secret to create
Type string
// Namespace of ConfigMap/Secret (optional) -- if unspecified, default is assumed
Namespace string
// Disable name suffix
DisableNameSuffixHash bool
// NewNamespace for ConfigMap/Secret (optional) -- only for 'edit set' command
NewNamespace string
}
// ValidateAdd validates required fields are set to support structured generation for the
// edit add command.
func (a *ConfigMapSecretFlagsAndArgs) ValidateAdd(args []string) error {
if len(args) != 1 {
return fmt.Errorf("name must be specified once")
}
a.Name = args[0]
if len(a.EnvFileSource) == 0 && len(a.FileSources) == 0 && len(a.LiteralSources) == 0 {
return fmt.Errorf("at least from-env-file, or from-file or from-literal must be set")
}
if len(a.EnvFileSource) > 0 && (len(a.FileSources) > 0 || len(a.LiteralSources) > 0) {
return fmt.Errorf("from-env-file cannot be combined with from-file or from-literal")
}
if len(a.Behavior) > 0 && types.NewGenerationBehavior(a.Behavior) == types.BehaviorUnspecified {
return fmt.Errorf(`invalid behavior: must be one of "%s", "%s", or "%s"`,
types.BehaviorCreate, types.BehaviorMerge, types.BehaviorReplace)
}
// TODO: Should we check if the path exists? if it's valid, if it's within the same (sub-)directory?
return nil
}
// ValidateSet validates required fields are set to support structured generation for the
// edit set command.
func (a *ConfigMapSecretFlagsAndArgs) ValidateSet(args []string) error {
if len(args) != 1 {
return fmt.Errorf("name must be specified once")
}
a.Name = args[0]
if len(a.LiteralSources) == 0 && a.NewNamespace == "" {
return fmt.Errorf("at least one of [--from-literal, --new-namespace] must be specified")
}
return nil
}
// ExpandFileSource normalizes a string list, possibly
// containing globs, into a validated, globless list.
// For example, this list:
// - some/path
// - some/dir/a*
// - bfile=some/dir/b*
// becomes:
// - some/path
// - some/dir/airplane
// - some/dir/ant
// - some/dir/apple
// - bfile=some/dir/banana
// i.e. everything is converted to a key=value pair,
// where the value is always a relative file path,
// and the key, if missing, is the same as the value.
// In the case where the key is explicitly declared,
// the globbing, if present, must have exactly one match.
func (a *ConfigMapSecretFlagsAndArgs) ExpandFileSource(fSys filesys.FileSystem) error {
const numberComponentsWithKey = 2
var results []string
for _, pattern := range a.FileSources {
var patterns []string
key := ""
// check if the pattern is in `--from-file=[key=]source` format
// and if so split it to send only the file-pattern to glob function
s := strings.Split(pattern, "=")
if len(s) == numberComponentsWithKey {
patterns = append(patterns, s[1])
key = s[0]
} else {
patterns = append(patterns, s[0])
}
result, err := GlobPatterns(fSys, patterns)
if err != nil {
return err
}
// if the format is `--from-file=[key=]source` accept only one result
// and extend it with the `key=` prefix
if key != "" {
if len(result) != 1 {
return fmt.Errorf(
"'pattern '%s' catches files %v, should catch only one", pattern, result)
}
fileSource := fmt.Sprintf("%s=%s", key, result[0])
results = append(results, fileSource)
} else {
results = append(results, result...)
}
}
a.FileSources = results
return nil
}
// UpdateLiteralSources looks for literal sources that already exist and tries
// to replace their values with new values.
// The key specified must exist in the target resource (ConfigMap or Secret).
func UpdateLiteralSources(
args *types.GeneratorArgs,
flags ConfigMapSecretFlagsAndArgs,
) error {
sources := make(map[string]any)
for _, val := range args.LiteralSources {
key, value, err := validateAndExtractLiteralSource(val)
if err != nil {
return fmt.Errorf("failed to update resource: %w", err)
}
sources[key] = value
}
for _, val := range flags.LiteralSources {
key, value, err := validateAndExtractLiteralSource(val)
if err != nil {
return fmt.Errorf("failed to update resource: %w", err)
}
if _, ok := sources[key]; !ok {
return fmt.Errorf("key '%s' not found in resource", key)
}
sources[key] = value
}
// re-assemble key-pairs
newLiteralSources := make([]string, 0)
for key, val := range sources {
newLiteralSources = append(newLiteralSources, fmt.Sprintf("%s=%s", key, val))
}
args.LiteralSources = newLiteralSources
return nil
}
func validateAndExtractLiteralSource(val string) (string, string, error) {
// This is the separator to be used as a boundary for the key/value pair
const keyValueSeparator = "="
// Maximum number of times the separator can appear in the string
const maximumSeparatorNumber = 1
count := strings.Count(val, keyValueSeparator)
if count <= 0 || count > maximumSeparatorNumber {
return "", "", fmt.Errorf("invalid format: literal values must be specified in the key=value format")
}
key, value, _ := strings.Cut(val, keyValueSeparator) // we don't need the value of found because of prior validation
return key, value, nil
}
func MergeFlagsIntoGeneratorArgs(args *types.GeneratorArgs, flags ConfigMapSecretFlagsAndArgs) {
if len(flags.LiteralSources) > 0 {
args.LiteralSources = append(
args.LiteralSources, flags.LiteralSources...)
}
if len(flags.FileSources) > 0 {
args.FileSources = append(
args.FileSources, flags.FileSources...)
}
if flags.EnvFileSource != "" {
args.EnvSources = append(
args.EnvSources, flags.EnvFileSource)
}
if flags.DisableNameSuffixHash {
args.Options = &types.GeneratorOptions{
DisableNameSuffixHash: true,
}
}
if flags.Behavior != "" {
args.Behavior = flags.Behavior
}
}