mirror of
https://github.com/kubernetes-sigs/kustomize.git
synced 2026-05-25 08:17:02 +00:00
* test: use `T.TempDir` to create temporary test directory
This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `ioutil.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix `TestInit_noargs` on Windows
--- FAIL: TestInit_noargs (0.01s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestInit_noargs3136084632\001: The process cannot access the file because it is being used by another process.
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix `TestTreeCommandDefaultCurDir_files` on Windows
--- FAIL: TestTreeCommandDefaultCurDir_files (0.01s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestTreeCommandDefaultCurDir_files716679291\001: The process cannot access the file because it is being used by another process.
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix `TestCreateSetterCommand` on Windows
--- FAIL: TestCreateSetterCommand (13.27s)
--- FAIL: TestCreateSetterCommand/add_replicas (1.45s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestCreateSetterCommandadd_replicas176222064\001\k8s-cli-487197005.yaml: The process cannot access the file because it is being used by another process.
...
and all subtests
...
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix `TestCreateSubstitutionCommand` on Windows
--- FAIL: TestCreateSubstitutionCommand (4.16s)
--- FAIL: TestCreateSubstitutionCommand/substitution_replicas (1.30s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestCreateSubstitutionCommandsubstitution_replicas1352417113\001\k8s-cli-3183612276.yaml: The process cannot access the file because it is being used by another process.
...
and all subtests
...
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix `TestDeleteSetterCommand` on Windows
--- FAIL: TestDeleteSetterCommand (4.36s)
--- FAIL: TestDeleteSetterCommand/delete_replicas (1.31s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestDeleteSetterCommanddelete_replicas3949811929\001\k8s-cli-957077271.yaml: The process cannot access the file because it is being used by another process.
...
and all subtests
...
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix `TestDeleteSubstitutionCommand` on Windows
--- FAIL: TestDeleteSubstitutionCommand (2.35s)
--- FAIL: TestDeleteSubstitutionCommand/delete_only_subst_if_setter_has_same_name_-_long_ref (1.15s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestDeleteSubstitutionCommanddelete_only_subst_if_setter_has_same_name_-_long_ref2039728641\001\k8s-cli-1602861478.yaml: The process cannot access the file because it is being used by another process.
...
and all subtests
...
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix `TestSetCommand` on Windows
--- FAIL: TestSetCommand (13.76s)
--- FAIL: TestSetCommand/set_replicas (1.13s)
testing.go:1090: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestSetCommandset_replicas3781384539\001\k8s-cli-1030344459.yaml: The process cannot access the file because it is being used by another process.
...
and all subtests
...
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
175 lines
3.7 KiB
Go
175 lines
3.7 KiB
Go
// Copyright 2021 The Kubernetes Authors.
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
package command_test
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/spf13/cobra"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"sigs.k8s.io/kustomize/kyaml/fn/framework"
|
|
"sigs.k8s.io/kustomize/kyaml/fn/framework/command"
|
|
"sigs.k8s.io/kustomize/kyaml/fn/framework/frameworktestutil"
|
|
"sigs.k8s.io/kustomize/kyaml/kio"
|
|
"sigs.k8s.io/kustomize/kyaml/yaml"
|
|
)
|
|
|
|
func TestCommand_dockerfile(t *testing.T) {
|
|
d := t.TempDir()
|
|
|
|
// create a function
|
|
cmd := command.Build(&framework.SimpleProcessor{}, command.StandaloneEnabled, false)
|
|
// add the Dockerfile generator
|
|
command.AddGenerateDockerfile(cmd)
|
|
|
|
// generate the Dockerfile
|
|
cmd.SetArgs([]string{"gen", d})
|
|
if !assert.NoError(t, cmd.Execute()) {
|
|
t.FailNow()
|
|
}
|
|
|
|
b, err := ioutil.ReadFile(filepath.Join(d, "Dockerfile"))
|
|
if !assert.NoError(t, err) {
|
|
t.FailNow()
|
|
}
|
|
|
|
expected := `FROM golang:1.16-alpine as builder
|
|
ENV CGO_ENABLED=0
|
|
WORKDIR /go/src/
|
|
COPY go.mod go.sum ./
|
|
RUN go mod download
|
|
COPY . .
|
|
RUN go build -ldflags '-w -s' -v -o /usr/local/bin/function ./
|
|
|
|
FROM alpine:latest
|
|
COPY --from=builder /usr/local/bin/function /usr/local/bin/function
|
|
ENTRYPOINT ["function"]
|
|
`
|
|
if !assert.Equal(t, expected, string(b)) {
|
|
t.FailNow()
|
|
}
|
|
}
|
|
|
|
// TestCommand_standalone tests the framework works in standalone mode
|
|
func TestCommand_standalone(t *testing.T) {
|
|
var config struct {
|
|
A string `json:"a" yaml:"a"`
|
|
B int `json:"b" yaml:"b"`
|
|
}
|
|
|
|
fn := func(items []*yaml.RNode) ([]*yaml.RNode, error) {
|
|
items = append(items, yaml.MustParse(`
|
|
apiVersion: apps/v1
|
|
kind: Deployment
|
|
metadata:
|
|
name: bar1
|
|
namespace: default
|
|
annotations:
|
|
foo: bar1
|
|
`))
|
|
for i := range items {
|
|
err := items[i].PipeE(yaml.SetAnnotation("a", config.A))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
err = items[i].PipeE(yaml.SetAnnotation("b", fmt.Sprintf("%v", config.B)))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
|
|
return items, nil
|
|
}
|
|
|
|
cmdFn := func() *cobra.Command {
|
|
return command.Build(&framework.SimpleProcessor{Filter: kio.FilterFunc(fn), Config: &config}, command.StandaloneEnabled, false)
|
|
}
|
|
|
|
tc := frameworktestutil.CommandResultsChecker{Command: cmdFn}
|
|
tc.Assert(t)
|
|
}
|
|
|
|
func TestCommand_standalone_stdin(t *testing.T) {
|
|
var config struct {
|
|
A string `json:"a" yaml:"a"`
|
|
B int `json:"b" yaml:"b"`
|
|
}
|
|
|
|
p := &framework.SimpleProcessor{
|
|
Config: &config,
|
|
|
|
Filter: kio.FilterFunc(func(items []*yaml.RNode) ([]*yaml.RNode, error) {
|
|
items = append(items, yaml.MustParse(`
|
|
apiVersion: apps/v1
|
|
kind: Deployment
|
|
metadata:
|
|
name: bar2
|
|
namespace: default
|
|
annotations:
|
|
foo: bar2
|
|
`))
|
|
for i := range items {
|
|
err := items[i].PipeE(yaml.SetAnnotation("a", config.A))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
err = items[i].PipeE(yaml.SetAnnotation("b", fmt.Sprintf("%v", config.B)))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
|
|
return items, nil
|
|
}),
|
|
}
|
|
cmd := command.Build(p, command.StandaloneEnabled, false)
|
|
cmd.SetIn(bytes.NewBufferString(`
|
|
apiVersion: apps/v1
|
|
kind: Deployment
|
|
metadata:
|
|
name: bar1
|
|
namespace: default
|
|
annotations:
|
|
foo: bar1
|
|
spec:
|
|
replicas: 1
|
|
`))
|
|
var out bytes.Buffer
|
|
cmd.SetOut(&out)
|
|
cmd.SetArgs([]string{filepath.Join("testdata", "standalone", "config.yaml"), "-"})
|
|
|
|
require.NoError(t, cmd.Execute())
|
|
|
|
require.Equal(t, strings.TrimSpace(`
|
|
apiVersion: apps/v1
|
|
kind: Deployment
|
|
metadata:
|
|
name: bar1
|
|
namespace: default
|
|
annotations:
|
|
foo: bar1
|
|
a: 'c'
|
|
b: '1'
|
|
spec:
|
|
replicas: 1
|
|
---
|
|
apiVersion: apps/v1
|
|
kind: Deployment
|
|
metadata:
|
|
name: bar2
|
|
namespace: default
|
|
annotations:
|
|
foo: bar2
|
|
a: 'c'
|
|
b: '1'
|
|
`), strings.TrimSpace(out.String()))
|
|
}
|