mirror of
https://github.com/kubernetes-sigs/kustomize.git
synced 2026-05-18 05:05:14 +00:00
793577d044
Fixes #366 To reproduce #366, add ``` bases: - . ``` to `examples/helloWorld/kustomization.yaml`, attempt to build it, and enjoy the stack overflow. This PR fixes this by adding history to file loaders, allowing one to avoid cycles in overlay->base relationships. To make entry points clearer, this PR exposes only two public ways to make a fresh (no-history) loader * rooted at `/` * rooted at the process's current working directory. When making a new loader from an existing loader, retaining history along an overlay trace, the only allowed use is to go deeper into a file hierarchy, or go up and over to a never before visited sibling. This fix can probably be defeated by devious symbolic links.
109 lines
2.6 KiB
Go
109 lines
2.6 KiB
Go
/*
|
|
Copyright 2018 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package loader
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"os"
|
|
"path/filepath"
|
|
"sigs.k8s.io/kustomize/pkg/ifc"
|
|
"strings"
|
|
|
|
"github.com/hashicorp/go-getter"
|
|
|
|
"sigs.k8s.io/kustomize/pkg/fs"
|
|
)
|
|
|
|
// githubLoader loads files from a checkout github repo
|
|
type githubLoader struct {
|
|
repo string
|
|
// targetDir will hold the local repo
|
|
targetDir string
|
|
// checkoutDir is for the whole repository
|
|
checkoutDir string
|
|
loader *fileLoader
|
|
}
|
|
|
|
// Root returns the root location for this Loader.
|
|
func (l *githubLoader) Root() string {
|
|
return l.targetDir
|
|
}
|
|
|
|
// New delegates to fileLoader.New
|
|
func (l *githubLoader) New(newRoot string) (ifc.Loader, error) {
|
|
return l.loader.New(newRoot)
|
|
}
|
|
|
|
// Load delegates to fileLoader.Load
|
|
func (l *githubLoader) Load(location string) ([]byte, error) {
|
|
return l.loader.Load(location)
|
|
}
|
|
|
|
// Cleanup removes the checked out repo
|
|
func (l *githubLoader) Cleanup() error {
|
|
return os.RemoveAll(l.checkoutDir)
|
|
}
|
|
|
|
// newGithubLoader returns a new fileLoader with given github Url.
|
|
func newGithubLoader(repoUrl string, fs fs.FileSystem) (*githubLoader, error) {
|
|
dir, err := ioutil.TempDir("", "kustomize-")
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
repodir := filepath.Join(dir, "repo")
|
|
src, subdir := getter.SourceDirSubdir(repoUrl)
|
|
err = checkout(src, repodir)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
target := filepath.Join(repodir, subdir)
|
|
l, _ := newFileLoaderAt(fs, target)
|
|
return &githubLoader{
|
|
repo: repoUrl,
|
|
targetDir: target,
|
|
checkoutDir: repodir,
|
|
loader: l,
|
|
}, nil
|
|
}
|
|
|
|
// isRepoUrl checks if a string is a repo Url
|
|
func isRepoUrl(s string) bool {
|
|
if strings.HasPrefix(s, "https://") {
|
|
return true
|
|
}
|
|
if strings.HasPrefix(s, "git::") {
|
|
return true
|
|
}
|
|
host := strings.SplitN(s, "/", 2)[0]
|
|
return strings.Contains(host, ".com") || strings.Contains(host, ".org")
|
|
}
|
|
|
|
// Checkout clones a github repo with specified commit/tag/branch
|
|
func checkout(url, dir string) error {
|
|
pwd, err := os.Getwd()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
client := &getter.Client{
|
|
Src: url,
|
|
Dst: dir,
|
|
Pwd: pwd,
|
|
Mode: getter.ClientModeDir,
|
|
}
|
|
return client.Get()
|
|
}
|