rlespinasse/slugify-value
1
0
Fork 0
mirror of https://github.com/rlespinasse/slugify-value.git synced 2026-05-17 18:25:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(slug_url): replace underscore

Browse Source 
To be compliant with Hostname syntax, we need to remove underscores from the slug value.

Since the hostname is part of the URL, we update the SLUG_URL values instead of creating a new SLUG_HOSTNAME (for example).
This commit is contained in:
Romain Lespinasse
2022-04-08 20:38:08 +02:00
committed by GitHub
parent ce66c2e7e3
commit 1300b1ecaf
3 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
.github/workflows/slugify-value.yaml vendored
View File

@@ -27,8 +27,8 @@ jobs:
[[ "${{ env.KEY_TEST }}" == "Key_Test.values" ]]
[[ "${{ env.KEY_TEST_SLUG }}" == "key_test.values" ]]
[[ "${{ env.KEY_TEST_SLUG_CS }}" == "Key_Test.values" ]]
[[ "${{ env.KEY_TEST_SLUG_URL }}" == "key_test-values" ]]
[[ "${{ env.KEY_TEST_SLUG_URL_CS }}" == "Key_Test-values" ]]
[[ "${{ env.KEY_TEST_SLUG_URL }}" == "key-test-values" ]]
[[ "${{ env.KEY_TEST_SLUG_URL_CS }}" == "Key-Test-values" ]]
shell: bash
# Test 2
@@ -59,8 +59,8 @@ jobs:
[[ "${{ env.KEY_VALUE_TEST }}" == "refs/pulls/feat/-----Some----Changes_to.be------" ]]
[[ "${{ env.KEY_VALUE_TEST_SLUG }}" == "feat-some-changes_to.be" ]]
[[ "${{ env.KEY_VALUE_TEST_SLUG_CS }}" == "feat-Some-Changes_to.be" ]]
[[ "${{ env.KEY_VALUE_TEST_SLUG_URL }}" == "feat-some-changes_to-be" ]]
[[ "${{ env.KEY_VALUE_TEST_SLUG_URL_CS }}" == "feat-Some-Changes_to-be" ]]
[[ "${{ env.KEY_VALUE_TEST_SLUG_URL }}" == "feat-some-changes-to-be" ]]
[[ "${{ env.KEY_VALUE_TEST_SLUG_URL_CS }}" == "feat-Some-Changes-to-be" ]]
shell: bash
# Test 4
@@ -91,8 +91,8 @@ jobs:
[[ "${{ env.KEY_VALUE_TEST }}" == "refs/pulls/feat/-----Some----Changes_to.be-----Some----Changes_to.be-----Some----Changes_to.be-----Some----Changes_to.be------" ]]
[[ "${{ env.KEY_VALUE_TEST_SLUG }}" == "feat-some-changes_to.be-some-changes_to.be-some-changes_to.be-some-changes_to.be" ]]
[[ "${{ env.KEY_VALUE_TEST_SLUG_CS }}" == "feat-Some-Changes_to.be-Some-Changes_to.be-Some-Changes_to.be-Some-Changes_to.be" ]]
[[ "${{ env.KEY_VALUE_TEST_SLUG_URL }}" == "feat-some-changes_to-be-some-changes_to-be-some-changes_to-be-some-changes_to-be" ]]
[[ "${{ env.KEY_VALUE_TEST_SLUG_URL_CS }}" == "feat-Some-Changes_to-be-Some-Changes_to-be-Some-Changes_to-be-Some-Changes_to-be" ]]
[[ "${{ env.KEY_VALUE_TEST_SLUG_URL }}" == "feat-some-changes-to-be-some-changes-to-be-some-changes-to-be-some-changes-to-be" ]]
[[ "${{ env.KEY_VALUE_TEST_SLUG_URL_CS }}" == "feat-Some-Changes-to-be-Some-Changes-to-be-Some-Changes-to-be-Some-Changes-to-be" ]]
shell: bash
# Test 6