fix: remove dashes group substitution

Co-authored-by: Gaetan BOGAERT <gbogaert62@gmail.com>
This commit is contained in:
Romain Lespinasse
2022-04-08 21:39:31 +02:00
committed by GitHub
parent 1300b1ecaf
commit ae545a3d5d
2 changed files with 46 additions and 38 deletions

View File

@@ -19,80 +19,80 @@ jobs:
- name: Slugify key only - name: Slugify key only
uses: ./ uses: ./
with: with:
key: KEY_TEST key: KEY_ONLY
env: env:
KEY_TEST: Key_Test.values KEY_ONLY: "refs/head/$-Key_Only.test--value-%-+"
- name: Validate // Slugify key only - name: Validate // Slugify key only
run: | run: |
[[ "${{ env.KEY_TEST }}" == "Key_Test.values" ]] [[ "${{ env.KEY_ONLY }}" == "refs/head/$-Key_Only.test--value-%-+" ]]
[[ "${{ env.KEY_TEST_SLUG }}" == "key_test.values" ]] [[ "${{ env.KEY_ONLY_SLUG }}" == "key_only.test--value" ]]
[[ "${{ env.KEY_TEST_SLUG_CS }}" == "Key_Test.values" ]] [[ "${{ env.KEY_ONLY_SLUG_CS }}" == "Key_Only.test--value" ]]
[[ "${{ env.KEY_TEST_SLUG_URL }}" == "key-test-values" ]] [[ "${{ env.KEY_ONLY_SLUG_URL }}" == "key-only-test--value" ]]
[[ "${{ env.KEY_TEST_SLUG_URL_CS }}" == "Key-Test-values" ]] [[ "${{ env.KEY_ONLY_SLUG_URL_CS }}" == "Key-Only-test--value" ]]
shell: bash shell: bash
# Test 2 # Test 2
- name: Slugify key only with prefix - name: Slugify key only with prefix
uses: ./ uses: ./
with: with:
key: KEY_TEST key: KEY_ONLY_WITH_PREFIX
prefix: CI_ prefix: CI_
env: env:
KEY_TEST: Key_Test.values KEY_ONLY_WITH_PREFIX: ${{ env.KEY_ONLY }}
- name: Validate // Slugify key only with prefix - name: Validate // Slugify key only with prefix
run: | run: |
[[ "${{ env.CI_KEY_TEST }}" == "${{ env.KEY_TEST }}" ]] [[ "${{ env.CI_KEY_ONLY_WITH_PREFIX }}" == "${{ env.KEY_ONLY }}" ]]
[[ "${{ env.CI_KEY_TEST_SLUG }}" == "${{ env.KEY_TEST_SLUG }}" ]] [[ "${{ env.CI_KEY_ONLY_WITH_PREFIX_SLUG }}" == "${{ env.KEY_ONLY_SLUG }}" ]]
[[ "${{ env.CI_KEY_TEST_SLUG_CS }}" == "${{ env.KEY_TEST_SLUG_CS }}" ]] [[ "${{ env.CI_KEY_ONLY_WITH_PREFIX_SLUG_CS }}" == "${{ env.KEY_ONLY_SLUG_CS }}" ]]
[[ "${{ env.CI_KEY_TEST_SLUG_URL }}" == "${{ env.KEY_TEST_SLUG_URL }}" ]] [[ "${{ env.CI_KEY_ONLY_WITH_PREFIX_SLUG_URL }}" == "${{ env.KEY_ONLY_SLUG_URL }}" ]]
[[ "${{ env.CI_KEY_TEST_SLUG_URL_CS }}" == "${{ env.KEY_TEST_SLUG_URL_CS }}" ]] [[ "${{ env.CI_KEY_ONLY_WITH_PREFIX_SLUG_URL_CS }}" == "${{ env.KEY_ONLY_SLUG_URL_CS }}" ]]
shell: bash shell: bash
# Test 3 # Test 3
- name: Slugify key/value - name: Slugify key/value
uses: ./ uses: ./
with: with:
key: KEY_VALUE_TEST key: KEY_VALUE
value: refs/pulls/feat/-----Some----Changes_to.be------ value: "Never gonna give you up Never gonna let you down"
- name: Validate // Slugify key/value - name: Validate // Slugify key/value
run: | run: |
[[ "${{ env.KEY_VALUE_TEST }}" == "refs/pulls/feat/-----Some----Changes_to.be------" ]] [[ "${{ env.KEY_VALUE }}" == "Never gonna give you up Never gonna let you down" ]]
[[ "${{ env.KEY_VALUE_TEST_SLUG }}" == "feat-some-changes_to.be" ]] [[ "${{ env.KEY_VALUE_SLUG }}" == "never-gonna-give-you-up-never-gonna-let-you-down" ]]
[[ "${{ env.KEY_VALUE_TEST_SLUG_CS }}" == "feat-Some-Changes_to.be" ]] [[ "${{ env.KEY_VALUE_SLUG_CS }}" == "Never-gonna-give-you-up-Never-gonna-let-you-down" ]]
[[ "${{ env.KEY_VALUE_TEST_SLUG_URL }}" == "feat-some-changes-to-be" ]] [[ "${{ env.KEY_VALUE_SLUG_URL }}" == "never-gonna-give-you-up-never-gonna-let-you-down" ]]
[[ "${{ env.KEY_VALUE_TEST_SLUG_URL_CS }}" == "feat-Some-Changes-to-be" ]] [[ "${{ env.KEY_VALUE_SLUG_URL_CS }}" == "Never-gonna-give-you-up-Never-gonna-let-you-down" ]]
shell: bash shell: bash
# Test 4 # Test 4
- name: Slugify with another max length - name: Slugify with another max length
uses: ./ uses: ./
with: with:
key: KEY_VALUE_TEST key: ANOTHER_MAX_LENGTH
value: refs/pulls/feat/-----Some----Changes_to.be------ value: "Never gonna give you up Never gonna let you down"
slug-maxlength: 12 slug-maxlength: 23
- name: Validate // Slugify with another max length - name: Validate // Slugify with another max length
run: | run: |
[[ "${{ env.KEY_VALUE_TEST }}" == "refs/pulls/feat/-----Some----Changes_to.be------" ]] [[ "${{ env.ANOTHER_MAX_LENGTH }}" == "Never gonna give you up Never gonna let you down" ]]
[[ "${{ env.KEY_VALUE_TEST_SLUG }}" == "feat-some-ch" ]] [[ "${{ env.ANOTHER_MAX_LENGTH_SLUG }}" == "never-gonna-give-you-up" ]]
[[ "${{ env.KEY_VALUE_TEST_SLUG_CS }}" == "feat-Some-Ch" ]] [[ "${{ env.ANOTHER_MAX_LENGTH_SLUG_CS }}" == "Never-gonna-give-you-up" ]]
[[ "${{ env.KEY_VALUE_TEST_SLUG_URL }}" == "feat-some-ch" ]] [[ "${{ env.ANOTHER_MAX_LENGTH_SLUG_URL }}" == "never-gonna-give-you-up" ]]
[[ "${{ env.KEY_VALUE_TEST_SLUG_URL_CS }}" == "feat-Some-Ch" ]] [[ "${{ env.ANOTHER_MAX_LENGTH_SLUG_URL_CS }}" == "Never-gonna-give-you-up" ]]
shell: bash shell: bash
# Test 5 # Test 5
- name: Slugify with no limit on max length - name: Slugify with no limit on max length
uses: ./ uses: ./
with: with:
key: KEY_VALUE_TEST key: NO_MAX_LENGTH
value: refs/pulls/feat/-----Some----Changes_to.be-----Some----Changes_to.be-----Some----Changes_to.be-----Some----Changes_to.be------ value: "Never gonna give you up Never gonna let you down Never gonna run around and desert you Never gonna make you cry Never gonna say goodbye Never gonna tell a lie and hurt you"
slug-maxlength: "nolimit" slug-maxlength: "nolimit"
- name: Validate // Slugify with no limit on max length - name: Validate // Slugify with no limit on max length
run: | run: |
[[ "${{ env.KEY_VALUE_TEST }}" == "refs/pulls/feat/-----Some----Changes_to.be-----Some----Changes_to.be-----Some----Changes_to.be-----Some----Changes_to.be------" ]] [[ "${{ env.NO_MAX_LENGTH }}" == "Never gonna give you up Never gonna let you down Never gonna run around and desert you Never gonna make you cry Never gonna say goodbye Never gonna tell a lie and hurt you" ]]
[[ "${{ env.KEY_VALUE_TEST_SLUG }}" == "feat-some-changes_to.be-some-changes_to.be-some-changes_to.be-some-changes_to.be" ]] [[ "${{ env.NO_MAX_LENGTH_SLUG }}" == "never-gonna-give-you-up-never-gonna-let-you-down-never-gonna-run-around-and-desert-you-never-gonna-make-you-cry-never-gonna-say-goodbye-never-gonna-tell-a-lie-and-hurt-you" ]]
[[ "${{ env.KEY_VALUE_TEST_SLUG_CS }}" == "feat-Some-Changes_to.be-Some-Changes_to.be-Some-Changes_to.be-Some-Changes_to.be" ]] [[ "${{ env.NO_MAX_LENGTH_SLUG_CS }}" == "Never-gonna-give-you-up-Never-gonna-let-you-down-Never-gonna-run-around-and-desert-you-Never-gonna-make-you-cry-Never-gonna-say-goodbye-Never-gonna-tell-a-lie-and-hurt-you" ]]
[[ "${{ env.KEY_VALUE_TEST_SLUG_URL }}" == "feat-some-changes-to-be-some-changes-to-be-some-changes-to-be-some-changes-to-be" ]] [[ "${{ env.NO_MAX_LENGTH_SLUG_URL }}" == "never-gonna-give-you-up-never-gonna-let-you-down-never-gonna-run-around-and-desert-you-never-gonna-make-you-cry-never-gonna-say-goodbye-never-gonna-tell-a-lie-and-hurt-you" ]]
[[ "${{ env.KEY_VALUE_TEST_SLUG_URL_CS }}" == "feat-Some-Changes-to-be-Some-Changes-to-be-Some-Changes-to-be-Some-Changes-to-be" ]] [[ "${{ env.NO_MAX_LENGTH_SLUG_URL_CS }}" == "Never-gonna-give-you-up-Never-gonna-let-you-down-Never-gonna-run-around-and-desert-you-Never-gonna-make-you-cry-Never-gonna-say-goodbye-Never-gonna-tell-a-lie-and-hurt-you" ]]
shell: bash shell: bash
# Test 6 # Test 6

View File

@@ -28,12 +28,20 @@ else
fi fi
slug() { slug() {
output=$(sed -E 's#refs/[^\/]*/##;s/[^a-zA-Z0-9._-]+/-/g;s/-+/-/g;s/^-*//;s/-*$//' <<<"$1") # 1st : Remove refs prefix
# 2d : Replace unwanted characters
# 3d : Remove leading dashes
# 4d : Remove trailing dashes
output=$(sed -E 's#refs/[^\/]*/##;s/[^a-zA-Z0-9._-]+/-/g;s/^-*//;s/-*$//' <<<"$1")
reduce "$output" reduce "$output"
} }
slug_url() { slug_url() {
output=$(sed -E 's#refs/[^\/]*/##;s/[^a-zA-Z0-9-]+/-/g;s/-+/-/g;s/^-*//;s/-*$//' <<<"$1") # 1st : Remove refs prefix
# 2d : Replace unwanted characters
# 3d : Remove leading dashes
# 4d : Remove trailing dashes
output=$(sed -E 's#refs/[^\/]*/##;s/[^a-zA-Z0-9-]+/-/g;s/^-*//;s/-*$//' <<<"$1")
reduce "$output" reduce "$output"
} }