Update Makefile with licenseadder and golangci-lint

This commit is contained in:
Phillip Wittrock
2019-11-07 07:56:02 -08:00
parent 04d5494246
commit 0029a8ce32
3 changed files with 69 additions and 4 deletions

54
kyaml/.golangci.yml Normal file
View File

@@ -0,0 +1,54 @@
# Copyright 2019 The Kubernetes Authors.
# SPDX-License-Identifier: Apache-2.0
run:
deadline: 5m
linters:
# please, do not use `enable-all`: it's deprecated and will be removed soon.
# inverted configuration with `enable-all` and `disable` is not scalable during updates of golangci-lint
disable-all: true
enable:
- bodyclose
- deadcode
- depguard
- dogsled
- dupl
# - errcheck
# - funlen
# - gochecknoinits
# - goconst
# - gocritic
- gocyclo
- gofmt
- goimports
# - golint
- gosec
- gosimple
- govet
- ineffassign
- interfacer
# - lll
- misspell
- nakedret
# - scopelint
- staticcheck
- structcheck
# - stylecheck
- typecheck
- unconvert
# - unparam
- unused
- varcheck
# - whitespace
linters-settings:
dupl:
threshold: 400
lll:
line-length: 170
gocyclo:
min-complexity: 30
golint:
min-confidence: 0.85

2
kyaml/LICENSE_TEMPLATE Normal file
View File

@@ -0,0 +1,2 @@
Copyright {{.Year}} {{.Holder}}
SPDX-License-Identifier: Apache-2.0

View File

@@ -1,9 +1,14 @@
# Copyright 2019 The Kubernetes Authors.
# SPDX-License-Identifier: Apache-2.0
.PHONY: generate fix vet fmt test build tidy
.PHONY: generate license fix vet fmt test build tidy
all: generate fix vet fmt test build tidy
GOPATH := $(shell go env GOPATH)
build:
go build -v -o $(GOPATH)/bin/kyaml .
all: generate license fix vet fmt test lint lint tidy
fix:
go fix ./...
@@ -14,12 +19,16 @@ fmt:
generate:
go generate ./...
license:
(which $(GOPATH)/bin/addlicense || go get github.com/google/addlicense)
$(GOPATH)/bin/addlicense -y 2019 -c "The Kubernetes Authors." -f LICENSE_TEMPLATE .
tidy:
go mod tidy
lint:
(which $(go env GOPATH)/bin/golangci-lint || go get github.com/golangci/golangci-lint/cmd/golangci-lint@v1.19.1)
$(go env GOPATH)/bin/golangci-lint run ./...
(which $(GOPATH)/bin/golangci-lint || go get github.com/golangci/golangci-lint/cmd/golangci-lint@v1.19.1)
$(GOPATH)/bin/golangci-lint run ./...
test:
go test -cover ./...