fix namespace will match all empty namespace

This commit is contained in:
Donny Xia
2020-09-17 12:46:18 -07:00
parent 20cd4bfef9
commit 2f8a376ae4
2 changed files with 8 additions and 2 deletions

View File

@@ -530,7 +530,7 @@ func (m *resWrangler) Select(s types.Selector) ([]*resource.Resource, error) {
// matches the namespace when namespace is not empty in the selector
// It first tries to match with the original namespace
// then matches with the current namespace
if r.GetNamespace() != "" {
if s.Namespace != "" {
matched := ns.MatchString(orgId.EffectiveNamespace())
if !matched {
matched = ns.MatchString(curId.EffectiveNamespace())
@@ -543,7 +543,7 @@ func (m *resWrangler) Select(s types.Selector) ([]*resource.Resource, error) {
// matches the name when name is not empty in the selector
// It first tries to match with the original name
// then matches with the current name
if r.GetName() != "" {
if s.Name != "" {
matched := nm.MatchString(orgId.Name)
if !matched {
matched = nm.MatchString(curId.Name)

View File

@@ -164,6 +164,12 @@ func TestFindPatchTargets(t *testing.T) {
},
count: 2,
},
{
target: types.Selector{
Namespace: "foo",
},
count: 0,
},
}
for _, testcase := range testcases {
actual, err := rm.Select(testcase.target)