Skip multi-mod check if PULL_NUMBER unset

This commit is contained in:
Sam Wronski
2020-11-10 16:22:48 -08:00
parent b58075cbc3
commit 4b89c2afa2
2 changed files with 42 additions and 6 deletions

View File

@@ -6,7 +6,17 @@
MYGOBIN := $(shell go env GOPATH)/bin
SHELL := /bin/bash
export PATH := $(MYGOBIN):$(PATH)
MODULES := "cmd/config" "api/" "kustomize/" "kyaml/"
MODULES := '"cmd/config" "api/" "kustomize/" "kyaml/"'
# Provide defaults for REPO_OWNER and REPO_NAME if not present.
# Typically these values would be provided by Prow.
ifndef REPO_OWNER
REPO_OWNER := "kubernetes-sigs"
endif
ifndef REPO_NAME
REPO_NAME := "kustomize"
endif
.PHONY: all
all: verify-kustomize
@@ -233,11 +243,14 @@ test-go-mod:
# https://github.com/kubernetes/test-infra/blob/master/prow/jobs.md#job-environment-variables
.PHONY: test-multi-module
test-multi-module: $(MYGOBIN)/prchecker
$(MYGOBIN)/prchecker \
-owner=$(REPO_OWNER) \
-repo=$(REPO_NAME) \
-pr=$(PULL_NUMBER) \
$(MODULES)
( \
export MYGOBIN=$(MYGOBIN); \
export REPO_OWNER=$(REPO_OWNER); \
export REPO_NAME=$(REPO_NAME); \
export PULL_NUMBER=$(PULL_NUMBER); \
export MODULES=$(MODULES); \
./scripts/check-multi-module.sh; \
)
.PHONY:
test-examples-e2e-kustomize: $(MYGOBIN)/mdrip $(MYGOBIN)/kind

23
scripts/check-multi-module.sh Executable file
View File

@@ -0,0 +1,23 @@
#!/bin/bash
set -e
if [[ "$PULL_NUMBER" -ne "" ]]; then
cmd="$MYGOBIN/prchecker
-owner=$REPO_OWNER
-repo=$REPO_NAME
-pr=$PULL_NUMBER
$MODULES"
echo $MYGOBIN
echo $REPO_OWNER
echo $REPO_NAME
echo $PULL_NUMBER
echo $MODULES
eval $cmd
else
echo "Multi-module check skipped. No PULL_NUMBER provided.
To run this check locally set PULL_NUMBER to the PR ID from GitHub."
fi