kubernetes-sigs/kustomize
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/kustomize.git synced 2026-06-11 00:52:55 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Refactor changeset spanning function naming

Browse Source
This commit is contained in:
Sam Wronski
2020-11-05 12:23:45 -08:00
parent 1f697e3792
commit 712eb6d276
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cmd/prchecker/main.go
View File

@@ -235,7 +235,7 @@ func PullRequestSpanningPathList(repository GitHubService, pullrequest int, path
spanningChangesExist := false spanningChangesExist := false
for _, changeset := range changesets { for _, changeset := range changesets {
if ChangesetSpanningPathList(changeset, paths) { if changeset.isSpanningPaths(paths) {
// When detecting the first spanning changeset print a prefix message // When detecting the first spanning changeset print a prefix message
if !spanningChangesExist { if !spanningChangesExist {
fmt.Printf("Spanning changesets detected in the following commits:\n\n") fmt.Printf("Spanning changesets detected in the following commits:\n\n")
@@ -250,9 +250,9 @@ func PullRequestSpanningPathList(repository GitHubService, pullrequest int, path
return spanningChangesExist, changesets, nil return spanningChangesExist, changesets, nil
} }
// ChangesetSpanningPathList tests if a changeset is spanning // isSpanningPaths tests if a changeset is spanning
// multiple directory paths. // multiple directory paths.
func ChangesetSpanningPathList(changeset *Changeset, paths []string) bool { func (changeset *Changeset) isSpanningPaths(paths []string) bool {
matchedPath := "" matchedPath := ""
for _, file := range changeset.files { for _, file := range changeset.files {

2
cmd/prchecker/main_test.go
View File

@@ -260,7 +260,7 @@ func TestIsChangesetSpanning(t *testing.T) {
changeset := &Changeset{files: tt.changeset} changeset := &Changeset{files: tt.changeset}
result := ChangesetSpanningPathList(changeset, tt.files) result := changeset.isSpanningPaths(tt.files)
if result != tt.expected { if result != tt.expected {
t.Errorf("got %t, want %t", result, tt.expected) t.Errorf("got %t, want %t", result, tt.expected)