Merge pull request #874 from CodeLingoBot/rewrite

Fix function comments based on best practices from Effective Go
This commit is contained in:
Kubernetes Prow Robot
2019-03-12 14:50:39 -07:00
committed by GitHub
2 changed files with 2 additions and 2 deletions

View File

@@ -54,7 +54,7 @@ func (r *Resource) Behavior() types.GenerationBehavior {
return r.options.Behavior()
}
// NeedAppendHash checks if the resource need a hash suffix
// NeedHashSuffix checks if the resource need a hash suffix
func (r *Resource) NeedHashSuffix() bool {
return r.options != nil && r.options.NeedsHashSuffix()
}

View File

@@ -47,7 +47,7 @@ func (g *GenArgs) String() string {
"}"
}
// NeedHashSuffix returns true if the hash suffix is needed.
// NeedsHashSuffix returns true if the hash suffix is needed.
// It is needed when the two conditions are both met
// 1) GenArgs is not nil
// 2) DisableNameSuffixHash in GeneratorOptions is not set to true