kubernetes-sigs/kustomize
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/kustomize.git synced 2026-06-12 01:14:22 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Fix 'config run' by removing default mount.

Browse Source 
In, pull #1822 mount logic was refactored where the default
mount using zero-value no longer makes sense and leads to
this failure:

"invalid argument "type=,src=,dst=:ro" for "--mount" flag: type is
required"

I think the intent here was to remove default mount.
This commit is contained in:
Frank Farzan
2019-12-09 14:37:57 -08:00
parent 46be801a48
commit a4c69d9cde
2 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
kyaml/runfn/runfn.go
View File

@@ -92,8 +92,6 @@ func (r *RunFns) init() {
// if containerFilterProvider hasn't been set, use the default // if containerFilterProvider hasn't been set, use the default
if r.containerFilterProvider == nil { if r.containerFilterProvider == nil {
r.containerFilterProvider = func(image, path string, api *yaml.RNode) kio.Filter { r.containerFilterProvider = func(image, path string, api *yaml.RNode) kio.Filter {
defaultMount := filters.StorageMount{}
r.StorageMounts = append(r.StorageMounts, defaultMount)
cf := &filters.ContainerFilter{Image: image, Config: api, StorageMounts: r.StorageMounts} cf := &filters.ContainerFilter{Image: image, Config: api, StorageMounts: r.StorageMounts}
return cf return cf
} }

5
kyaml/runfn/runfn_test.go
View File

@@ -40,10 +40,7 @@ kind:
return return
} }
filter := instance.containerFilterProvider("example.com:version", "", api) filter := instance.containerFilterProvider("example.com:version", "", api)
defaultMount := filters.StorageMount{} assert.Equal(t, &filters.ContainerFilter{Image: "example.com:version", Config: api}, filter)
mounts := []filters.StorageMount{}
mounts = append(mounts, defaultMount)
assert.Equal(t, &filters.ContainerFilter{Image: "example.com:version", Config: api, StorageMounts: mounts}, filter)
} }
func TestCmd_Execute(t *testing.T) { func TestCmd_Execute(t *testing.T) {