mirror of
https://github.com/kubernetes-sigs/kustomize.git
synced 2026-07-08 21:27:44 +00:00
Merge pull request #1326 from keleustes/residequals-patchtransformer
Residequals patchtransformer
This commit is contained in:
Kubernetes Prow Robot
@@ -45,7 +45,7 @@ func (jmp *jsonMergePatch) findConflict(
|
||||
if i == conflictingPatchIdx {
|
||||
continue
|
||||
}
|
||||
if !patches[conflictingPatchIdx].OrgId().GvknEquals(patch.OrgId()) {
|
||||
if !patches[conflictingPatchIdx].OrgId().Equals(patch.OrgId()) {
|
||||
continue
|
||||
}
|
||||
conflict, err := mergepatch.HasConflicts(
|
||||
@@ -105,7 +105,7 @@ func (smp *strategicMergePatch) findConflict(
|
||||
if i == conflictingPatchIdx {
|
||||
continue
|
||||
}
|
||||
if !patches[conflictingPatchIdx].OrgId().GvknEquals(patch.OrgId()) {
|
||||
if !patches[conflictingPatchIdx].OrgId().Equals(patch.OrgId()) {
|
||||
continue
|
||||
}
|
||||
conflict, err := strategicpatch.MergingMapsHaveConflicts(
|
||||
@@ -135,7 +135,7 @@ func MergePatches(patches []*resource.Resource,
|
||||
rc := resmap.New()
|
||||
for ix, patch := range patches {
|
||||
id := patch.OrgId()
|
||||
existing := rc.GetMatchingResourcesByOriginalId(id.GvknEquals)
|
||||
existing := rc.GetMatchingResourcesByOriginalId(id.Equals)
|
||||
if len(existing) == 0 {
|
||||
rc.Append(patch)
|
||||
continue
|
||||
|
||||
@@ -4,6 +4,7 @@
|
||||
package main_test
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
@@ -533,3 +534,667 @@ paths:
|
||||
t.Fatalf("expected error to contain %q but get %v", "conflict", err)
|
||||
}
|
||||
}
|
||||
|
||||
// simple utility function to add an namespace in a resource
|
||||
// used as base, patch or expected result. Simply looks
|
||||
// for specs: in order to add namespace: xxxx before this line
|
||||
func addNamespace(namespace string, base string) string {
|
||||
res := strings.Replace(base,
|
||||
"\nspec:\n",
|
||||
"\n namespace: "+namespace+"\nspec:\n",
|
||||
1)
|
||||
return res
|
||||
}
|
||||
|
||||
// unExpectedError function handles unexpected error
|
||||
func unExpectedError(t *testing.T, name string, err error) {
|
||||
t.Fatalf("%q; - unexpected error %v", name, err)
|
||||
}
|
||||
|
||||
// compareExpectedError compares the expectedError and the actualError return by GetFieldValue
|
||||
func compareExpectedError(t *testing.T, name string, err error, errorMsg string) {
|
||||
if err == nil {
|
||||
t.Fatalf("%q; - should return error, but no error returned", name)
|
||||
}
|
||||
|
||||
if !strings.Contains(err.Error(), errorMsg) {
|
||||
t.Fatalf("%q; - expected error: \"%s\", got error: \"%v\"",
|
||||
name, errorMsg, err.Error())
|
||||
}
|
||||
}
|
||||
|
||||
const Deployment string = "Deployment"
|
||||
const MyCRD string = "MyCRD"
|
||||
|
||||
// baseResource produces a base object which used to test
|
||||
// patch transformation
|
||||
// Also the structure is matching the Deployment syntax
|
||||
// the kind can be replaced to allow testing using CRD
|
||||
// without access to the schema
|
||||
func baseResource(kind string) string {
|
||||
|
||||
res := `
|
||||
apiVersion: apps/v1
|
||||
kind: %s
|
||||
metadata:
|
||||
name: deploy1
|
||||
spec:
|
||||
template:
|
||||
metadata:
|
||||
labels:
|
||||
old-label: old-value
|
||||
spec:
|
||||
containers:
|
||||
- name: nginx
|
||||
image: nginx`
|
||||
return fmt.Sprintf(res, kind)
|
||||
}
|
||||
|
||||
// addContainerAndEnvPatch produces a patch object which adds
|
||||
// an entry in the env slice of the first/nginx container
|
||||
// as well as adding a label in the metadata
|
||||
// Note that for SMP/WithSchema merge, the name:nginx entry
|
||||
// is mandatory
|
||||
func addLabelAndEnvPatch(kind string) string {
|
||||
|
||||
res := `
|
||||
apiVersion: apps/v1
|
||||
kind: %s
|
||||
metadata:
|
||||
name: deploy1
|
||||
spec:
|
||||
template:
|
||||
metadata:
|
||||
labels:
|
||||
some-label: some-value
|
||||
spec:
|
||||
containers:
|
||||
- name: nginx
|
||||
env:
|
||||
- name: SOMEENV
|
||||
value: SOMEVALUE`
|
||||
|
||||
return fmt.Sprintf(res, kind)
|
||||
}
|
||||
|
||||
// addContainerAndEnvPatch produces a patch object which adds
|
||||
// an entry in the env slice of the first/nginx container
|
||||
// as well as adding a second container in the container list
|
||||
// Note that for SMP/WithSchema merge, the name:nginx entry
|
||||
// is mandatory
|
||||
func addContainerAndEnvPatch(kind string) string {
|
||||
|
||||
res := `
|
||||
apiVersion: apps/v1
|
||||
kind: %s
|
||||
metadata:
|
||||
name: deploy1
|
||||
spec:
|
||||
template:
|
||||
spec:
|
||||
containers:
|
||||
- name: nginx
|
||||
env:
|
||||
- name: ANOTHERENV
|
||||
value: ANOTHERVALUE
|
||||
- name: anothercontainer
|
||||
image: anotherimage`
|
||||
|
||||
return fmt.Sprintf(res, kind)
|
||||
}
|
||||
|
||||
// addContainerAndEnvPatch produces a patch object which replaces
|
||||
// the value of the image field in the first/nginx container
|
||||
// Note that for SMP/WithSchema merge, the name:nginx entry
|
||||
// is mandatory
|
||||
func changeImagePatch(kind string, newImage string) string {
|
||||
|
||||
res := `
|
||||
apiVersion: apps/v1
|
||||
kind: %s
|
||||
metadata:
|
||||
name: deploy1
|
||||
spec:
|
||||
template:
|
||||
spec:
|
||||
containers:
|
||||
- name: nginx
|
||||
image: %s`
|
||||
|
||||
return fmt.Sprintf(res, kind, newImage)
|
||||
}
|
||||
|
||||
// utility method building the expected output of a SMP
|
||||
func expectedResultSMP() string {
|
||||
|
||||
return `apiVersion: apps/v1
|
||||
kind: Deployment
|
||||
metadata:
|
||||
name: deploy1
|
||||
spec:
|
||||
template:
|
||||
metadata:
|
||||
labels:
|
||||
old-label: old-value
|
||||
some-label: some-value
|
||||
spec:
|
||||
containers:
|
||||
- env:
|
||||
- name: SOMEENV
|
||||
value: SOMEVALUE
|
||||
image: nginx
|
||||
name: nginx
|
||||
`
|
||||
}
|
||||
|
||||
// utility method building the expected output of a JMP.
|
||||
// imagename parameter allows to build a result consistent
|
||||
// with the JMP behavior which basically overrides the
|
||||
// entire "containers" list.
|
||||
func expectedResultJMP(imagename string) string {
|
||||
|
||||
res := `apiVersion: apps/v1
|
||||
kind: MyCRD
|
||||
metadata:
|
||||
name: deploy1
|
||||
spec:
|
||||
template:
|
||||
metadata:
|
||||
labels:
|
||||
old-label: old-value
|
||||
some-label: some-value
|
||||
spec:
|
||||
containers:
|
||||
- env:
|
||||
- name: SOMEENV
|
||||
value: SOMEVALUE
|
||||
name: nginx
|
||||
`
|
||||
|
||||
if imagename == "" {
|
||||
return res
|
||||
}
|
||||
|
||||
res = `apiVersion: apps/v1
|
||||
kind: MyCRD
|
||||
metadata:
|
||||
name: deploy1
|
||||
spec:
|
||||
template:
|
||||
metadata:
|
||||
labels:
|
||||
old-label: old-value
|
||||
some-label: some-value
|
||||
spec:
|
||||
containers:
|
||||
- image: %s
|
||||
name: nginx
|
||||
`
|
||||
|
||||
return fmt.Sprintf(res, imagename)
|
||||
}
|
||||
|
||||
// utility method to build the expected result of a multipatch
|
||||
// the order of the patches still have influence especially
|
||||
// in the insertion location within arrays.
|
||||
func expectedResultMultiPatch(kind string, reversed bool) string {
|
||||
|
||||
res := `apiVersion: apps/v1
|
||||
kind: %s
|
||||
metadata:
|
||||
name: deploy1
|
||||
spec:
|
||||
template:
|
||||
metadata:
|
||||
labels:
|
||||
old-label: old-value
|
||||
some-label: some-value
|
||||
spec:
|
||||
containers:
|
||||
- env:
|
||||
- name: ANOTHERENV
|
||||
value: ANOTHERVALUE
|
||||
- name: SOMEENV
|
||||
value: SOMEVALUE
|
||||
image: nginx:latest
|
||||
name: nginx
|
||||
- image: anotherimage
|
||||
name: anothercontainer
|
||||
`
|
||||
|
||||
reversedres := `apiVersion: apps/v1
|
||||
kind: %s
|
||||
metadata:
|
||||
name: deploy1
|
||||
spec:
|
||||
template:
|
||||
metadata:
|
||||
labels:
|
||||
old-label: old-value
|
||||
some-label: some-value
|
||||
spec:
|
||||
containers:
|
||||
- env:
|
||||
- name: SOMEENV
|
||||
value: SOMEVALUE
|
||||
- name: ANOTHERENV
|
||||
value: ANOTHERVALUE
|
||||
image: nginx:latest
|
||||
name: nginx
|
||||
- image: anotherimage
|
||||
name: anothercontainer
|
||||
`
|
||||
|
||||
if reversed {
|
||||
return fmt.Sprintf(reversedres, kind)
|
||||
}
|
||||
|
||||
return fmt.Sprintf(res, kind)
|
||||
}
|
||||
|
||||
func toConfig(patches ...string) string {
|
||||
config := `
|
||||
apiVersion: builtin
|
||||
kind: PatchStrategicMergeTransformer
|
||||
metadata:
|
||||
name: notImportantHere
|
||||
paths:
|
||||
`
|
||||
for idx, _ := range patches {
|
||||
config = fmt.Sprintf("%s\n- ./patch%d.yaml", config, idx)
|
||||
}
|
||||
|
||||
return config
|
||||
}
|
||||
|
||||
// TestSinglePatch validates the single patch use cases
|
||||
// regarless of the schema availibility, which in turns
|
||||
// relies on StrategicMergePatch or simple JSON Patch.
|
||||
func TestSinglePatch(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
base string
|
||||
patch string
|
||||
expected string
|
||||
errorExpected bool
|
||||
errorMsg string
|
||||
}{
|
||||
{
|
||||
name: "withschema",
|
||||
base: baseResource(Deployment),
|
||||
patch: addLabelAndEnvPatch(Deployment),
|
||||
errorExpected: false,
|
||||
expected: expectedResultSMP(),
|
||||
},
|
||||
{
|
||||
name: "noschema",
|
||||
base: baseResource(MyCRD),
|
||||
patch: addLabelAndEnvPatch(MyCRD),
|
||||
errorExpected: false,
|
||||
expected: expectedResultJMP(""),
|
||||
},
|
||||
}
|
||||
|
||||
tc := plugins_test.NewEnvForTest(t).Set()
|
||||
defer tc.Reset()
|
||||
tc.BuildGoPlugin(
|
||||
"builtin", "", "PatchStrategicMergeTransformer")
|
||||
|
||||
for _, test := range tests {
|
||||
th := kusttest_test.NewKustTestPluginHarness(t, fmt.Sprintf("/%s", test.name))
|
||||
th.WriteF(fmt.Sprintf("/%s/patch%d.yaml", test.name, 0), test.patch)
|
||||
|
||||
if test.errorExpected {
|
||||
err := th.ErrorFromLoadAndRunTransformer(toConfig(test.patch), test.base)
|
||||
compareExpectedError(t, test.name, err, test.errorMsg)
|
||||
} else {
|
||||
rm := th.LoadAndRunTransformer(toConfig(test.patch), test.base)
|
||||
th.AssertActualEqualsExpected(rm, test.expected)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// TestMultiplePatches checks that the patches are applied
|
||||
// properly, that the same result is obtained,
|
||||
// regardless of the order of the patches and regardless
|
||||
// of the schema availibility (SMP vs JSON)
|
||||
func TestMultiplePatches(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
base string
|
||||
patch []string
|
||||
expected string
|
||||
errorExpected bool
|
||||
errorMsg string
|
||||
}{
|
||||
{
|
||||
name: "withschema-label-image-container",
|
||||
base: baseResource(Deployment),
|
||||
patch: []string{
|
||||
addLabelAndEnvPatch(Deployment),
|
||||
changeImagePatch(Deployment, "nginx:latest"),
|
||||
addContainerAndEnvPatch(Deployment),
|
||||
},
|
||||
errorExpected: false,
|
||||
expected: expectedResultMultiPatch(Deployment, false),
|
||||
},
|
||||
{
|
||||
name: "withschema-image-container-label",
|
||||
base: baseResource(Deployment),
|
||||
patch: []string{
|
||||
changeImagePatch(Deployment, "nginx:latest"),
|
||||
addContainerAndEnvPatch(Deployment),
|
||||
addLabelAndEnvPatch(Deployment),
|
||||
},
|
||||
errorExpected: false,
|
||||
expected: expectedResultMultiPatch(Deployment, true),
|
||||
},
|
||||
{
|
||||
name: "withschema-container-label-image",
|
||||
base: baseResource(Deployment),
|
||||
patch: []string{
|
||||
addContainerAndEnvPatch(Deployment),
|
||||
addLabelAndEnvPatch(Deployment),
|
||||
changeImagePatch(Deployment, "nginx:latest"),
|
||||
},
|
||||
errorExpected: false,
|
||||
expected: expectedResultMultiPatch(Deployment, true),
|
||||
},
|
||||
{
|
||||
name: "noschema-label-image-container",
|
||||
base: baseResource(MyCRD),
|
||||
patch: []string{
|
||||
addLabelAndEnvPatch(MyCRD),
|
||||
changeImagePatch(MyCRD, "nginx:latest"),
|
||||
addContainerAndEnvPatch(MyCRD),
|
||||
},
|
||||
// This should work
|
||||
errorExpected: true,
|
||||
errorMsg: "conflict",
|
||||
},
|
||||
{
|
||||
name: "noschema-image-container-label",
|
||||
base: baseResource(MyCRD),
|
||||
patch: []string{
|
||||
changeImagePatch(MyCRD, "nginx:latest"),
|
||||
addContainerAndEnvPatch(MyCRD),
|
||||
addLabelAndEnvPatch(MyCRD),
|
||||
},
|
||||
// This should work
|
||||
errorExpected: true,
|
||||
errorMsg: "conflict",
|
||||
},
|
||||
{
|
||||
name: "noschema-container-label-image",
|
||||
base: baseResource(MyCRD),
|
||||
patch: []string{
|
||||
addContainerAndEnvPatch(MyCRD),
|
||||
addLabelAndEnvPatch(MyCRD),
|
||||
changeImagePatch(MyCRD, "nginx:latest"),
|
||||
},
|
||||
// This should work
|
||||
errorExpected: true,
|
||||
errorMsg: "conflict",
|
||||
},
|
||||
}
|
||||
|
||||
tc := plugins_test.NewEnvForTest(t).Set()
|
||||
defer tc.Reset()
|
||||
tc.BuildGoPlugin(
|
||||
"builtin", "", "PatchStrategicMergeTransformer")
|
||||
|
||||
for _, test := range tests {
|
||||
th := kusttest_test.NewKustTestPluginHarness(t, fmt.Sprintf("/%s", test.name))
|
||||
for idx, patch := range test.patch {
|
||||
th.WriteF(fmt.Sprintf("/%s/patch%d.yaml", test.name, idx), patch)
|
||||
}
|
||||
|
||||
if test.errorExpected {
|
||||
err := th.ErrorFromLoadAndRunTransformer(toConfig(test.patch...), test.base)
|
||||
compareExpectedError(t, test.name, err, test.errorMsg)
|
||||
} else {
|
||||
rm := th.LoadAndRunTransformer(toConfig(test.patch...), test.base)
|
||||
th.AssertActualEqualsExpected(rm, test.expected)
|
||||
}
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
// TestMultiplePatchesWithConflict checks that the conflict are
|
||||
// detected regardless of the order of the patches and regardless
|
||||
// of the schema availibility (SMP vs JSON)
|
||||
func TestMultiplePatchesWithConflict(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
base string
|
||||
patch []string
|
||||
expected string
|
||||
errorExpected bool
|
||||
errorMsg string
|
||||
}{
|
||||
{
|
||||
name: "withschema-label-latest-1.7.9",
|
||||
base: baseResource(Deployment),
|
||||
patch: []string{
|
||||
addLabelAndEnvPatch(Deployment),
|
||||
changeImagePatch(Deployment, "nginx:latest"),
|
||||
changeImagePatch(Deployment, "nginx:1.7.9"),
|
||||
},
|
||||
errorExpected: true,
|
||||
errorMsg: "conflict",
|
||||
},
|
||||
{
|
||||
name: "withschema-latest-label-1.7.9",
|
||||
base: baseResource(Deployment),
|
||||
patch: []string{
|
||||
changeImagePatch(Deployment, "nginx:latest"),
|
||||
addLabelAndEnvPatch(Deployment),
|
||||
changeImagePatch(Deployment, "nginx:1.7.9"),
|
||||
},
|
||||
errorExpected: true,
|
||||
errorMsg: "conflict",
|
||||
},
|
||||
{
|
||||
name: "withschema-1.7.9-label-latest",
|
||||
base: baseResource(Deployment),
|
||||
patch: []string{
|
||||
changeImagePatch(Deployment, "nginx:1.7.9"),
|
||||
addLabelAndEnvPatch(Deployment),
|
||||
changeImagePatch(Deployment, "nginx:latest"),
|
||||
},
|
||||
errorExpected: true,
|
||||
errorMsg: "conflict",
|
||||
},
|
||||
{
|
||||
name: "withschema-1.7.9-latest-label",
|
||||
base: baseResource(Deployment),
|
||||
patch: []string{
|
||||
changeImagePatch(Deployment, "nginx:1.7.9"),
|
||||
changeImagePatch(Deployment, "nginx:latest"),
|
||||
addLabelAndEnvPatch(Deployment),
|
||||
changeImagePatch(Deployment, "nginx:nginx"),
|
||||
},
|
||||
errorExpected: true,
|
||||
errorMsg: "conflict",
|
||||
},
|
||||
{
|
||||
name: "noschema-label-latest-1.7.9",
|
||||
base: baseResource(MyCRD),
|
||||
patch: []string{
|
||||
addLabelAndEnvPatch(MyCRD),
|
||||
changeImagePatch(MyCRD, "nginx:latest"),
|
||||
changeImagePatch(MyCRD, "nginx:1.7.9"),
|
||||
},
|
||||
errorExpected: true,
|
||||
errorMsg: "conflict",
|
||||
},
|
||||
{
|
||||
name: "noschema-latest-label-1.7.9",
|
||||
base: baseResource(MyCRD),
|
||||
patch: []string{
|
||||
changeImagePatch(MyCRD, "nginx:latest"),
|
||||
addLabelAndEnvPatch(MyCRD),
|
||||
changeImagePatch(MyCRD, "nginx:1.7.9"),
|
||||
},
|
||||
errorExpected: false,
|
||||
// There is no conflict detected. It should
|
||||
// be but the JMPConflictDector ignores it.
|
||||
// See https://github.com/kubernetes-sigs/kustomize/issues/1370
|
||||
expected: expectedResultJMP("nginx:1.7.9"),
|
||||
},
|
||||
{
|
||||
name: "noschema-1.7.9-label-latest",
|
||||
base: baseResource(MyCRD),
|
||||
patch: []string{
|
||||
changeImagePatch(MyCRD, "nginx:1.7.9"),
|
||||
addLabelAndEnvPatch(MyCRD),
|
||||
changeImagePatch(MyCRD, "nginx:latest"),
|
||||
},
|
||||
errorExpected: false,
|
||||
// There is no conflict detected. It should
|
||||
// be but the JMPConflictDector ignores it.
|
||||
// See https://github.com/kubernetes-sigs/kustomize/issues/1370
|
||||
expected: expectedResultJMP("nginx:latest"),
|
||||
},
|
||||
{
|
||||
name: "noschema-1.7.9-latest-label",
|
||||
base: baseResource(MyCRD),
|
||||
patch: []string{
|
||||
changeImagePatch(MyCRD, "nginx:1.7.9"),
|
||||
changeImagePatch(MyCRD, "nginx:latest"),
|
||||
addLabelAndEnvPatch(MyCRD),
|
||||
changeImagePatch(MyCRD, "nginx:nginx"),
|
||||
},
|
||||
errorExpected: true,
|
||||
},
|
||||
}
|
||||
|
||||
tc := plugins_test.NewEnvForTest(t).Set()
|
||||
defer tc.Reset()
|
||||
tc.BuildGoPlugin(
|
||||
"builtin", "", "PatchStrategicMergeTransformer")
|
||||
|
||||
for _, test := range tests {
|
||||
th := kusttest_test.NewKustTestPluginHarness(t, fmt.Sprintf("/%s", test.name))
|
||||
for idx, patch := range test.patch {
|
||||
th.WriteF(fmt.Sprintf("/%s/patch%d.yaml", test.name, idx), patch)
|
||||
}
|
||||
|
||||
if test.errorExpected {
|
||||
err := th.ErrorFromLoadAndRunTransformer(toConfig(test.patch...), test.base)
|
||||
compareExpectedError(t, test.name, err, test.errorMsg)
|
||||
} else {
|
||||
rm := th.LoadAndRunTransformer(toConfig(test.patch...), test.base)
|
||||
th.AssertActualEqualsExpected(rm, test.expected)
|
||||
}
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
// TestMultipleNamespaces before the same patch
|
||||
// on two objects have the same name but in a different namespaces
|
||||
func TestMultipleNamespaces(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
base []string
|
||||
patch []string
|
||||
expected []string
|
||||
errorExpected bool
|
||||
errorMsg string
|
||||
}{
|
||||
{
|
||||
name: "withschema-ns1-ns2",
|
||||
base: []string{
|
||||
addNamespace("ns1", baseResource(Deployment)),
|
||||
addNamespace("ns2", baseResource(Deployment)),
|
||||
},
|
||||
patch: []string{
|
||||
addNamespace("ns1", addLabelAndEnvPatch(Deployment)),
|
||||
addNamespace("ns2", addLabelAndEnvPatch(Deployment)),
|
||||
},
|
||||
errorExpected: false,
|
||||
expected: []string{
|
||||
addNamespace("ns1", expectedResultSMP()),
|
||||
addNamespace("ns2", expectedResultSMP()),
|
||||
},
|
||||
},
|
||||
{
|
||||
name: "noschema-ns1-ns2",
|
||||
base: []string{
|
||||
addNamespace("ns1", baseResource(MyCRD)),
|
||||
addNamespace("ns2", baseResource(MyCRD)),
|
||||
},
|
||||
patch: []string{
|
||||
addNamespace("ns1", addLabelAndEnvPatch(MyCRD)),
|
||||
addNamespace("ns2", addLabelAndEnvPatch(MyCRD)),
|
||||
},
|
||||
errorExpected: false,
|
||||
expected: []string{
|
||||
addNamespace("ns1", expectedResultJMP("")),
|
||||
addNamespace("ns2", expectedResultJMP("")),
|
||||
},
|
||||
},
|
||||
{
|
||||
name: "withschema-ns1-ns2",
|
||||
base: []string{addNamespace("ns1", baseResource(Deployment))},
|
||||
patch: []string{addNamespace("ns2", changeImagePatch(Deployment, "nginx:1.7.9"))},
|
||||
errorExpected: true,
|
||||
errorMsg: "failed to find unique target for patch",
|
||||
},
|
||||
{
|
||||
name: "withschema-nil-ns2",
|
||||
base: []string{baseResource(Deployment)},
|
||||
patch: []string{addNamespace("ns2", changeImagePatch(Deployment, "nginx:1.7.9"))},
|
||||
errorExpected: true,
|
||||
errorMsg: "failed to find unique target for patch",
|
||||
},
|
||||
{
|
||||
name: "withschema-ns1-nil",
|
||||
base: []string{addNamespace("ns1", baseResource(Deployment))},
|
||||
patch: []string{changeImagePatch(Deployment, "nginx:1.7.9")},
|
||||
errorExpected: true,
|
||||
errorMsg: "failed to find unique target for patch",
|
||||
},
|
||||
{
|
||||
name: "noschema-ns1-ns2",
|
||||
base: []string{addNamespace("ns1", baseResource(MyCRD))},
|
||||
patch: []string{addNamespace("ns2", changeImagePatch(MyCRD, "nginx:1.7.9"))},
|
||||
errorExpected: true,
|
||||
errorMsg: "failed to find unique target for patch",
|
||||
},
|
||||
{
|
||||
name: "noschema-nil-ns2",
|
||||
base: []string{baseResource(MyCRD)},
|
||||
patch: []string{addNamespace("ns2", changeImagePatch(MyCRD, "nginx:1.7.9"))},
|
||||
errorExpected: true,
|
||||
errorMsg: "failed to find unique target for patch",
|
||||
},
|
||||
{
|
||||
name: "noschema-ns1-nil",
|
||||
base: []string{addNamespace("ns1", baseResource(MyCRD))},
|
||||
patch: []string{changeImagePatch(MyCRD, "nginx:1.7.9")},
|
||||
errorExpected: true,
|
||||
errorMsg: "failed to find unique target for patch",
|
||||
},
|
||||
}
|
||||
|
||||
tc := plugins_test.NewEnvForTest(t).Set()
|
||||
defer tc.Reset()
|
||||
tc.BuildGoPlugin(
|
||||
"builtin", "", "PatchStrategicMergeTransformer")
|
||||
|
||||
for _, test := range tests {
|
||||
th := kusttest_test.NewKustTestPluginHarness(t, fmt.Sprintf("/%s", test.name))
|
||||
for idx, patch := range test.patch {
|
||||
th.WriteF(fmt.Sprintf("/%s/patch%d.yaml", test.name, idx), patch)
|
||||
}
|
||||
|
||||
if test.errorExpected {
|
||||
err := th.ErrorFromLoadAndRunTransformer(toConfig(test.patch...), strings.Join(test.base, "\n---\n"))
|
||||
compareExpectedError(t, test.name, err, test.errorMsg)
|
||||
} else {
|
||||
rm := th.LoadAndRunTransformer(toConfig(test.patch...), strings.Join(test.base, "\n---\n"))
|
||||
th.AssertActualEqualsExpected(rm, strings.Join(test.expected, "---\n"))
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user