kubernetes-sigs/kustomize
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/kustomize.git synced 2026-05-18 02:55:22 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Merge pull request #2181 from phanimarupaka/FieldOptionalForSetter

Browse Source 
Make field optional flag for create setter
This commit is contained in:
Kubernetes Prow Robot
2020-02-05 12:47:55 -08:00
committed by GitHub
parent 11aa07b17f 72e7084639
commit daa9504890
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
cmd/config/internal/commands/cmdcreatesetter.go
View File

@@ -38,7 +38,6 @@ func NewCreateSetterRunner(parent string) *CreateSetterRunner {
"create a partial setter for only part of the field value.")
fixDocs(parent, set)
set.MarkFlagRequired("type")
set.MarkFlagRequired("field")
r.Command = set
return r
}

5
kyaml/setters/addyaml.go
View File

@@ -55,8 +55,9 @@ func (m *customFieldSetter) Filter(object *yaml.RNode) (*yaml.RNode, error) {
return node.PipeE(m)
})
case yaml.ScalarNode:
// only create the setter for fields with the given name
if m.currentFieldName != m.Field {
// if filed is empty, create the setter for all fields with given value
// else only create the setter for given field and value combination, with given name
if m.Field != "" && m.currentFieldName != m.Field {
return object, nil
}
if err := m.create(object); err != nil {