Merge pull request #244 from Liujingfang1/deprecation

Add deprecation message for namePrefix behavior change
This commit is contained in:
Jeff Regan
2018-08-09 13:04:36 -07:00
committed by GitHub

View File

@@ -19,6 +19,7 @@ package transformers
import (
"errors"
"fmt"
"log"
"github.com/kubernetes-sigs/kustomize/pkg/resmap"
@@ -48,6 +49,11 @@ var skipNamePrefixPathConfigs = []PathConfig{
},
}
// deprecateNamePrefixPathConfig will be moved into skipNamePrefixPathConfigs in next release
var deprecateNamePrefixPathConfig = PathConfig{
GroupVersionKind: &schema.GroupVersionKind{Kind: "Namespace"},
}
// NewDefaultingNamePrefixTransformer construct a namePrefixTransformer with defaultNamePrefixPathConfigs.
func NewDefaultingNamePrefixTransformer(nameprefix string) (Transformer, error) {
return NewNamePrefixTransformer(defaultNamePrefixPathConfigs, nameprefix)
@@ -83,6 +89,9 @@ func (o *namePrefixTransformer) Transform(m resmap.ResMap) error {
}
for id := range mf {
if selectByGVK(id.Gvk(), deprecateNamePrefixPathConfig.GroupVersionKind) {
log.Println("Adding nameprefix to Namespace resource will be deprecated in next release.")
}
objMap := mf[id].UnstructuredContent()
for _, path := range o.pathConfigs {
if !selectByGVK(id.Gvk(), path.GroupVersionKind) {