Carl Henrik Lunde
5c7f8b8d73
perf: improve applyOrdering by avoid call to GetByCurrentId
...
This shaves of 14 seconds (one third) of the execution time for a
kustomization tree with 4000 documents, from 40.68s to 27.41s
0 0% 5.44% 18.42s 40.56% sigs.k8s.io/kustomize/api/krusty.(*Kustomizer).applySortOrder
0 0% 5.44% 18.40s 40.52% sigs.k8s.io/kustomize/api/internal/builtins.applyOrdering
before
(pprof) top20 -cum
Showing nodes accounting for 5.85s, 12.88% of 45.41s total
Dropped 622 nodes (cum <= 0.23s)
Showing top 20 nodes out of 157
flat flat% sum% cum cum%
0 0% 0% 40.68s 89.58% github.com/spf13/cobra.(*Command).Execute
0 0% 0% 40.68s 89.58% github.com/spf13/cobra.(*Command).ExecuteC
0 0% 0% 40.68s 89.58% github.com/spf13/cobra.(*Command).execute
0 0% 0% 40.68s 89.58% main.main
0 0% 0% 40.68s 89.58% runtime.main
0 0% 0% 40.68s 89.58% sigs.k8s.io/kustomize/kustomize/v5/commands/build.NewCmdBuild.func1
0 0% 0% 40.12s 88.35% sigs.k8s.io/kustomize/api/krusty.(*Kustomizer).Run
0.51s 1.12% 1.12% 33.20s 73.11% sigs.k8s.io/kustomize/api/resource.(*Resource).CurId
0 0% 1.12% 26.95s 59.35% sigs.k8s.io/kustomize/api/resmap.(*resWrangler).GetMatchingResourcesByCurrentId
0.35s 0.77% 1.89% 26.95s 59.35% sigs.k8s.io/kustomize/api/resmap.(*resWrangler).filteredById
0.07s 0.15% 2.05% 25.53s 56.22% sigs.k8s.io/kustomize/api/resmap.GetCurrentId
0 0% 2.05% 21.68s 47.74% sigs.k8s.io/kustomize/api/internal/target.(*KustTarget).MakeCustomizedResMap (inline)
0 0% 2.05% 21.68s 47.74% sigs.k8s.io/kustomize/api/internal/target.(*KustTarget).makeCustomizedResMap
0.54s 1.19% 3.24% 19.75s 43.49% sigs.k8s.io/kustomize/api/resource.(*Resource).GetGvk (inline)
1s 2.20% 5.44% 19.21s 42.30% sigs.k8s.io/kustomize/kyaml/resid.GvkFromNode
0 0% 5.44% 18.42s 40.56% sigs.k8s.io/kustomize/api/internal/builtins.(*SortOrderTransformerPlugin).Transform
0 0% 5.44% 18.42s 40.56% sigs.k8s.io/kustomize/api/krusty.(*Kustomizer).applySortOrder
0 0% 5.44% 18.40s 40.52% sigs.k8s.io/kustomize/api/internal/builtins.applyOrdering
0.87s 1.92% 7.36% 16.55s 36.45% sigs.k8s.io/kustomize/kyaml/yaml.visitMappingNodeFields
2.51s 5.53% 12.88% 15.68s 34.53% sigs.k8s.io/kustomize/kyaml/yaml.visitFieldsWhileTrue
after
(pprof) top20 -cum
Showing nodes accounting for 1.23s, 3.85% of 31.98s total
Dropped 584 nodes (cum <= 0.16s)
Showing top 20 nodes out of 184
flat flat% sum% cum cum%
0 0% 0% 27.41s 85.71% github.com/spf13/cobra.(*Command).Execute
0 0% 0% 27.41s 85.71% github.com/spf13/cobra.(*Command).ExecuteC
0 0% 0% 27.41s 85.71% github.com/spf13/cobra.(*Command).execute
0 0% 0% 27.41s 85.71% main.main
0 0% 0% 27.41s 85.71% runtime.main
0 0% 0% 27.41s 85.71% sigs.k8s.io/kustomize/kustomize/v5/commands/build.NewCmdBuild.func1
0 0% 0% 26.85s 83.96% sigs.k8s.io/kustomize/api/krusty.(*Kustomizer).Run
0 0% 0% 22.07s 69.01% sigs.k8s.io/kustomize/api/internal/target.(*KustTarget).MakeCustomizedResMap (inline)
0 0% 0% 22.07s 69.01% sigs.k8s.io/kustomize/api/internal/target.(*KustTarget).makeCustomizedResMap
0.38s 1.19% 1.19% 20.69s 64.70% sigs.k8s.io/kustomize/api/resource.(*Resource).CurId
0 0% 1.19% 13.64s 42.65% sigs.k8s.io/kustomize/api/resmap.(*resWrangler).Append
0 0% 1.19% 13.55s 42.37% sigs.k8s.io/kustomize/api/resmap.(*resWrangler).GetMatchingResourcesByCurrentId (inline)
0.12s 0.38% 1.56% 13.55s 42.37% sigs.k8s.io/kustomize/api/resmap.(*resWrangler).filteredById
0.01s 0.031% 1.59% 12.67s 39.62% sigs.k8s.io/kustomize/api/resmap.GetCurrentId
0.21s 0.66% 2.25% 12.49s 39.06% sigs.k8s.io/kustomize/api/resource.(*Resource).GetGvk (inline)
0.51s 1.59% 3.85% 12.28s 38.40% sigs.k8s.io/kustomize/kyaml/resid.GvkFromNode
0 0% 3.85% 11.52s 36.02% sigs.k8s.io/kustomize/api/internal/target.(*KustTarget).IgnoreLocal
0 0% 3.85% 10.53s 32.93% sigs.k8s.io/kustomize/api/internal/target.(*KustTarget).AccumulateTarget
0 0% 3.85% 10.53s 32.93% sigs.k8s.io/kustomize/api/internal/target.(*KustTarget).accumulateResources
0 0% 3.85% 10.53s 32.93% sigs.k8s.io/kustomize/api/internal/target.(*KustTarget).accumulateTarget
2023-10-30 22:31:52 +01:00
chansuke
e002b49244
hotfix: return error instead of log at FromMapAndOption ( #5381 )
...
* hotfix: return error instead of log at `FromMapAndOption`
* chore: show error message
* hotfix: use correct function
* hotix: use `t.Helper()` and fix `t *testing.T order
* hotfix: wrapt the error of `FromMapAndOption`
* hotfix: meaningful message for an error
* hotfix: summarize in one line
* hotfix: fix the abandoned error and show meaningful message
* hotfix: start with helper function
* Keep TODO comment
2023-10-27 23:01:47 +02:00
Nick
bd435d4154
Add Generator Tasks to Documentation ( #5368 )
...
* Update tasks index description
* Create generators folder
* Update tasks/generators titles
* Add rollouts placeholder
* Add generate configmap from file example
* Add literals and env file example
* Add propogation example
* Consistent punctuation
* Update grammar
* Clean up configmaps page
* Remove examples from configMapGenerator ref page
* Move secret examples to Tasks
* Clean up spacing
* Consolidate cm and secret
* Consistent grammar
* Cleanup
* Address feedback
* Bump date
* Fix propagate spelling
* Remove roll out updates section
* Separate configmap and secret generator tasks
* Add secret from file example
* Add secret from literals example
* Update tls secret example
* Update task page weights
* Link cm generator reference
* Add link to secret reference
* Remove secretGenerator example from reference section
* Add configmap options task, clean up reference
* Add file with key example
* Secrets are base64 encoded
2023-10-27 22:26:37 +02:00
Kubernetes Prow Robot
a869386996
Merge pull request #5423 from natasha41575/roadmap-update
...
update roadmap based on review comments
2023-10-27 18:54:58 +02:00
Kubernetes Prow Robot
a40379782e
Merge pull request #5420 from soltysh/security_contants
...
Update security contacts for sig-cli
2023-10-27 18:37:56 +02:00
Natasha Sarkar
761893d1fc
Merge pull request #5351 from natasha41575/roadmap
...
update kustomize roadmap 23-24
2023-10-27 11:20:58 -05:00
natasha41575
9f4f9b323c
review comments
2023-10-27 10:59:30 -05:00
Kubernetes Prow Robot
48fd585620
Merge pull request #5408 from koba1t/fix_add_checksum_create_step_in_release_scripts
...
fix add checksum create step in release scripts
2023-10-27 02:29:19 +02:00
Natasha Sarkar
96ad106ee1
Use upstream go-yaml fork and remove our internal one ( #5412 )
...
* test new yaml fork
* delete old kyaml fork
* update to sigs yaml 1.4.0
* remove comments
2023-10-25 19:48:22 +02:00
Maciej Szulik
e2b0297d18
Update security contacts for sig-cli
2023-10-25 19:02:36 +02:00
koba1t
d6fa69d26e
use pushd when generate checksum
2023-10-25 05:19:25 +09:00
Kubernetes Prow Robot
cba3f1115f
Merge pull request #5409 from stormqueen1990/refactor/move-reusable-set-bits
...
refactor: move reusable bits in preparation for new 'edit set' commands
2023-10-23 17:45:58 +02:00
Mauren Berti
5568521cd1
fix: lint issues
...
Change package for test to 'util_test' and add dot-import for the main package.
2023-10-21 17:47:49 -04:00
Mauren Berti
a5a2db577f
refactor: move reusable bits in preparation for edit set commands
...
* Move configmapSecretFlagsAndArgs.go to the internal/util folder so it can be
reused by the edit set commands.
2023-10-21 16:55:37 -04:00
koba1t
b6387b9eaf
fix add checksum create step in release scripts
2023-10-21 15:41:00 +09:00
Kubernetes Prow Robot
0f2618b21d
Merge pull request #5402 from koba1t/unpinEverything
...
release cleanup, unpin the modules
2023-10-19 22:58:25 +02:00
koba1t
0465637335
Back to development mode; unpin the modules
2023-10-20 05:30:43 +09:00
Natasha Sarkar
e71072b90b
Merge pull request #5397 from koba1t/fix_release_binary_archive_contains_unnecessary_dir
...
fix release binary archive contains unnecessary dir
kustomize/v5.2.1
2023-10-19 15:11:23 -05:00
koba1t
289e78c136
fix release binary archive contains unnecessary dir
2023-10-20 04:00:13 +09:00
Kubernetes Prow Robot
001ab61b37
Merge pull request #5395 from koba1t/pinToApi
...
Update api to v0.15.0
kustomize/v5.2.0
2023-10-19 19:57:18 +02:00
koba1t
16395012d1
Update api to v0.15.0
2023-10-20 02:36:50 +09:00
Kubernetes Prow Robot
5497967665
Merge pull request #5394 from koba1t/pinToCmdConfig
...
Update cmd/config to v0.12.0
api/v0.15.0
2023-10-19 19:27:53 +02:00
koba1t
0115ae6da4
Update cmd/config to v0.12.0
2023-10-20 02:11:11 +09:00
Kubernetes Prow Robot
bb5022441a
Merge pull request #5393 from koba1t/pinToKyaml
...
Update kyaml to v0.15.0
cmd/config/v0.12.0
2023-10-19 18:59:14 +02:00
koba1t
8668b74622
Update kyaml to v0.15.0
2023-10-20 01:07:49 +09:00
Kubernetes Prow Robot
752bb2ef41
Merge pull request #5303 from antoooks/refactor/ci-tasks-improvement-new
...
refactor/ci tasks improvement new
kyaml/v0.15.0
2023-10-19 09:41:50 +02:00
Kubernetes Prow Robot
bde28b1320
Merge pull request #5324 from charles-chenzz/fix_doc_refs
...
update deprecated doc refs
2023-10-18 17:41:01 +02:00
Kubernetes Prow Robot
689dcefa3a
Merge pull request #5378 from kubernetes-sigs/dependabot/go_modules/cmd/depprobcheck/golang.org/x/net-0.17.0
...
build(deps): bump golang.org/x/net from 0.8.0 to 0.17.0 in /cmd/depprobcheck
2023-10-18 16:05:15 +02:00
dependabot[bot]
f3e263a051
build(deps): bump golang.org/x/net in /cmd/depprobcheck
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.8.0 to 0.17.0.
- [Commits](https://github.com/golang/net/compare/v0.8.0...v0.17.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-18 13:27:09 +00:00
Kubernetes Prow Robot
fa48ab16bf
Merge pull request #5377 from kubernetes-sigs/dependabot/go_modules/functions/examples/application-cr/image/golang.org/x/net-0.17.0
...
build(deps): bump golang.org/x/net from 0.8.0 to 0.17.0 in /functions/examples/application-cr/image
2023-10-18 15:25:21 +02:00
dependabot[bot]
0eca5c4b06
build(deps): bump golang.org/x/net
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.8.0 to 0.17.0.
- [Commits](https://github.com/golang/net/compare/v0.8.0...v0.17.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-17 19:51:16 +00:00
Kubernetes Prow Robot
6b76c807f5
Merge pull request #5376 from kubernetes-sigs/dependabot/go_modules/functions/examples/fn-framework-application/golang.org/x/net-0.17.0
...
build(deps): bump golang.org/x/net from 0.8.0 to 0.17.0 in /functions/examples/fn-framework-application
2023-10-17 21:48:54 +02:00
dependabot[bot]
76695414c7
build(deps): bump golang.org/x/net
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.8.0 to 0.17.0.
- [Commits](https://github.com/golang/net/compare/v0.8.0...v0.17.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-17 19:24:53 +00:00
Jan-Otto Kröpke
d64ac13447
kustomize: Add support for OCI based helm repos ( #5167 )
...
* kustomize: Add support for OCI based helm repos
Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de >
* Update api/internal/builtins/HelmChartInflationGenerator.go
* Update plugin/builtin/helmchartinflationgenerator/HelmChartInflationGenerator.go
* go fmt
Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de >
* s/expectedHelmExternalDns/expectedHelmExternalDNS
Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de >
* commit
Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de >
* commit with content
Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de >
* Apply suggestions from maintainer
* go work sync
* added test
---------
Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de >
2023-10-17 21:24:00 +02:00
Kubernetes Prow Robot
f80d9c41e5
Merge pull request #5370 from phooijenga/patch-1
...
merge2: fix duplicate test case
2023-10-14 18:41:37 +02:00
Kubernetes Prow Robot
2f99707792
Merge pull request #5367 from stormqueen1990/fix/edit-add-configmap-namespace
...
fix: add namespace option to 'edit add configmap' command
2023-10-14 09:39:40 +02:00
Mauren Berti
7a08dde7ac
fix: change spaces for tabs
2023-10-13 18:35:27 -04:00
Kubernetes Prow Robot
81297df4ff
Merge pull request #5374 from kundan2707/broken_link
...
Path for glossary.md corrected
2023-10-13 22:14:55 +02:00
Kundan Kumar
c4137c0c2a
Path for glossary corrected
2023-10-12 10:29:05 +05:30
charles-chenzz
944c72a275
update deprecated doc refs
2023-10-11 22:30:43 +08:00
Paul
46e2d72213
merge2: fix duplicate test case
2023-10-10 14:12:07 +02:00
Mauren Berti
6cb85e8544
fix: remove unnecessary empty space as per lint
2023-10-09 19:28:37 -04:00
Mauren Berti
6ef9773c02
docs: update comment to reflect usage of namespace
...
Update the comment for the namespace option to reflect its real usage for both
secret and configmap.
2023-10-09 17:17:49 -04:00
Mauren Berti
11aa57e67f
fix: add --namespace flag to edit add configmap
...
* Add the option to specify a namespace when using 'kustomize edit add configmap'
for code parity with 'edit add secret'.
* Rename constants for 'add configmap'/'add secret' so they are standardized.
* Create new constant for the 'namespace' flag.
* Update test cases to cover new scenarios.
2023-10-09 17:17:40 -04:00
Kubernetes Prow Robot
779f153071
Merge pull request #5353 from charles-chenzz/git_submodule
...
git submodule need origin
2023-10-07 03:27:32 +02:00
charles-chenzz
60d7ee6710
add orgin back when clone repo (due to git submodule).
2023-10-07 07:50:13 +08:00
Kubernetes Prow Robot
852739c477
Merge pull request #5265 from rodrigc/update-remote-example
...
doc: update example to use tag v3.3.1
2023-10-06 21:21:37 +02:00
Craig Rodrigues
bee2e5f50c
doc: update example to use tag v3.3.1
...
Signed-off-by: Craig Rodrigues <rodrigc@crodrigues.org >
2023-10-06 11:38:17 -07:00
Natasha Sarkar
ace2d53b18
Merge pull request #5333 from hailkomputer/add-skip-validation-flag-to-edit-add-resource
...
Add --no-verify flag to edit add resource command
2023-10-06 13:00:27 -05:00
Kubernetes Prow Robot
aeb7cb2a40
Merge pull request #5342 from superbrothers/fix-issue4905
...
Update imdario/mergo to v0.3.13
2023-10-04 22:06:34 +02:00