Katrina Verey
85d623bc86
Add a rich example of fn framework for abstraction
2023-04-13 16:57:50 -04:00
Kubernetes Prow Robot
d3184da4c6
Merge pull request #5111 from yutaroyamanaka/reenable-skipped-tests
...
Re-enable tests disabled in #3880
2023-04-05 11:45:48 -07:00
Kubernetes Prow Robot
eadb469712
Merge pull request #4924 from koba1t/chore/set_go_version_on_actions_from_gowork_file
...
Set go version on github actions from gowork file
2023-04-05 10:17:46 -07:00
yutaroyamanaka
2649d39fd3
docker build locally because gcr.io/kustomize-functions/e2econtainerconfig doesn't exist in the public
2023-04-04 18:22:43 +09:00
yutaroyamanaka
faab836ec9
use test helpers
2023-04-01 23:16:58 +09:00
yutaroyamanaka
c9f500cc0b
add another resource for making sure an existing resource isn't affeced by a generator
2023-04-01 23:13:04 +09:00
Yutaro
42bf3c0e2b
prevent all uses of YAML aliases from being overwritten by a transformer ( #5096 )
...
* return copied Node
* add a test case about imageTagTransformer for anchor scenario
* add TestPatchTransformerAnchor
* TestReplacementTransformerAnchor
2023-03-31 16:07:50 -07:00
Kubernetes Prow Robot
3b395a9da2
Merge pull request #5074 from plobsing/master
...
Only strip surrounding quotes if there are at least two characters.
2023-03-31 15:11:49 -07:00
Peter Lobsinger
633da991d2
Only strip surrounding quotes if there are at least two characters.
...
Otherwise, a value consisting of a single quote character triggers a
panic:
go test krusty/configmaps_test.go
--- FAIL: TestDataIsSingleQuote (0.00s)
panic: runtime error: slice bounds out of range [1:0] [recovered]
panic: runtime error: slice bounds out of range [1:0]
2023-03-28 14:17:47 -07:00
Kubernetes Prow Robot
e07b8a5d15
Merge pull request #5105 from koba1t/chore/use_enable-all_option_for_golangci-lint
...
use enable-all on golangci-lint
2023-03-27 14:26:21 -07:00
yutaroyamanaka
71a7a7df13
re-enabled TestFnContainerGenerator with enable-gcp-services
2023-03-27 23:00:24 +09:00
yutaroyamanaka
436a047617
re-enabled TestFnContainerTransformer with e2econtainerconfig container
2023-03-27 21:33:57 +09:00
xin gu
4d70a36c25
emove the kyaml/openapi/kubernetesapi/v1_21_2/swagger.pb ( #5077 )
2023-03-23 10:48:31 -07:00
koba1t
304d0e951f
use enable-all on golangci-lint
2023-03-23 05:54:54 +09:00
Kubernetes Prow Robot
2fdb35614d
Merge pull request #5080 from chlunde/perf-2
...
perf: Intersection: Avoid callid AllIds inside inner loop
2023-03-20 23:03:07 -07:00
Kubernetes Prow Robot
5dff9df1f7
Merge pull request #5099 from justinsb/dont_swallow_helm_errors
...
Don't swallow helm execution errors
2023-03-20 12:35:09 -07:00
Kubernetes Prow Robot
84682a1159
Merge pull request #5101 from justinsb/fixlint_2
...
Fix unused error value
2023-03-20 12:23:07 -07:00
justinsb
c151147258
Don't swallow helm execution errors
...
These are otherwise hard to debug.
2023-03-20 19:14:07 +00:00
justinsb
317fcadccb
Fix unused error value
...
The linter was complaining about err being unchecked.
2023-03-20 19:11:11 +00:00
Kubernetes Prow Robot
a2e9682002
Merge pull request #5100 from justinsb/fixlint
...
Fix lint task in CI
2023-03-20 10:27:19 -07:00
justinsb
5dcf0ae683
Fix lint task in CI
...
The lint task was failing at head, due to a nolint:exhaustive error
directive that golangci nolintlint believes is unused.
Issue seems to be https://github.com/golangci/golangci-lint/issues/3228
and seems to be a bug in golang-ci / nolintlint, using the workaround
proposed in https://github.com/golangci/golangci-lint/issues/1940
which is to clear the cache between runs.
2023-03-20 14:14:30 +00:00
Katrina Verey
ce3e394a41
Merge pull request #5091 from KnVerey/unpinEverything
...
Back to development mode; unpin the modules
2023-03-13 21:58:32 -04:00
Katrina Verey
0c92647760
Back to development mode; unpin the modules
2023-03-13 21:43:46 -04:00
Katrina Verey
39527da73c
Merge pull request #5090 from KnVerey/pinToApi
...
Update api to v0.13.2
kustomize/v5.0.1
2023-03-13 21:20:22 -04:00
Katrina Verey
fa90046136
Update api to v0.13.2
2023-03-13 21:07:40 -04:00
Katrina Verey
efe1374940
Merge pull request #5089 from KnVerey/pinToCmdConfig
...
Update cmd/config to v0.11.1
api/v0.13.2
2023-03-13 20:49:50 -04:00
Katrina Verey
b751ffe5a0
Update cmd/config to v0.11.1
2023-03-13 20:27:40 -04:00
Katrina Verey
28a2a01c29
Merge pull request #5088 from KnVerey/pinToKyaml
...
Update kyaml to v0.14.1
cmd/config/v0.11.1
2023-03-13 19:45:23 -04:00
Katrina Verey
0c650423ed
Update kyaml to v0.14.1
2023-03-13 19:24:20 -04:00
Katrina Verey
4ffc861854
Merge pull request #5087 from KnVerey/prerelease_update
...
Changes from local test run
kyaml/v0.14.1
2023-03-13 19:11:00 -04:00
Katrina Verey
8338873e56
Changes from local test run
2023-03-13 18:40:16 -04:00
Katrina Verey
dd520f8889
Revert strict decoding of Kustomization due to regression in anchor handling ( #5073 )
...
* Revert strict decoding of Kustomization due to regression in anchor handling
* Empty commit
2023-03-13 13:46:47 -07:00
Carl Henrik Lunde
4842d8be60
perf: Intersection: Avoid callid AllIds inside inner loop
...
This shaves of another 8.5 seconds (one third) of the remaining execution
time for a kustomization tree with 4000 documents, reducing the execution
time from 27.46s to 18.94s
0.02s 0.062% 11.14% 8.45s 26.36% sigs.k8s.io/kustomize/api/internal/accumulator.(*ResAccumulator).Intersection
0.06s 0.19% 11.32% 8.32s 25.95% sigs.k8s.io/kustomize/api/resmap.(*resWrangler).AllIds
before
(pprof) top25 -cum
Showing nodes accounting for 3.63s, 11.32% of 32.06s total
Dropped 614 nodes (cum <= 0.16s)
Showing top 25 nodes out of 171
flat flat% sum% cum cum%
0 0% 0% 27.46s 85.65% github.com/spf13/cobra.(*Command).Execute
0 0% 0% 27.46s 85.65% github.com/spf13/cobra.(*Command).ExecuteC
0 0% 0% 27.46s 85.65% github.com/spf13/cobra.(*Command).execute
0 0% 0% 27.46s 85.65% main.main
0 0% 0% 27.46s 85.65% runtime.main
0 0% 0% 27.46s 85.65% sigs.k8s.io/kustomize/kustomize/v5/commands/build.NewCmdBuild.func1
0 0% 0% 26.95s 84.06% sigs.k8s.io/kustomize/api/krusty.(*Kustomizer).Run
0 0% 0% 22.09s 68.90% sigs.k8s.io/kustomize/api/internal/target.(*KustTarget).MakeCustomizedResMap (inline)
0 0% 0% 22.09s 68.90% sigs.k8s.io/kustomize/api/internal/target.(*KustTarget).makeCustomizedResMap
0.29s 0.9% 0.9% 20.96s 65.38% sigs.k8s.io/kustomize/api/resource.(*Resource).CurId
0 0% 0.9% 13.61s 42.45% sigs.k8s.io/kustomize/api/resmap.(*resWrangler).Append
0 0% 0.9% 13.60s 42.42% sigs.k8s.io/kustomize/api/resmap.(*resWrangler).GetMatchingResourcesByCurrentId (partial-inline)
0.14s 0.44% 1.34% 13.60s 42.42% sigs.k8s.io/kustomize/api/resmap.(*resWrangler).filteredById
0.05s 0.16% 1.50% 12.91s 40.27% sigs.k8s.io/kustomize/api/resmap.GetCurrentId
0.25s 0.78% 2.28% 12.48s 38.93% sigs.k8s.io/kustomize/api/resource.(*Resource).GetGvk (inline)
0.49s 1.53% 3.81% 12.23s 38.15% sigs.k8s.io/kustomize/kyaml/resid.GvkFromNode
0 0% 3.81% 11.61s 36.21% sigs.k8s.io/kustomize/api/internal/target.(*KustTarget).IgnoreLocal
0 0% 3.81% 10.47s 32.66% sigs.k8s.io/kustomize/api/internal/target.(*KustTarget).AccumulateTarget
0 0% 3.81% 10.47s 32.66% sigs.k8s.io/kustomize/api/internal/target.(*KustTarget).accumulateTarget
0.01s 0.031% 3.84% 10.46s 32.63% sigs.k8s.io/kustomize/api/internal/target.(*KustTarget).accumulateResources
0 0% 3.84% 10.43s 32.53% sigs.k8s.io/kustomize/api/internal/target.(*KustTarget).accumulateDirectory
0.64s 2.00% 5.83% 10.12s 31.57% sigs.k8s.io/kustomize/kyaml/yaml.visitMappingNodeFields
1.68s 5.24% 11.07% 9.48s 29.57% sigs.k8s.io/kustomize/kyaml/yaml.visitFieldsWhileTrue
0.02s 0.062% 11.14% 8.45s 26.36% sigs.k8s.io/kustomize/api/internal/accumulator.(*ResAccumulator).Intersection
0.06s 0.19% 11.32% 8.32s 25.95% sigs.k8s.io/kustomize/api/resmap.(*resWrangler).AllIds
after
(pprof) top30 -cum
Showing nodes accounting for 5.04s, 22.63% of 22.27s total
Dropped 540 nodes (cum <= 0.11s)
Showing top 30 nodes out of 209
flat flat% sum% cum cum%
0 0% 0% 18.94s 85.05% github.com/spf13/cobra.(*Command).Execute
0 0% 0% 18.94s 85.05% github.com/spf13/cobra.(*Command).ExecuteC
0 0% 0% 18.94s 85.05% github.com/spf13/cobra.(*Command).execute
0 0% 0% 18.94s 85.05% main.main
0 0% 0% 18.94s 85.05% runtime.main
0 0% 0% 18.94s 85.05% sigs.k8s.io/kustomize/kustomize/v5/commands/build.NewCmdBuild.func1
0 0% 0% 18.40s 82.62% sigs.k8s.io/kustomize/api/krusty.(*Kustomizer).Run
0 0% 0% 13.65s 61.29% sigs.k8s.io/kustomize/api/internal/target.(*KustTarget).MakeCustomizedResMap (inline)
0 0% 0% 13.65s 61.29% sigs.k8s.io/kustomize/api/internal/target.(*KustTarget).makeCustomizedResMap
0 0% 0% 13.52s 60.71% sigs.k8s.io/kustomize/api/resmap.(*resWrangler).Append
0 0% 0% 13.44s 60.35% sigs.k8s.io/kustomize/api/resmap.(*resWrangler).GetMatchingResourcesByCurrentId (inline)
0.16s 0.72% 0.72% 13.44s 60.35% sigs.k8s.io/kustomize/api/resmap.(*resWrangler).filteredById
0.04s 0.18% 0.9% 12.54s 56.31% sigs.k8s.io/kustomize/api/resmap.GetCurrentId
0.19s 0.85% 1.75% 12.49s 56.08% sigs.k8s.io/kustomize/api/resource.(*Resource).CurId
0 0% 1.75% 10.37s 46.56% sigs.k8s.io/kustomize/api/internal/target.(*KustTarget).AccumulateTarget
0 0% 1.75% 10.37s 46.56% sigs.k8s.io/kustomize/api/internal/target.(*KustTarget).accumulateResources
0 0% 1.75% 10.37s 46.56% sigs.k8s.io/kustomize/api/internal/target.(*KustTarget).accumulateTarget
0 0% 1.75% 10.34s 46.43% sigs.k8s.io/kustomize/api/internal/target.(*KustTarget).accumulateDirectory
0.19s 0.85% 2.60% 7.82s 35.11% sigs.k8s.io/kustomize/api/resource.(*Resource).GetGvk (inline)
0.42s 1.89% 4.49% 7.63s 34.26% sigs.k8s.io/kustomize/kyaml/resid.GvkFromNode
0.26s 1.17% 5.66% 6.01s 26.99% sigs.k8s.io/kustomize/kyaml/yaml.visitMappingNodeFields
0 0% 5.66% 5.76s 25.86% sigs.k8s.io/kustomize/api/internal/accumulator.(*ResAccumulator).MergeAccumulator
1.12s 5.03% 10.69% 5.75s 25.82% sigs.k8s.io/kustomize/kyaml/yaml.visitFieldsWhileTrue
0 0% 10.69% 5.57s 25.01% sigs.k8s.io/kustomize/api/resmap.(*resWrangler).appendAll (inline)
0 0% 10.69% 5.55s 24.92% sigs.k8s.io/kustomize/api/internal/accumulator.(*ResAccumulator).AppendAll (inline)
0 0% 10.69% 5.55s 24.92% sigs.k8s.io/kustomize/api/resmap.(*resWrangler).AppendAll
0 0% 10.69% 4.73s 21.24% sigs.k8s.io/kustomize/api/internal/builtins.(*SortOrderTransformerPlugin).Transform
0 0% 10.69% 4.73s 21.24% sigs.k8s.io/kustomize/api/krusty.(*Kustomizer).applySortOrder
0 0% 10.69% 4.72s 21.19% sigs.k8s.io/kustomize/api/internal/builtins.applyOrdering
2.66s 11.94% 22.63% 4.63s 20.79% sigs.k8s.io/kustomize/kyaml/yaml.visitMappingNodeFields.func2
2023-03-12 15:50:11 +01:00
Kubernetes Prow Robot
bf6e6ad33b
Merge pull request #5085 from koba1t/chore/update_golangci_to_1.51.2
...
update golangci-lint to v1.51.2
2023-03-10 14:28:39 -08:00
koba1t
e1094da3cf
skip unrelevant lint
2023-03-11 05:11:47 +09:00
koba1t
7d150ce973
Revert "use enable-all on golangci-lint"
...
This reverts commit 39264a7057 .
2023-03-11 05:08:25 +09:00
koba1t
39264a7057
use enable-all on golangci-lint
2023-03-09 05:25:19 +09:00
koba1t
736e166168
update golangci-lint to 1.51.2
2023-03-09 05:08:25 +09:00
Kubernetes Prow Robot
e8b521e3ab
Merge pull request #5053 from kubernetes-sigs/dependabot/go_modules/functions/examples/application-cr/image/golang.org/x/net-0.7.0
...
Bump golang.org/x/net from 0.4.0 to 0.7.0 in /functions/examples/application-cr/image
2023-02-28 11:33:16 -08:00
dependabot[bot]
a4954d386a
Bump golang.org/x/net in /functions/examples/application-cr/image
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.4.0 to 0.7.0.
- [Release notes](https://github.com/golang/net/releases )
- [Commits](https://github.com/golang/net/compare/v0.4.0...v0.7.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-27 18:17:11 +00:00
Kubernetes Prow Robot
976193ce70
Merge pull request #5054 from kubernetes-sigs/dependabot/go_modules/cmd/depprobcheck/golang.org/x/net-0.7.0
...
Bump golang.org/x/net from 0.4.0 to 0.7.0 in /cmd/depprobcheck
2023-02-27 10:08:39 -08:00
dependabot[bot]
ee0b26601b
Bump golang.org/x/net from 0.4.0 to 0.7.0 in /cmd/depprobcheck
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.4.0 to 0.7.0.
- [Release notes](https://github.com/golang/net/releases )
- [Commits](https://github.com/golang/net/compare/v0.4.0...v0.7.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-27 16:35:34 +00:00
Kubernetes Prow Robot
78e310231e
Merge pull request #5065 from kubernetes-sigs/dependabot/go_modules/cmd/depprobcheck/golang.org/x/crypto-0.1.0
...
Bump golang.org/x/crypto from 0.0.0-20210921155107-089bfa567519 to 0.1.0 in /cmd/depprobcheck
2023-02-27 08:34:38 -08:00
Kubernetes Prow Robot
ffa554b371
Merge pull request #5064 from kubernetes-sigs/dependabot/go_modules/functions/examples/application-cr/image/golang.org/x/crypto-0.1.0
...
Bump golang.org/x/crypto from 0.0.0-20210921155107-089bfa567519 to 0.1.0 in /functions/examples/application-cr/image
2023-02-27 08:26:39 -08:00
dependabot[bot]
68a0fc95da
Bump golang.org/x/crypto in /cmd/depprobcheck
...
Bumps [golang.org/x/crypto](https://github.com/golang/crypto ) from 0.0.0-20210921155107-089bfa567519 to 0.1.0.
- [Release notes](https://github.com/golang/crypto/releases )
- [Commits](https://github.com/golang/crypto/commits/v0.1.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/crypto
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-25 03:30:10 +00:00
dependabot[bot]
9b43e76947
Bump golang.org/x/crypto in /functions/examples/application-cr/image
...
Bumps [golang.org/x/crypto](https://github.com/golang/crypto ) from 0.0.0-20210921155107-089bfa567519 to 0.1.0.
- [Release notes](https://github.com/golang/crypto/releases )
- [Commits](https://github.com/golang/crypto/commits/v0.1.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/crypto
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-25 00:50:47 +00:00
Kubernetes Prow Robot
adf760e246
Merge pull request #5058 from ephesused/optimize-gvk-version
...
perf: optimize Gvk.ApiVersion()
2023-02-21 11:57:56 -08:00
Kubernetes Prow Robot
7a89df8350
Merge pull request #5048 from cailynse/issue-5039
...
Remove Log Assignment to Stdout
2023-02-21 11:23:56 -08:00
Ed Overton
93d7511b38
perf: optimize Gvk.ApiVersion()
...
Convert Gvk.ApiVersion() from using strings.Builder to raw string
concatenation. The logic in Gvk.ApiVersion() is simple enough that
raw concatenation executes quicker and consumes less memory.
2023-02-21 11:02:57 -05:00
Cailyn Edwards
7c33fe30b7
Remove Log Assignment to Stdout
2023-02-21 10:53:22 -05:00